cd022f1592
EmotePacket: make FLAG_SERVER constant public
2020-07-10 20:02:32 +01:00
4ae3fd7734
Player: Reset spawn chunk send count if teleporting pre-spawn
2020-07-09 12:17:19 +01:00
b2249f93c0
TaskHandler: bail if given a task that already has a handler
...
This fixes undefined behaviour when scheduling the same task twice. This is usually accidental and almost never desirable.
Note that this still allows a task to be scheduled again after it has
been cancelled; it only disallows scheduling a task multiple times
concurrently.
This commit will probably break MyPlot and other plugins that have
self-scheduling tasks, but as far as I can tell those use-cases should
be replaced with self-cancelling repeating tasks anyway.
2020-07-08 11:02:33 +01:00
303344783a
CheckTestCompletionTask: use TaskHandler->cancel()
2020-07-08 10:57:20 +01:00
75e0844ff5
MainLogger: log stack traces with CRITICAL level
...
maybe this will get people to send the whole thing instead of just the error message? ...
2020-07-08 10:45:15 +01:00
18fabf5466
3.14.2 is next
2020-07-08 10:32:07 +01:00
2751c59979
Release 3.14.1
2020-07-08 10:32:07 +01:00
d99ffbd66c
Attribute: register lava_movement attribute
...
this is purely to fix crashes when decoding net packets
2020-07-08 10:21:20 +01:00
a34f3261cb
event: harden APIs that accept arrays
...
plugin devs can't be relied on to pass the proper types to these APIs, and when the wrong types get passed it makes type errors appear from inside the internals.
2020-07-04 21:55:23 +01:00
8ce0022de6
protocol: added UUInventorySlotOffset constants
2020-07-04 21:37:37 +01:00
fb6491ddeb
BanListCommand: sort output into lexical order
2020-07-03 11:23:00 +01:00
3b961d0e5f
WhitelistCommand: sort output of /whitelist list into lexical order
2020-07-03 11:19:23 +01:00
a60fc4cc28
ListCommand: sort output into lexical order
2020-07-03 11:15:31 +01:00
b747899fdd
PluginsCommand: sort plugins list into lexical order
2020-07-03 11:13:32 +01:00
57b6451e16
Fix projectile motion being changed by the ladder, close #3602 ( #3631 )
2020-06-27 21:18:39 +01:00
8cf025a2df
Default isVerified to true ( #3644 )
2020-06-27 21:17:34 +01:00
8480ee82ea
Player: track hardcoded window state, fixes crashes opening inventory on high-latency connections
2020-06-27 18:34:39 +01:00
a6c1b7bf9c
InventoryTransactionPacket: added missing field for encode
2020-06-26 20:57:48 +01:00
c267137fde
3.14.1 is next
2020-06-26 14:19:02 +01:00
461bc94236
Release 3.14.0
2020-06-26 14:19:02 +01:00
4fed08bcd4
ProtocolInfo: fixed version number
2020-06-26 14:15:58 +01:00
e990c5a0a5
Protocol changes for 1.16.0
2020-06-26 14:06:41 +01:00
c616d9bb7c
3.13.2 is next
2020-06-26 12:31:56 +01:00
81051441ba
Release 3.13.1
2020-06-26 12:31:56 +01:00
3ecae0db19
WindowTypes: fill in a couple of blanks
2020-06-26 12:04:11 +01:00
c5bbb2bcbc
Move crafting action detection from InventoryTransactionPacket to Player
2020-06-26 11:59:30 +01:00
24a2889758
NetworkInventoryAction does not require an InventoryTransactionPacket
2020-06-26 11:51:06 +01:00
60b26a7ea8
NetworkBinaryStream: unknown byte preceding NBT is a version, not a count
2020-06-26 11:47:08 +01:00
22b52f03d1
Player: fixed formatting error in InteractPacket debug message
2020-06-26 11:44:41 +01:00
df76c02e7a
Explicitly release server.lock file when shutdown the server. ( #3619 )
...
Previously, this relied on PHP itself to release locks during the resource destructor phase during process exit, but sometimes it doesn't for god knows what reason. This change makes the lock file get explicitly released before the process dies.
2020-06-26 11:41:39 +01:00
d343187e58
phpstan: drop 2 obsolete level 8 error patterns fixed by 763c8ebfe3
2020-06-23 12:57:25 +01:00
c5ad127854
BaseInventory: mark eventProcessor as nullable, fixes a phpstan level 8 error
2020-06-23 12:55:06 +01:00
0f6dc9082a
lock phpstan at 0.12.29
...
0.12.30 starts reporting non-ignorable errors for overriding Thread::start() due to outdated stubs for pthreads that I can't replace
2020-06-22 20:57:12 +01:00
2b6dcbc2e2
BaseLang: fixed passing onlyPrefix to str_replace()'s count reference parameter
2020-06-22 20:34:23 +01:00
763c8ebfe3
Thread/Worker: drop nullability flag from start() (fixed in pthreads 3.2.0, which we require as a minimum)
2020-06-21 19:07:01 +01:00
c572e9bb6a
phpstan: regenerate l7 baseline
2020-06-21 18:58:41 +01:00
89521f166d
Explosion: account for multi-block structures, fixes #2767
2020-06-21 17:28:38 +01:00
49d3a42120
phpstan: make EntityEvent generic, fix a bunch of 'actual-problems' ignored errors
2020-06-21 00:27:32 +01:00
c523595e85
Rewrite TeleportCommand (sadly I can't make this commit any smaller)
...
this pile of shit was overdue a rewrite. The new version is much easier to understand.
2020-06-21 00:04:18 +01:00
7c7e4f2093
WhitelistCommand: fixed silence on unknown subcommand
2020-06-20 23:05:39 +01:00
88c1014f03
TimingsCommand: fixed silence when using a nonexisting subcommand
2020-06-20 23:04:08 +01:00
e32180ce93
phpstan: drop an obsolete phpstan-bugs ignoreError
2020-06-19 10:41:41 +01:00
e105578be0
LegacySkinAdapter: an extra check for resourcePatch (fixes 3 phpstan explicitMixed errors)
2020-06-18 20:08:38 +01:00
a9d98bdf73
phpstan: baseline our way into checkExplicitMixed territory
2020-06-18 18:07:21 +01:00
c601352777
Fixed wrong meta value when pick cake block. ( #3593 )
2020-06-18 11:14:57 +01:00
77c71e22b2
SkinAdapter::fromSkinData() may now throw InvalidSkinException
...
fixes a rogue TODO in LegacySkinAdapter and invalid skins maybe showing up as Steve instead of getting kicked off the server
2020-06-17 21:44:22 +01:00
1c13ba5656
Avoid parameter ordering bugs during packet decoding
...
A PhpStorm refactor could have side effects on code that directly reads stuff from the packet input stream in the arguments block, because those calls will get moved into a different order if the constructor gets refactored. This would, obviously, break packet decoding, so that's something we should avoid and really should not encourage.
2020-06-17 21:01:01 +01:00
f970be0e4d
SkinImage: 128x64 is not a valid classic skin size
...
MC itself doesn't accept classic skins of this size.
2020-06-17 20:31:28 +01:00
11a3f9f1b9
VerifyLoginTask: fast-fail by checking header x5u before verifying signature
...
this is less costly, although it doesn't make any difference except in invalid cases.
2020-06-17 17:52:19 +01:00
09771849ae
VerifyLoginTask optimisation: do not copy the entire LoginPacket into the worker thread
...
this is especially bad considering the fact that the cached buffer is copied. That said, it's only a few kilobytes so it's not a huge problem, but nonetheless...
2020-06-17 17:46:22 +01:00
