2d461251ed
phpstan: ignore more errors reported by strict-rules
2020-02-07 22:14:51 +00:00
66a1134ca1
Player: avoid another empty() usage
2020-02-07 22:13:43 +00:00
ec9ece56f5
Player: fetch world via location
...
this code caters for the possibility of the world being null.
2020-02-07 22:11:14 +00:00
04a3e71047
ChunkSerializer: avoid using loop vars outside loop scope
2020-02-07 22:10:23 +00:00
ee36ac9875
ProcessLoginTask: use strict base64_decode()
2020-02-07 22:09:46 +00:00
bc60bb9462
remove useless type asserts on Entity->getWorld()
2020-02-07 22:08:38 +00:00
85f3dca11b
HandlerListManager: make resolveNearestHandleableParent() a little easier to follow
...
and also sidestep phpstan complaining about using loop vars outside of loop
2020-02-07 22:07:36 +00:00
fd675449e9
BlockFactory: fill blastResistance with float(0)
...
technically there wasn't anything wrong with this code, but it caused the type inference to report incompatibility, and I can't be bothered to report a PHPStan bug.
2020-02-07 22:06:34 +00:00
d2aca6023b
add native return types to closures (for phpstan)
2020-02-07 22:05:15 +00:00
aac7da6c96
eliminate remaining empty() usages
2020-02-07 21:51:50 +00:00
1ffabbb567
fixed ignoreError for registerEvent()
2020-02-07 20:25:08 +00:00
347b94b284
Merge branch 'stable'
2020-02-07 20:18:17 +00:00
758a68aa2c
ItemFactory: add Item[] as type for list field (for auto complete)
2020-02-07 20:11:31 +00:00
bfce478e72
BlockFactory: keep the generic types for PHPStan, which actually understands it
2020-02-07 20:10:40 +00:00
681dd469a2
PluginManager: add class-string phpstan param to registerEvent()
2020-02-07 20:05:41 +00:00
3edbea8545
PluginManager: fix spacing of phpdoc comment for registerEvent()
2020-02-07 19:37:22 +00:00
3a9e6bb612
CallbackInventoryChangeListener: fix use of tab instead of space
2020-02-07 19:28:43 +00:00
31405f7587
EnumTraitTest: use @doesNotPerformAssertions
2020-02-07 18:35:55 +00:00
31fcd8e5fa
ItemTest: use the proper method to explicitly fail a test
2020-02-07 18:35:26 +00:00
95896eb911
tests/phpunit: fill in some phpstan types
2020-02-07 18:34:57 +00:00
091873ca51
HandlerListManagerTest: fix phpunit 8.x compatibility
2020-02-07 18:14:43 +00:00
5e85705ec8
Merge branch 'master' of https://github.com/pmmp/pocketmine-mp
2020-02-07 18:14:10 +00:00
fb1126797a
Merge branch 'stable'
2020-02-07 18:13:55 +00:00
93671d8bfe
fixed broken tests from level->world rename
...
how did this not get noticed before ???
2020-02-07 17:22:49 +00:00
4140af459e
travis: cache leveldb artifacts to reduce build time
2020-02-07 14:05:11 +00:00
f713cf25b1
travis: update leveldb version, only build sharedlibs targets on travis
2020-02-07 13:54:22 +00:00
ada8cbb545
phpstan: drop some ignoreErrors that don't occur on 0.12.9
2020-02-06 21:01:05 +00:00
0ac5e03ce9
Require PHPStan 0.12.9 minimum
2020-02-06 20:59:43 +00:00
9b02b8e51e
Item: do not compare serialized NBT in equals()
...
this isn't cached anymore, and would be a performance drag.
It would be nice to have some kind of fast path for this, but comparing NBT binary isn't it.
2020-02-06 20:23:58 +00:00
6c7dada232
finally, integrate phpstan-strict-rules
2020-02-06 19:44:10 +00:00
25bc95cd1e
removing more unnecessary casts
2020-02-06 19:33:34 +00:00
213bf8366a
TranslationContainer: fix parameter type of setParameters()
2020-02-06 19:33:34 +00:00
4e693e91e6
ChestInventory: document that getHolder() may return Position
...
there is a variance issue with EnderChestInventory that was detected by phpstan-strict-rules which can't be addressed without a BC break. This fix will at least allow static analysers to be aware that code using this function might catch fire when it sees an EnderChestInventory without realizing it.
2020-02-06 19:33:34 +00:00
a1622fa345
UtilsTest: silence a phpstan-strict-rules warning
2020-02-06 18:53:05 +00:00
0ec869932f
Item: clean up internal NBT storage, discard useless legacy network cache
...
this will now bail if the NBT string given is invalid upon setCompoundTag(), rather than shitting the bed when it's accessed.
2020-02-06 17:59:05 +00:00
79acaa3253
Utils: remove useless typecasts
2020-02-06 16:06:58 +00:00
da3742b39e
Remove useless typecasts
2020-02-06 16:00:57 +00:00
d26fcf7dee
Removed useless casts() from min/max calls
2020-02-06 15:58:27 +00:00
812424a619
GroundCover: drop useless variable in calculating startY
2020-02-06 14:26:03 +00:00
1bdc61dd5f
Ore: do not destroy outer scope vars in for loops
2020-02-06 14:24:57 +00:00
86fc33fe26
Level: add phpstan generics to getNearestEntity()
2020-02-06 14:20:19 +00:00
70eb41470c
ContainerInventory: remove redundant check
2020-02-06 14:19:33 +00:00
3a5709bf5e
start using phpstan-phpunit
...
not using extension-installer because I want to part-integrate phpstan-strict-rules later on.
2020-02-06 13:23:18 +00:00
5ad66c3c9b
BlockTest: throw exception instead of always-false assert
2020-02-06 13:21:39 +00:00
7885b54824
phpstan: run static analysis on tests
2020-02-06 13:13:12 +00:00
532dc0fb6f
tests/phpunit: populate iterable types for phpstan
2020-02-06 13:11:56 +00:00
54ccc330d5
Bump irstea/phpunit-shim from 7.5.20 to 8.5.2 ( #3296 )
2020-02-06 12:50:51 +00:00
e12618c705
tests/phpunit: added missing native typehints
2020-02-06 12:13:42 +00:00
7d5f2eac8d
Merge branch 'stable' of https://github.com/pmmp/pocketmine-mp into stable
2020-02-06 08:38:12 +00:00
e964dd2ca8
travis: cache composer vcs directory too
2020-02-06 08:37:38 +00:00
