Dylan K. Taylor
8794292788
remove &$var reference notations in phpdoc
...
this isn't required by the spec and PHPStan chokes on it. I was previously having it ignore these errors, but it turns out that PHPStan is not making use of extended typeinfo provided if it can't parse the tag, which is problematic on level 6 and also a problem for array-of-type. Therefore, we are going to have to take the hit.
2020-01-11 21:20:55 +00:00
Dylan K. Taylor
039478223e
phpstan: enable MissingFunctionReturnTypehintRule
2020-01-09 20:14:15 +00:00
Dylan K. Taylor
c85f4256c7
phpstan: enable MissingFunctionParameterTypehintRule
2020-01-09 20:10:15 +00:00
Dylan K. Taylor
6dcd2a4ece
phpstan: start phasing in some level 6 checks
2020-01-09 19:56:04 +00:00
Dylan K. Taylor
6490a49c70
tests: drop lint.sh - no longer needed now that we have PHPStan
2020-01-04 15:23:53 +00:00
Dylan K. Taylor
5cd7e11b29
Use specialized build script for Travis
2020-01-04 15:15:01 +00:00
Dylan K. Taylor
3e23a568ca
phpstan: properly fixing FPs on constant comparisons
2019-12-29 14:25:44 +00:00
Dylan K. Taylor
2de0ec02ba
phpstan 0.12.3
2019-12-28 17:22:08 +00:00
Dylan K. Taylor
494660102e
Replace empty() usages with count()
2019-12-18 11:23:24 +00:00
Dylan K. Taylor
70c3008b7b
phpstan: green on level 4
2019-12-12 13:00:57 +00:00
Dylan K. Taylor
6127a02a8b
phpstan 0.12.2
2019-12-12 10:43:45 +00:00
Dylan K. Taylor
7b1ae2a822
phpstan: green on level 3
2019-12-04 22:12:14 +00:00
Dylan K. Taylor
c57eb26fd5
phpstan-bugs: add some extra patterns for level 3 false positives
2019-12-04 19:50:15 +00:00
Dylan K. Taylor
c35d91a104
phpstan: allow blanket ignoreErrors in src to reduce merge work for master
2019-12-04 19:42:18 +00:00
Dylan K. Taylor
73d0f799c2
Update to PHPStan 0.12.0
2019-12-04 10:29:49 +00:00
Dylan K. Taylor
15f8886958
phpstan: separate non-PM bugs from the main neon config
...
everything left in here is now a PM problem that needs to be looked into.
2019-12-01 20:12:41 +00:00
Dylan K. Taylor
932418b951
fixing some PHPStan complaints about bootstrap
...
this isn't an ideal fix, but it'll do.
2019-11-07 18:22:37 +00:00
Dylan K. Taylor
714f4dc023
fortify CI with PHPStan
2019-11-05 19:42:37 +00:00
Dylan K. Taylor
a86bcd5110
travis.sh: don't redownload phpunit if it already locally exists
2019-11-05 19:39:04 +00:00
Dylan K. Taylor
35fabc7765
updated DevTools submodule to 1.13.5
2019-10-28 16:03:26 +00:00
Dylan K. Taylor
abbb8bbf55
travis.sh: allow latest phpunit v7 now that we have XML
...
not ready to move to v8 yet because of BC breaks
2019-10-24 13:37:24 +01:00
Dylan K. Taylor
acaa0e33b0
update DevTools submodule to pmmp/PocketMine-DevTools@3fadb2c3f4
2019-10-22 10:16:44 +01:00
Dylan K. Taylor
8a6381c3fa
StupidJsonDecodeTest: add some extra test vectors
2019-10-01 13:25:20 +01:00
Dylan K. Taylor
d0d61597c7
StupidJsonDecodeTest: use getClosure() instead of traditional mess
...
this is faster and requires less code.
2019-09-26 11:28:40 +01:00
Dylan T
d724374d1a
StupidJsonDecodeTest: add failing test case for #3113
2019-09-16 15:53:00 +01:00
Dylan K. Taylor
5d531b56db
travis.sh: lock down PHPUnit at 7.5.11
...
7.5.12 makes changes which assume libxml is present, which isn't the case with our PHP builds.
2019-06-14 16:58:56 +01:00
Dylan K. Taylor
4c5f6eb1b7
Moved preprocessor submodule to build/ directory
2019-06-11 17:56:13 +01:00
Dylan T
b60731607d
Update travis.sh
2019-06-06 17:20:16 +01:00
Dylan K. Taylor
b08affc4c6
Updated preprocessor submodule
2019-05-02 17:11:40 +01:00
Dylan K. Taylor
810bdeb965
Test one extra case for LevelProviderManager
2019-04-26 12:01:12 +01:00
Dylan K. Taylor
6f5d4d6b80
RegionLoader: fixed handling of invalid chunk coordinates
2019-03-05 10:52:36 +00:00
Dylan K. Taylor
df1ef7fe0c
Improve RegionLoader tests
2019-03-05 10:51:44 +00:00
Dylan K. Taylor
a30b1fb6d5
Inventory: Add failing test case for itemstack NBT duplication
2019-03-03 11:11:33 +00:00
Dylan K. Taylor
2822465f33
Updated submodules
2019-02-07 16:20:45 +00:00
Dylan K. Taylor
c83b7d9b69
Utils: fixed getNiceClosureName() not processing namespaced closures properly
2019-01-26 12:08:07 +00:00
Dylan K. Taylor
cd98e6a23e
Updated PreProcessor submodule
2019-01-19 13:57:17 +00:00
Dylan K. Taylor
beb5d72299
RegionLoader: fix off-by-one bug with large chunks, closes #2615
2018-12-29 00:02:54 +00:00
Dylan K. Taylor
23dc6e09d8
Sync DevTools submodule
2018-12-09 15:34:06 +00:00
Dylan K. Taylor
545ec9c881
Updated PreProcessor submodule
2018-11-26 14:02:23 +00:00
Dylan K. Taylor
2da2fdd6d4
Added a test for Item->equals() when both items have no NBT
2018-10-29 12:42:03 +00:00
Dylan K. Taylor
2858db430e
Fixed AsyncTask publishProgress() race condition on task exit
...
It's possible for a progress update to be lost due to the task finishing before the main thread found the progress update.
2018-10-10 13:41:15 +01:00
Dylan K. Taylor
cf20e626e2
Merge branch 'release/3.1' into release/3.2
2018-10-05 17:43:54 +01:00
Dylan K. Taylor
d75c830a7e
Add -f parameter to lint.sh to allow it to not be useless in cygwin
...
find can conflict with windows' built in find command, which causes it to bug out when running tests.
2018-10-05 17:43:45 +01:00
Dylan K. Taylor
21e7b5ea43
TesterPlugin: removed usage of deprecated ServerCommandEvent
2018-08-19 14:05:26 +01:00
Dylan K. Taylor
8304675af7
Merge branch 'release/3.1' into release/3.2
2018-08-19 13:59:58 +01:00
Dylan K. Taylor
0cdf4d0c55
Spoon the TesterPlugin into the main repository
...
I am eating my own words this once, because having the tester plugin as a separate repository makes no sense - it is just added barriers to writing proper tests with no actual benefit. Since the tester plugin is specifically intended for CI, it doesn't make sense for it to be in its own module.
2018-08-19 13:58:13 +01:00
Dylan K. Taylor
e6e28b74b5
Nuke the TesterPlugin submodule
2018-08-19 13:47:43 +01:00
Dylan K. Taylor
9d17c9a09d
Merge branch 'release/3.1' into release/3.2
2018-08-19 11:22:58 +01:00
Dylan K. Taylor
3892f2f404
Config: Properly prevent keys getting transformed into bools
...
The original regex almost completely failed at its objective, because it a) only worked if there was no value for the key, and b) did not prevent all such occurrences getting transformed, while quoting patterns that would not get transformed anyway.
2018-08-19 11:22:36 +01:00
Dylan K. Taylor
bfa415e108
Add unit tests for json decoding hack
2018-08-19 10:30:52 +01:00