mirrors/PocketMine-MP
1
0
Fork 0
mirror of https://github.com/pmmp/PocketMine-MP.git synced 2025-05-11 00:09:39 +00:00
Code Issues Projects Releases Wiki Activity
9,069 Commits 16 Branches 439 Tags
Commit Graph

9069 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Dylan K. Taylor
c329ff7d4f SubChunk: remove nonsensical reference from internal function 2020-01-11 21:49:33 +00:00
Dylan K. Taylor
8794292788 remove &$var reference notations in phpdoc 
this isn't required by the spec and PHPStan chokes on it. I was previously having it ignore these errors, but it turns out that PHPStan is not making use of extended typeinfo provided if it can't parse the tag, which is problematic on level 6 and also a problem for array-of-type. Therefore, we are going to have to take the hit.
 2020-01-11 21:20:55 +00:00
Dylan K. Taylor
0a39e580e9 MainLogger: log exception chains in logException(), closes #2447 
this method is simpler than #2447 and easier to apply to stable.
 2020-01-09 21:01:12 +00:00
Dylan K. Taylor
c4580dd56d MainLogger: extract a printErrorMessage() function from logException() 2020-01-09 20:51:13 +00:00
Dylan K. Taylor
fab81d28bc MainLogger: always log exceptions with CRITICAL level 
if we reached this point, it's almost always due to a general exception handler which doesn't know what else to do with the error.
 2020-01-09 20:44:21 +00:00
Dylan K. Taylor
039478223e phpstan: enable MissingFunctionReturnTypehintRule 2020-01-09 20:14:15 +00:00
Dylan K. Taylor
64b5db4bf2 bootstrap: add some @return annotations for phpstan 2020-01-09 20:13:53 +00:00
Dylan K. Taylor
c85f4256c7 phpstan: enable MissingFunctionParameterTypehintRule 2020-01-09 20:10:15 +00:00
Dylan K. Taylor
1192b8bdf1 bootstrap: add PhpDoc to critical_error to make phpstan happy 
it wants phpdoc or typehints, and we can't provide typehints because bootstrap needs to be compatible with old PHP versions.
 2020-01-09 20:09:33 +00:00
Dylan K. Taylor
6dcd2a4ece phpstan: start phasing in some level 6 checks 2020-01-09 19:56:04 +00:00
Dylan K. Taylor
3fff0a0656 BigTree: evict unmaintained dead code 
phpstan whines about all this stuff, and everything left is private, so we can get rid of it. Sadly we can't ditch the class without breaking BC, so that sticks with 4.0.
 2020-01-09 14:26:46 +00:00
Dylan K. Taylor
e1e1bfa5e3 CompressBatchedTask: remove useless code causing build failure 
assuming that pthreads does not have leak issues, this code is pointless, and if pthreads does have leak issues, this may not prevent them anyway.
 2020-01-09 14:19:35 +00:00
Dylan K. Taylor
1eedac87b2 added missing @var property types (reported by phpstan) 2020-01-09 14:13:54 +00:00
Dylan K. Taylor
cda3e6f4dc PluginDescription: clean up type information for extensions field 2020-01-09 11:20:01 +00:00
Dylan K. Taylor
e6a58e2690 format/leveldb: fix crash on truncated level.dat file 2020-01-08 09:55:03 +00:00
Dylan K. Taylor
27350c4673 3.11.4 is next 2020-01-04 16:46:55 +00:00
Dylan K. Taylor
0d5704b156 Release 3.11.3 3.11.3 2020-01-04 16:46:55 +00:00
Dylan K. Taylor
f355044626 resources: do not remove client-side resource packs when forcing resources 
I wanted to make this into a dedicated option, but it had some side effects (see 4794ba236a551bd839bbb8565474c19f93d97c30).
I'll settle for just disabling this useless behaviour, since we have other ways to force vanilla resources anyway; setting this flag to always-false has no user-facing effects anyway.
 2020-01-04 16:14:08 +00:00
Dylan K. Taylor
4794ba236a Revert "resource packs: added new option remove_client_resources, fixed client packs being removed when forcing resource pack download" 
This reverts commit 06ec8b83978fcc52a7964d678a97c73b50a97aa8.

unfortunately, this had some unanticipated side effects, thanks to
idiotic behaviour in the client ... when having optional downloads but
trying to force resources, the client chokes because it thinks the
server is forcing it to apply a pack that it doesn't have. Since
there's no way to detect when this problem occurs in the protocol, the
only option is to revert this.
 2020-01-04 16:04:07 +00:00
Dylan K. Taylor
6490a49c70 tests: drop lint.sh - no longer needed now that we have PHPStan 2020-01-04 15:23:53 +00:00
Dylan K. Taylor
5cd7e11b29 Use specialized build script for Travis 2020-01-04 15:15:01 +00:00
Dylan K. Taylor
08e3b8ffdc build: added specialized script to create a server phar 
this is much easier to use than devtools, and allows us to make additional specializations for PM build that would otherwise just be a colossal pain in the ass.
 2020-01-04 14:56:53 +00:00
Dylan K. Taylor
9232f4509c TimingsHandler: don't bail on redundant attempts to stop non-running timers 
while it would be nice to bail, providing the environment to allow bailing without breaking stuff requires some complex changes that would reduce performance when timings is not running. Considering the limited usefulness of bailing here anyway, and the fact that it just has to be prevented to not have side effects, it doesn't make a whole lot of sense right now.

closes #3261, closes #3269, closes #3254
 2020-01-04 14:44:55 +00:00
Dylan K. Taylor
cef77907c6 Timings: fixed grandparent timers not working correctly, closes #3229 2020-01-04 13:23:04 +00:00
Dylan K. Taylor
06ec8b8397 resource packs: added new option remove_client_resources, fixed client packs being removed when forcing resource pack download 2020-01-04 13:16:47 +00:00
Dylan K. Taylor
ee08286eca moved git hash detection code to its own unit 2020-01-02 21:01:31 +00:00
Dylan K. Taylor
a83211f96a VersionInfo: add strict_types to stop CS tools screwing with it 2020-01-02 20:05:50 +00:00
Dylan K. Taylor
0b3c4ee496 bootstrap: don't choke on paths that have spaces in them 2019-12-30 11:58:44 +00:00
Dylan K. Taylor
54de518634 bootstrap: fixed incorrect git hash detection when cwd is not the repo root 2019-12-30 09:09:47 +00:00
Dylan K. Taylor
a908197907 Effect: document that duration is expected in ticks 2019-12-29 19:03:32 +00:00
Dylan K. Taylor
3e23a568ca phpstan: properly fixing FPs on constant comparisons 2019-12-29 14:25:44 +00:00
Dylan K. Taylor
dadc5c1b87 3.11.3 is next 2019-12-29 13:11:30 +00:00
Dylan K. Taylor
a37d740111 Release 3.11.2 3.11.2 2019-12-29 13:11:30 +00:00
Dylan K. Taylor
2de0ec02ba phpstan 0.12.3 2019-12-28 17:22:08 +00:00
Dylan K. Taylor
d83820477f TimingsHandler: throw on attempt to stop timer that is not running 
I do not think that this bug is in effect in the core code, but I can't be sure.
 2019-12-21 13:17:40 +00:00
Dylan T
8726604899
Merge #3251: Remove usages of empty() 2019-12-19 11:08:08 +00:00
Dylan K. Taylor
9cbe378e8c Timezone: fix possible crash on CentOS 2019-12-18 11:23:24 +00:00
Dylan K. Taylor
494660102e Replace empty() usages with count() 2019-12-18 11:23:24 +00:00
Luke
216138a37e
PlayerAuthInputPacket: Fix assigning variable in static context 2019-12-17 22:04:24 +08:00
Dylan K. Taylor
b08c38f8f9 build/make-release: remove redundant require_once 
this is included by vendor/autoload.php since 3.7.x.
 2019-12-17 11:47:07 +00:00
Dylan K. Taylor
911b6feaf9 NetworkInventoryAction: remove dead code 
the trading & beacon types need to be checked as well, but I don't have the tools to check that right now.
 2019-12-17 11:17:40 +00:00
Dylan K. Taylor
2cb6990698 Enchantment: don't throw exceptions on out of range IDs 
this function is used for data deserialization, and data may have bad enchantment IDs in it.
 2019-12-14 10:04:51 +00:00
Dylan K. Taylor
f7d66613df CompletedUsingItemPacket: added missing #include, closes #3219 2019-12-13 19:50:40 +00:00
Dylan K. Taylor
95c32d26df Explosion: fixed ray trace getting stuck on a block when it encounters an empty subchunk 
this might have caused unexpected behaviour in large caves.
 2019-12-13 18:07:59 +00:00
Dylan K. Taylor
9e1f6a2486 protocol: updated particle IDs 2019-12-13 10:52:09 +00:00
Dylan K. Taylor
76994f15ac phpstan: green on level 5 2019-12-12 18:27:26 +00:00
Dylan K. Taylor
cf73d74bd0 format/anvil: fixed possible type violation on saving chunk 2019-12-12 18:24:21 +00:00
Dylan K. Taylor
37a8d95464 world IO: fixed crashes when garbage data found in tile/entity NBT data 2019-12-12 18:21:23 +00:00
Dylan K. Taylor
9a4b72add5 PlayerInventory: fix type violation when calling equipItem() for non-Player holder 2019-12-12 16:31:22 +00:00
Dylan K. Taylor
919534d978 EnderChest: fixed crash when plugins overwrite tile classes with incompatible ones 
relates to 47a959dace95eafe79212a444e3f865475c6ee8e
 2019-12-12 16:28:30 +00:00