Commit Graph

11705 Commits

Author SHA1 Message Date
Dylan K. Taylor
c22f793521 RakLibInterface: Log a message when a non-0xfe packet is received 2021-06-15 19:20:31 +01:00
Dylan K. Taylor
2ee86f0edf Improved UPnP exception handling 2021-06-13 23:02:42 +01:00
Dylan K. Taylor
ec7ea98ead UPnP: expose more functionality 2021-06-13 22:48:38 +01:00
Dylan K. Taylor
80bf948588 Separate UPnPNetworkInterface from UPnP implementation 2021-06-13 22:41:36 +01:00
Dylan K. Taylor
3d0b21f30c Denoise NetworkSession with typed properties 2021-06-13 22:27:23 +01:00
Dylan K. Taylor
e5dd5a5745 NetworkSession: Fixed missing nullable declarations
phpstan doesn't report these because .. reasons .. @ondrejmirtes this is causing bugs to go unfound :(
I'm aware of the irony that I just silenced the bugs that were exposed by this commit .. that's an architectural problem for another day
2021-06-13 22:24:12 +01:00
Dylan K. Taylor
04a6e89d6f Change encryption to use CTR instead of GCM
despite MCPE claiming to use GCM, it omits the auth tag, which defeats the whole point of using GCM.
CTR can be used instead, with the final 4 bytes of the IV being 0002.
2021-06-13 21:57:23 +01:00
Dylan K. Taylor
0df2677464 EncryptionContext: Allow passing encryption algo as a constructor parameter 2021-06-13 19:57:48 +01:00
Dylan K. Taylor
cc00b3e19b Merge remote-tracking branch 'origin/stable' 2021-06-13 15:27:29 +01:00
Jason
6fb364b16f Store ender chest viewer count on the tile, instead of relying on the inventory's viewer count (#4238)
Fixes #4021
2021-06-13 14:37:09 +01:00
Stephen B
8e2829bdd4 Remove movement workaround from 1.14.30 (#4246) 2021-06-13 14:32:40 +01:00
Dylan K. Taylor
408e29da90 Removed PermissionRemovedExecutor
this interface is just about the most pointless code in all of PM or Bukkit. In over 4 million lines of code on Poggit, a Google search and a GitHub search, I didn't find a single usage of it that wasn't just bukkit internals code copy pasta, a spoon, a port of PM/Bukkit/whatever into a different language, or someone's generated javadoc.
2021-06-12 21:55:59 +01:00
Dylan K. Taylor
b525f45bf8 Fixed CS 2021-06-12 21:51:08 +01:00
Dylan K. Taylor
8e1d27a719 Constrain types to PermissibleInternal on internal permission subscription methods 2021-06-12 21:28:19 +01:00
Dylan K. Taylor
bfcf4a25d4 Automatic cleanup of permission subscriptions on PermissibleBase destructor calls
this has gotten too complex ...
2021-06-12 21:12:39 +01:00
Dylan K. Taylor
0ebafbd224 .... adding the most important part would probably help 2021-06-12 20:46:53 +01:00
Dylan K. Taylor
7dcc4891ca Block: added getDropsForIncompatibleTool() 2021-06-11 19:09:14 +01:00
Dylan K. Taylor
e4ed7bc4ea Fixed Mushroom Stem blocks never dropping anything 2021-06-11 19:04:12 +01:00
Dylan K. Taylor
22b5e5db5e AsyncPool: Do not drop pending tasks on shutdown
this creates an extra element of uncertainty for async pool usage.
2021-06-11 18:30:32 +01:00
Dylan K. Taylor
f245147c11 AsyncPool: make collectTasks() return value more accurate
during onCompletion() anything may happen, including scheduling new tasks, which the previous code did not account for.
2021-06-11 18:30:32 +01:00
Jason
532d57eec7 Arrow: Save and load critical state (#4241)
Fixes #3596
2021-06-09 14:00:36 +01:00
Dylan K. Taylor
5503fadf13 3.20.1 is next 2021-06-08 20:21:55 +01:00
Dylan K. Taylor
99964709c9 Release 3.20.0 2021-06-08 20:21:55 +01:00
Dylan K. Taylor
2bbb24fab7 Merge branch 'stable' 2021-06-08 20:00:08 +01:00
Dylan K. Taylor
57d274901d Protocol changes for 1.17.0 2021-06-08 19:40:28 +01:00
Dylan K. Taylor
908b627846 3.19.4 is next 2021-06-08 18:52:01 +01:00
Dylan K. Taylor
afb21c1df2 Release 3.19.3 2021-06-08 18:51:48 +01:00
Dylan K. Taylor
2d686e6dc0 Merge remote-tracking branch 'origin/stable' 2021-06-04 18:03:32 +01:00
Dylan K. Taylor
b257348a3a Renamed fields of AddEntityPacket and RemoveEntityPacket 2021-06-04 17:18:24 +01:00
Dylan K. Taylor
12c66d3362 CraftingDataPacket: fixed assert failure on debug builds 2021-06-04 17:13:50 +01:00
Dylan K. Taylor
9702b51bd1 Utils: improve how boolean arguments are displayed in stack traces 2021-06-02 21:36:47 +01:00
Dylan K. Taylor
fadc96bb0e Utils: include spl_object_id() in stack traces 2021-06-02 21:34:19 +01:00
Dylan K. Taylor
7d99b0115c Added a getName() override for RakLibServer 2021-05-29 23:51:46 +01:00
Dylan K. Taylor
0402e7e697 Separate CommandReader impl from CommandReaderThread 2021-05-29 23:41:11 +01:00
Dylan K. Taylor
4bcc7e09cb PacketSerializer: fix unnecessary FQN 2021-05-29 14:24:48 +01:00
Dylan K. Taylor
8171b18002 Separate ItemTypeDictionary implementation from initialization
we're not going to want implementation details like how it's setup getting in the way when we separate protocol from the core.
2021-05-29 14:24:05 +01:00
Carson
92fd2d35a4 SetDisplayObjectivePacket: added order and display slot constants (#4232) 2021-05-24 20:33:24 +01:00
Dylan K. Taylor
f68b9e79e1 Use typed properties in block namespace 2021-05-22 23:52:31 +01:00
Dylan K. Taylor
73c229a236 Block: fixed LSP violations in blocks using BlockIdentifierFlattened
a property's type can't be changed by a subclass
2021-05-22 23:40:54 +01:00
Dylan K. Taylor
285ad25168 BlockFactory: use the vars we already have, instead of repeated method calls 2021-05-22 12:45:08 +01:00
Dylan K. Taylor
f655d262be Added stripped all-sided-log variants
again, these should be dynamic; but right now it's not possible.
2021-05-22 12:43:07 +01:00
Dylan K. Taylor
ac04911e88 BlockFactory: fix potential crash 2021-05-21 21:44:17 +01:00
Dylan K. Taylor
24405b63c1 Coarse is now a state of Dirt, instead of a separate block 2021-05-21 21:36:49 +01:00
Dylan K. Taylor
df260034cd BlockFactory: Fill default state for all variants covered by bitmask when mismatch occurs 2021-05-21 21:12:34 +01:00
Dylan K. Taylor
e7b21cf9dc World: remove obsolete TODO comment
[ci skip]
2021-05-21 13:10:48 +01:00
Dylan K. Taylor
2ab751f985 World: fixed potential bug scheduling async light updates multiple times 2021-05-21 13:09:38 +01:00
Dylan K. Taylor
f6f0938b3b Merge branch 'stable' 2021-05-21 01:27:35 +01:00
Dylan K. Taylor
61077c48f1 Worker: fixed quit() usually being useless
Worker::isRunning() returns false after it exits the run() function, even if tasks are stacked and it isn't shutdown.
While this is mostly harmless (since the internal destructor will join the thread anyway), this should be fixed anyway.
2021-05-21 01:24:07 +01:00
Dylan K. Taylor
7968a72f0e Eliminate some duplicated breakinfos 2021-05-20 23:18:33 +01:00
Dylan K. Taylor
376d2c4cd4 Consistently declare BlockBreakInfo at the constructor call site
instead of inside the class
2021-05-20 22:49:51 +01:00