Dylan K. Taylor
ae75d73f48
Extract MainLoggerThread unit from MainLogger
...
MainLogger is no longer a Thread, as per the recent changes to pocketmine/log-pthreads.
2021-02-04 16:28:49 +00:00
Dylan K. Taylor
4b9639f6c9
Merge branch 'stable'
2021-02-04 15:55:39 +00:00
Dylan K. Taylor
8ef1e54e20
MainLogger: fixing CPU waste on logger thread
...
this doesn't need to keep spinning every 25ms; it can just wake up when there's actually log messages to write into the buffer.
2021-02-04 15:07:40 +00:00
Dylan K. Taylor
eaf3a86981
MainLogger: fixed UB in writeLogStream()
...
notify() has to be used inside a synchronized block.
2021-02-04 15:03:14 +00:00
Dylan K. Taylor
317a48d9b0
ItemStackRequest: expose filterStrings
2021-02-03 23:40:34 +00:00
Dylan K. Taylor
bc14660e55
Added missing ItemStackRequest protocol changes
2021-02-03 23:37:41 +00:00
Dylan K. Taylor
4158f77110
Merge remote-tracking branch 'origin/stable'
2021-02-03 17:52:28 +00:00
Dylan K. Taylor
b1bb9fbd1c
Reinstall PHP deps on cache hit
...
the 20.04 actions image doesn't have libzip5 and who knows what else is missing ...
2021-02-03 17:42:11 +00:00
Dylan K. Taylor
561fc62232
Merge remote-tracking branch 'origin/stable'
...
# Conflicts:
# .github/workflows/main.yml
# resources/vanilla
# src/pocketmine/VersionInfo.php
# src/world/format/io/region/RegionLoader.php
2021-02-03 17:32:47 +00:00
Dylan T
96181f8cf5
Version PHP build caches by image version
...
we can't safely use `ubuntu-latest` because the build caches will break if they were built for 18.04 and used on 20.04, or vice versa. Instead, we pin the images (and caches) to a specific version.
2021-02-03 17:24:50 +00:00
Dylan K. Taylor
079e794339
Armor: fixed item disappearing when switching two of the same armour pieces
...
Player->useHeldItem() assumes that if the old item == the new item, we want to set the item back into the inventory if it's modified in-place. Therefore, we don't modify the item in-place to bypass the problem.
closes #4022
2021-02-03 17:05:16 +00:00
Dylan K. Taylor
4771e3dc28
3.17.5 is next
2021-02-02 14:04:51 +00:00
Dylan K. Taylor
2e9117d102
Release 3.17.4
2021-02-02 14:04:50 +00:00
Dylan K. Taylor
06493da7d9
Imports cleanup
2021-02-02 13:58:07 +00:00
Dylan K. Taylor
d4290837f3
fix build failure
2021-02-02 13:55:56 +00:00
Dylan K. Taylor
3e1ac66abf
Merge branch 'stable'
2021-02-02 13:46:29 +00:00
Dylan K. Taylor
bd303b1062
RegionLoader: fixed flaky region header validation since 3.17.3
2021-02-02 13:43:52 +00:00
Dylan K. Taylor
fe731b9018
Added failing test case for region header validation
...
fucking PHP... what genius thought it was a good idea to cache file stats without even an attempt at keeping the cache up to date on modifications?
2021-02-02 13:43:12 +00:00
Dylan K. Taylor
1a24afc6d1
InventoryTransaction: Fixed indexes persisting from balance calculation in crafting input/outputs
...
fixes #4019
the order of the actual items may not be the same across runs, but index 0 will at least be sure to exist.
2021-02-02 00:13:58 +00:00
Dylan K. Taylor
bef906b0f0
phpstan 0.12.71
2021-02-02 00:05:53 +00:00
yuko fuyutsuki
37e8dd6444
Fix PHP 8 optional before required parameters deprecation warnings ( #4016 )
2021-01-31 12:08:47 +00:00
Dylan T
02ee0f23c0
Removed old support requests configuration
2021-01-27 22:53:37 +00:00
Dylan T
cda472333c
Add workflow for dessant/support-requests
...
we're using the legacy github app right now.
2021-01-27 22:47:33 +00:00
Dylan K. Taylor
02a4f0a170
Mark metadata as nullable in resource pack manifest data
...
if the metadata isn't provided, it won't be initialized during decoding.
2021-01-27 22:05:43 +00:00
Dylan K. Taylor
5a1131d72d
Populator: require dependencies explicitly, don't make bad assumptions about fields
...
this also leaks ChunkManagers on the worker threads because the generator context is long-lived.
2021-01-27 21:08:46 +00:00
Dylan K. Taylor
47cf58be8a
phpstan 0.12.70
2021-01-27 20:11:37 +00:00
Dylan K. Taylor
bbae02264d
Merge branch 'stable'
2021-01-27 20:04:13 +00:00
dependabot-preview[bot]
ccf9691927
Bump phpunit/phpunit from 9.5.0 to 9.5.1 ( #4010 )
2021-01-27 19:28:36 +00:00
Dylan K. Taylor
16fa958416
phpstan: better hack for any-callable parameters
...
variadics are a bad fit for this because what we really need is to accept callable with any number of arguments. LSP requires that the provided number of arguments must be >= than the required number of arguments.
2021-01-27 19:25:28 +00:00
Dylan K. Taylor
bac57c159f
Player: fix bridging, towering and various other fast building bugs
...
clickPos is relative to the base block position, so if you keep aiming at the same spot on the block and jump, it thinks you're still spamming.
closes #2730
2021-01-27 00:11:14 +00:00
Dylan K. Taylor
38b2d83799
MemoryManager: fixed protected properties being dumped multiple times
...
we don't need to scan the parent classes for anything other than private properties, because protected and public properties will appear on the main reflection as if they were declared directly as such.
2021-01-26 20:32:23 +00:00
Dylan K. Taylor
5384e2ba9d
Revert "MemoryDump: fixed duplicated properties, reduce useless noise"
...
This reverts commit efd67a132ed432b47a74c8b98211597557c419d5.
2021-01-26 20:26:35 +00:00
Dylan T
c134b1cd8a
[ci skip] README: add some badges
2021-01-26 17:34:05 +00:00
Dylan K. Taylor
269a389a97
BlockTransaction: added phpstan return type info for getBlocks()
2021-01-25 18:04:42 +00:00
Dylan K. Taylor
62deafda48
CommandReader: removed readline support
...
readline has been borked for a long time and it's not thread safe.
2021-01-25 17:53:25 +00:00
Dylan K. Taylor
31b6df4376
3.17.4 is next
2021-01-25 17:15:43 +00:00
Dylan K. Taylor
b296ae1b87
Release 3.17.3
2021-01-25 17:15:31 +00:00
Dylan K. Taylor
f9e42b716a
Scrub PHPStan baselines
...
these are now always generated with level 8.
2021-01-24 20:31:22 +00:00
Dylan K. Taylor
34c1d455a7
phpstan: enable checkMissingCallableSignature
2021-01-24 20:27:53 +00:00
Dylan K. Taylor
af8936dba5
phpstan 0.12.69
2021-01-24 20:14:42 +00:00
Dylan K. Taylor
74902d9926
[ci skip] changelog: mention InventoryPickupItemEvent->getItemEntity() rename
2021-01-21 13:58:08 +00:00
Dylan K. Taylor
2064b411f2
fix build
2021-01-20 22:53:51 +00:00
Dylan K. Taylor
69a829db91
Merge remote-tracking branch 'origin/stable'
2021-01-20 22:16:44 +00:00
SalmonDE
3fb4b30742
InventoryPickupItemEvent: rename item to itemEntity ( #4007 )
2021-01-20 21:09:59 +00:00
Dylan K. Taylor
e8ffab1787
RegionLoader: avoid hitting the disk twice during chunk reads
...
this provides some performance improvement (although it's difficult to measure because of cache).
this does mean that we read some garbage data during chunk reads, but it's less costly than hitting the disk twice.
2021-01-20 21:05:44 +00:00
Dylan K. Taylor
ecc1e1f698
RegionLoader: improve performance of region header validation
...
I was unaware that fseek actually makes a syscall which is rather costly, which became painfully obvious during large world conversions on PM4.
On average this problem appeared to be adding about 5ms to the load time for a newly loaded region, which is insanely expensive.
2021-01-20 20:04:21 +00:00
Dylan K. Taylor
487b5dd11d
Merge branch 'stable'
2021-01-16 19:44:15 +00:00
Dylan K. Taylor
ea5931e274
Updated build/php submodule to pmmp/php-build-scripts@60194e8b14
2021-01-16 19:34:06 +00:00
Dylan K. Taylor
988cf7f535
Fixed PHP 8.0 deprecation error
2021-01-16 19:31:07 +00:00
Dylan T
e156fb47e8
Disable xdebug on Actions
2021-01-15 21:09:45 +00:00
