Dylan K. Taylor
5c8a625d88
populate missing iterable value types in block namespace
2020-01-30 20:43:13 +00:00
Dylan K. Taylor
f624871b3f
strip extra blank lines (php-cs-fixer)
2020-01-22 14:50:29 +00:00
Dylan K. Taylor
9f44adf04a
pass 2, manual removal of incorrect non-nullable @param for nullable native types
2020-01-21 15:44:34 +00:00
Dylan K. Taylor
c4793241f5
Mass removal of useless @param/@return PHPDoc annotations, pass 1
2020-01-21 15:10:18 +00:00
Dylan K. Taylor
cfd975009e
Leaves: fix decay performance issue
...
this code was written with references in mind, but it looks like someone forgot the reference.
2020-01-20 11:52:11 +00:00
Dylan K. Taylor
ccbcc14600
Block: populate missing return type info
2020-01-19 17:02:03 +00:00
Dylan K. Taylor
07cb603231
Liquid: add missing return type to getFluidHeightPercent()
2020-01-17 13:58:54 +00:00
Dylan K. Taylor
f59094e6d6
Fence: add missing return type to canConnect()
2020-01-17 13:58:29 +00:00
Dylan K. Taylor
d8acae5495
Door: add missing return type to getFullDamage()
2020-01-17 13:57:56 +00:00
Dylan K. Taylor
239fe909be
CobblestoneWall: add missing return type for canConnect()
2020-01-17 13:57:29 +00:00
Dylan K. Taylor
1eedac87b2
added missing @var property types (reported by phpstan)
2020-01-09 14:13:54 +00:00
Dylan K. Taylor
494660102e
Replace empty() usages with count()
2019-12-18 11:23:24 +00:00
Dylan K. Taylor
919534d978
EnderChest: fixed crash when plugins overwrite tile classes with incompatible ones
...
relates to 47a959dace95eafe79212a444e3f865475c6ee8e
2019-12-12 16:28:30 +00:00
Dylan K. Taylor
9be95bf263
Block: return [] instead of null in getMetadata() (return type is non-nullable)
2019-12-01 21:02:49 +00:00
Dylan K. Taylor
47a959dace
block: fix some possible crashes when plugins overwrite tile classes in bad ways
...
phpstan was complaining on level 2, and it's not wrong to ...
2019-12-01 09:29:22 +00:00
Dylan K. Taylor
c3872619cd
Block: mark boundingBox as nullable
2019-10-22 10:07:27 +01:00
Dylan K. Taylor
11fc16617a
Liquid: fix max cost calculation for flow direction search, closes #2995
2019-07-07 14:32:52 +01:00
Dylan K. Taylor
c38779f1fd
Block: fixed use of full meta as variant in several cases
...
fixes #2940
now I need to go to the bathroom and wash this off my hands ... I'd forgotten how nasty this code is
2019-05-27 18:04:25 +01:00
Dylan K. Taylor
f35b43613d
IronTrapdoor: fixed fuel time, closes #2914
...
this should be removed during branch merge.
2019-05-24 17:31:36 +01:00
Dylan K. Taylor
3d0fa10437
Stonecutter: fix hardness, close #2915
2019-05-24 17:30:20 +01:00
Dylan K. Taylor
3c90ed13b9
NoteBlock: added //TODO
2019-04-26 12:45:08 +01:00
Dylan K. Taylor
8e9f787d33
Implement runtimeID table randomization, closes #2841
2019-03-29 14:35:06 +00:00
Dylan K. Taylor
6c92a2e88b
Ladder: be more strict about resetting fall distance
...
closes #2790
2019-02-26 19:54:57 +00:00
Dylan K. Taylor
97deadc59f
PackedIce: fixed dropping without silk touch, closes #2789
2019-02-26 19:48:18 +00:00
Dylan K. Taylor
6b51bf4a80
Merge branch '3.5' into 3.6
2019-02-18 13:11:16 +00:00
Dylan K. Taylor
cba8d86c4f
Fixed Fire Aspect not working on TNT
2019-02-18 13:11:08 +00:00
Dylan K. Taylor
2e834c8f5c
Merge branch '3.5' into 3.6
2019-02-17 16:10:47 -05:00
Dylan K. Taylor
f9873e9108
ItemFrame: fixed hardness
2019-02-17 16:10:21 -05:00
Dylan K. Taylor
372545e47e
Merge branch '3.5' into 3.6
2019-02-12 16:56:53 +00:00
Dylan K. Taylor
8913b48700
"Implement" info-update and reserved6
2019-02-12 16:56:12 +00:00
Dylan K. Taylor
6ee4a0e090
Implement invisible bedrock to fix placement issues
...
I don't know why this wasn't done a long time ago, but here it is.
2019-02-12 16:41:23 +00:00
Dylan K. Taylor
9e89f65094
Fixed handling for some new blocks which slipped through the frontline
2019-02-08 16:38:17 +00:00
Dylan K. Taylor
b8703d5dff
Protocol changes for 1.9.0
2019-02-07 21:56:42 +00:00
Dylan K. Taylor
1d0ffa06f8
TallGrass: fixed placement on dirt, closes #2552
2019-02-07 16:55:25 +00:00
Dylan K. Taylor
ddbb5363ef
Block->getBreakTime() now throws InvalidArgumentException on items with bad efficiency values
2019-01-30 19:10:24 +00:00
Dylan K. Taylor
0f9fdf6442
Fixed Cactus and Sugarcane growing through bad blocks
...
closes #2714
2019-01-29 17:32:48 +00:00
Dylan K. Taylor
80d48161d3
Crops: fixed consuming bonemeal on fully-grown crop, closes #2704
2019-01-29 13:41:02 +00:00
Dylan K. Taylor
9826abd83e
Stair: fixed crash if player is null
2019-01-26 16:59:03 +00:00
Dylan K. Taylor
48c8c2a8c3
ItemFrame: address crashdump 2113950
...
thanks Mojang for designing this lovely system where so much undefined behaviour is able to take place :(
2019-01-26 16:58:25 +00:00
Dylan K. Taylor
4fd3bee360
Entity: Address fireticks crashdumps
...
This will now throw an exception at the source instead of crashing when the entity is saved, which should put the blame on the correct plugin responsible for this.
This also includes magic method hacks to preserve backwards compatibility, since the fireTicks field is now protected.
2019-01-19 16:05:10 +00:00
Dylan K. Taylor
254281cd5e
Ice: don't create water for creative players, fixes #2622
2019-01-05 09:26:35 +00:00
Dylan K. Taylor
4b9a142a5d
Import global functions and constants for enhanced performance
...
This is better for performance because these then don't need to be reevaluated every time they are called.
When encountering an unqualified function or constant reference, PHP will first try to locate a symbol in the current namespace by that name, and then fall back to the global namespace.
This short-circuits the check, which has substantial performance effects in some cases - in particular, ord(), chr() and strlen() show ~1500x faster calls when they are fully qualified.
However, this doesn't mean that PM is getting a massive amount faster. In real world terms, this translates to about 10-15% performance improvement.
But before anyone gets excited, you should know that the CodeOptimizer in the PreProcessor repo has been applying fully-qualified symbol optimizations to Jenkins builds for years, which is one of the reasons why Jenkins builds have better performance than home-built or source installations.
We're choosing to do this for the sake of future SafePHP integration and also to be able to get rid of the buggy CodeOptimizer, so that phar and source are more consistent.
2019-01-04 20:43:15 +00:00
Dylan K. Taylor
2921c86b3c
Torch: fixed crash on blockupdate with corrupted meta
2018-12-30 19:50:35 +00:00
Dylan K. Taylor
0ea166a551
Prevent placement of unknown blocks, closes #2260
...
I don't know why I ever allowed this in the first place... stupid idea...
2018-12-28 13:03:34 +00:00
Dylan K. Taylor
d34b94302f
fixed lava fizz sound
2018-12-12 18:00:43 +00:00
Dylan K. Taylor
30f5a8fac6
Protocol changes for 1.8.0 release
2018-12-11 21:05:03 +00:00
Dylan T
e3f46987f5
Liquid: Add events to allow controlling flow and fusion ( #2547 )
2018-12-04 13:14:22 +00:00
Dylan K. Taylor
f61e099828
Merge branch 'release/3.3' into release/3.4
2018-10-24 15:52:04 +01:00
Dylan K. Taylor
09985c5763
Fixed async light population producing garbage when generator isn't registered, closes #2488
2018-10-24 15:49:00 +01:00
Dylan K. Taylor
6dd2597934
Merge branch 'release/3.3' into release/3.4
2018-10-21 18:17:07 +01:00