Dylan K. Taylor
6869ee1c2d
Clean up nonsensical code in NetworkBinaryStream->getSlot()
2020-12-05 01:24:41 +00:00
Dylan K. Taylor
9e85ee4a7a
Fixed missing field on Persona skin encode
2020-11-21 18:01:56 +00:00
Dylan K. Taylor
d19db5d2e4
fix phpstan warnings
2020-11-21 01:16:04 +00:00
Dylan K. Taylor
98cdc80d37
Protocol changes for 1.16.100
2020-11-21 01:07:25 +00:00
Dylan K. Taylor
5b01cf72dd
Data sync and version bump for 1.16.20
...
this version doesn't change any packets as far as I know, but it does change some packet content (most notably, some blockstates changed, which are troublesome when not in sync).
2020-08-11 21:17:11 +01:00
Dylan K. Taylor
63f57841de
PlayerAuthInputPacket: fixed yaw/pitch being the wrong way round, closes #3757
2020-08-07 19:50:49 +01:00
Dylan K. Taylor
8da7e789fd
LoginPacket: protocol cannot be NULL
2020-08-04 16:55:47 +01:00
Dylan K. Taylor
cd022f1592
EmotePacket: make FLAG_SERVER constant public
2020-07-10 20:02:32 +01:00
Dylan K. Taylor
8ce0022de6
protocol: added UUInventorySlotOffset constants
2020-07-04 21:37:37 +01:00
Twisted
8cf025a2df
Default isVerified to true ( #3644 )
2020-06-27 21:17:34 +01:00
Dylan K. Taylor
a6c1b7bf9c
InventoryTransactionPacket: added missing field for encode
2020-06-26 20:57:48 +01:00
Dylan K. Taylor
4fed08bcd4
ProtocolInfo: fixed version number
2020-06-26 14:15:58 +01:00
Dylan K. Taylor
e990c5a0a5
Protocol changes for 1.16.0
2020-06-26 14:06:41 +01:00
Dylan K. Taylor
3ecae0db19
WindowTypes: fill in a couple of blanks
2020-06-26 12:04:11 +01:00
Dylan K. Taylor
c5bbb2bcbc
Move crafting action detection from InventoryTransactionPacket to Player
2020-06-26 11:59:30 +01:00
Dylan K. Taylor
24a2889758
NetworkInventoryAction does not require an InventoryTransactionPacket
2020-06-26 11:51:06 +01:00
Dylan K. Taylor
60b26a7ea8
NetworkBinaryStream: unknown byte preceding NBT is a version, not a count
2020-06-26 11:47:08 +01:00
Dylan K. Taylor
e105578be0
LegacySkinAdapter: an extra check for resourcePatch (fixes 3 phpstan explicitMixed errors)
2020-06-18 20:08:38 +01:00
Dylan K. Taylor
77c71e22b2
SkinAdapter::fromSkinData() may now throw InvalidSkinException
...
fixes a rogue TODO in LegacySkinAdapter and invalid skins maybe showing up as Steve instead of getting kicked off the server
2020-06-17 21:44:22 +01:00
Dylan K. Taylor
1c13ba5656
Avoid parameter ordering bugs during packet decoding
...
A PhpStorm refactor could have side effects on code that directly reads stuff from the packet input stream in the arguments block, because those calls will get moved into a different order if the constructor gets refactored. This would, obviously, break packet decoding, so that's something we should avoid and really should not encourage.
2020-06-17 21:01:01 +01:00
Dylan K. Taylor
f970be0e4d
SkinImage: 128x64 is not a valid classic skin size
...
MC itself doesn't accept classic skins of this size.
2020-06-17 20:31:28 +01:00
Dylan K. Taylor
11a3f9f1b9
VerifyLoginTask: fast-fail by checking header x5u before verifying signature
...
this is less costly, although it doesn't make any difference except in invalid cases.
2020-06-17 17:52:19 +01:00
Dylan K. Taylor
09771849ae
VerifyLoginTask optimisation: do not copy the entire LoginPacket into the worker thread
...
this is especially bad considering the fact that the cached buffer is copied. That said, it's only a few kilobytes so it's not a huge problem, but nonetheless...
2020-06-17 17:46:22 +01:00
Dylan K. Taylor
57a310230a
ScoreboardIdentityPacketEntry: added missing field default
2020-06-15 23:59:53 +01:00
Dylan K. Taylor
130c55d9f1
EntityLink: remove rogue default ctor parameters
2020-06-15 23:58:11 +01:00
Dylan K. Taylor
2712befa82
SkinData: fixed capeImage type violation (doesn't accept null)
2020-06-15 23:51:48 +01:00
Dylan K. Taylor
fcc9e62c65
CommandEnum: specify enumValues type
...
phpstan 0.12.26 starts reporting errors about the result of array_search() being given to some constructor or another because of the lack of key type specification.
2020-06-10 10:33:35 +01:00
Dylan K. Taylor
f24be2b055
Merge branch 'stable' into next-minor
...
# Conflicts:
# src/pocketmine/Player.php
# src/pocketmine/block/SnowLayer.php
2020-06-01 13:42:59 +01:00
Dylan K. Taylor
5056754cea
NetworkBinaryStream: do not round vectors directly on reading
...
fixes #3199
2020-05-31 20:17:42 +01:00
Dylan K. Taylor
ecbf21acea
Utils: added OS constants, remove hardcoded OS strings everywhere
2020-05-23 11:05:58 +01:00
Dylan K. Taylor
56f90a2901
Merge branch 'stable' into next-minor
2020-05-20 20:05:00 +01:00
Dylan K. Taylor
bf6af269c8
StartGamePacket: use PUBLIC visibility by default
2020-05-20 20:04:39 +01:00
Dylan K. Taylor
73d1f84072
Merge branch 'stable' into next-minor
2020-05-20 19:36:20 +01:00
Dylan K. Taylor
a29424f5b3
UIProfile: name constants as they appear in the MC user-facing settings
...
I think these names are stupid, but it'll be easier for people to figure out what they refer to if they match the client-sided naming.
2020-05-20 15:06:50 +01:00
Dylan K. Taylor
3a78735982
added UIProfile protocol constants
...
these are only used in the LoginPacket, but plugin devs will probably find them useful anyway
2020-05-20 14:27:50 +01:00
Dylan K. Taylor
ab32784c74
UpdateBlockSyncedPacket: remove default values for fields
2020-05-20 13:58:36 +01:00
Dylan K. Taylor
816234a379
UpdateBlockSyncedPacket: populate missing information for second field
2020-05-20 13:57:08 +01:00
Dylan K. Taylor
b7bf92a5e9
SimpleEventPacket: added missing type constant
2020-05-20 13:50:43 +01:00
Dylan K. Taylor
dcca000ead
PlayerActionPacket: added missing constant
2020-05-20 13:44:52 +01:00
Dylan K. Taylor
c4ea51f985
NpcRequestPacket: added request type constants
2020-05-20 13:42:40 +01:00
Dylan K. Taylor
8202bb1cd8
MoveActorAbsolutePacket: added missing flag
2020-05-20 13:39:56 +01:00
Dylan K. Taylor
b75758e35e
MoveActorDeltaPacket: added missing flags
2020-05-20 13:39:37 +01:00
Dylan K. Taylor
38a06f76f8
LoginPacket: remove unused constant
2020-05-20 13:15:43 +01:00
Dylan K. Taylor
84f99ed418
CommandOriginData: Rename previously unknown field
2020-05-20 13:00:03 +01:00
Dylan K. Taylor
fd63f19199
make use of new GameRuleType constants
2020-05-20 12:35:29 +01:00
Dylan K. Taylor
66d44aa814
added GameRuleType protocol constants
2020-05-20 12:35:07 +01:00
Dylan K. Taylor
f3089f577e
StartGamePacket: use new protocol constants for multiplayer visibility
2020-05-20 12:22:33 +01:00
Dylan K. Taylor
9516ef1632
added GamePublishSetting protocol constants
2020-05-20 12:22:12 +01:00
Dylan K. Taylor
e982a57cb5
StartGamePacket: use EducationEditionOffer constants
2020-05-20 12:08:56 +01:00
Dylan K. Taylor
f57fa2252b
added EducationEditionOffer protocol constants
2020-05-20 12:08:36 +01:00