908aa20eff
EntityFactory: fixed type doc of knownEntities
2019-12-04 22:49:25 +00:00
09961b5cd0
Merge branch 'stable' into next-minor
2019-12-04 22:16:04 +00:00
7b1ae2a822
phpstan: green on level 3
2019-12-04 22:12:14 +00:00
8ecf5e02b9
bad fix for WritableBook phpstan warning
...
master has this shit so much better
2019-12-04 22:00:19 +00:00
39c607cbd5
Position: mark level field as nullable
...
allowing the level to be null is, to be honest, a big design flaw, but one that can't be fixed without BC breaks.
2019-12-04 21:31:35 +00:00
d867ffc60d
MetadataStore: fix some doc comments
2019-12-04 21:14:09 +00:00
0e3ce7ff39
Merge branch 'next-minor'
2019-12-04 19:59:57 +00:00
71a472e0eb
Merge branch 'stable' into next-minor
2019-12-04 19:52:01 +00:00
c57eb26fd5
phpstan-bugs: add some extra patterns for level 3 false positives
2019-12-04 19:50:15 +00:00
c35d91a104
phpstan: allow blanket ignoreErrors in src to reduce merge work for master
2019-12-04 19:42:18 +00:00
9fc260fb1a
keep phpstan.neon.dist ignoreErrors sorted by file
2019-12-04 19:38:54 +00:00
b43bd5fb67
PluginCommand: separate CommandExecutor param
...
looking at the code now it's clear that this class combines two jobs into the same class.
closes #3203
2019-12-04 19:14:52 +00:00
2ff25dfbd2
Color: make mix() first parameter mandatory, closes #3204
2019-12-04 18:39:14 +00:00
60154d8127
SubChunkIteratorManager: assert type of subchunk to make PHPStan happy
...
we know this should be a SubChunk, even though it doesn't.
2019-12-04 18:26:18 +00:00
e35a92d8e8
tile\Banner: fixed bad default value for patterns field
...
detected by PHPStan on level 3
2019-12-04 18:25:08 +00:00
850dbb38c6
phpstan-bugs: remove false positive that is fixed in 0.12.0
2019-12-04 11:38:01 +00:00
c0ea871599
updated rules for master on PHPStan 0.12
2019-12-04 11:35:57 +00:00
117e46f639
LevelDB: fix doc comment handling for deserializeLegacyExtraData()
2019-12-04 11:29:41 +00:00
66aa940ed1
Item: fixed foreach doc comment in deserializeCompoundTag()
...
detected by PHPStan 0.12.0
2019-12-04 11:28:59 +00:00
dc5d985cf4
Merge branch 'next-minor'
2019-12-04 11:23:30 +00:00
e65bc5c3ae
Merge branch 'stable' into next-minor
2019-12-04 11:11:29 +00:00
73d0f799c2
Update to PHPStan 0.12.0
2019-12-04 10:29:49 +00:00
ecb2e6e3af
PluginManager: remove useless information from softDepend debug
...
we don't report the parameter type anywhere else, and since PHP doesn't support overloading, we don't need to.
This fixes PHPStan 0.12 complaints about ReflectionNamedType. I figured this was the best solution instead of adding an extra few lines of code.
2019-12-04 10:17:25 +00:00
7b75b6928d
AvailableCommandsPacket: fixed foreach docs
...
these probably aren't necessary at all to be honest.
2019-12-04 10:15:50 +00:00
753a8a6937
Event: remove useless @var $this annotations
...
we are not in a trait here, the scope is always Event.
2019-12-04 10:15:04 +00:00
bc76b1cafe
Server: remove several redundant @var annotations (copy pasta)
...
these are all useless because it is implied by the parameter type anyway.
2019-12-04 10:14:15 +00:00
f302517a2d
Door: fix deserialization of top flag
...
it's not clear what bugs this caused, if any, but nonetheless it is incorrect.
2019-12-03 21:04:04 +00:00
962e6162eb
Merge branch 'next-minor'
2019-12-03 20:00:08 +00:00
2ae37cc1c5
Merge branch 'stable' into next-minor
2019-12-03 19:59:35 +00:00
00e415fc79
move phpstan.neon to phpstan.neon.dist to allow phpstan.neon to be locally modified for development
2019-12-03 19:57:19 +00:00
29ce829247
fix error counts for UPnP
2019-12-03 17:45:23 +00:00
5b91be81cc
Entity: rewrite dbbe1f2d5c for master
2019-12-03 12:16:10 +00:00
54c2778e56
phpstan: update split configs for master branch
2019-12-03 12:08:56 +00:00
5f9ce78814
WorldProviderManager: removed incorrect param doc
...
this was used to trick phpstorm, but PHPStan doesn't like it, and it isn't consistently used anyway.
2019-12-03 12:08:04 +00:00
fede6b8234
protocol: fixed static analysis warnings in MetadataProperty::equals() implementations
2019-12-03 12:06:57 +00:00
e110ea5aea
LoginPacket: fixed param doc for validate()
2019-12-03 11:59:28 +00:00
d3d7709ead
Merge branch 'next-minor'
2019-12-03 11:55:45 +00:00
9a67192f74
Merge branch 'stable' into next-minor
2019-12-03 10:45:51 +00:00
dbbe1f2d5c
Revert "Entity: remove redundant check from spawnTo()"
...
This reverts commit 3028832cd3#3178 .
2019-12-03 10:41:13 +00:00
740f0a2314
crafting now works on 1.13, but it's not good
2019-12-02 21:50:52 +00:00
7fdfe947b0
inventory: fix some transactions being rejected for no good reason
...
since 1.13, transactions such as interacting with creative inventory cause a spoof windowID 124 slot 50 action to appear which changes air -> air. This currently gets rejected because only cursor is mapped to ID 124, and it only has a single slot.
It is not clear what the purpose of 124:50 is, but this fix filters out any actions which do not change anything, since they won't affect transaction balance anyway.
2019-12-02 21:41:08 +00:00
b7c4379700
StartGamePacket: fixed asymmetry in block table handling
2019-12-02 19:35:55 +00:00
02c1dabc3d
update pocketmine/nbt dependency
2019-12-02 19:24:00 +00:00
20b7418916
PlayerAuthInputPacket: added encode & decode, and some aux classes
2019-12-02 15:14:59 +00:00
85521f5e7a
EducationSettingsPacket: added encode & decode
2019-12-02 13:57:19 +00:00
f37ea6a203
AvailableCommandsPacket: fix nonsensical placement of HARDCODED_ENUMS
2019-12-02 12:57:05 +00:00
abf8081ebc
RuntimeBlockMapping: add a type check for decoded NBT root type
...
this is kinda redundant since this function can blow up in so many other ways anyway, but it makes PHPStan happy, so it'll do.
2019-12-02 08:21:42 +00:00
8594cb3e74
AvailableCommandsPacket: fixed doc comment for putEnumConstraint()
2019-12-02 08:17:00 +00:00
d155de35ed
Merge branch 'dktapps-drew-1.13' into stable
2019-12-01 22:03:03 -05:00
e37c8e3a5d
Merge branch 'drew-1.13' of https://github.com/dktapps/PocketMine-MP into dktapps-drew-1.13
2019-12-01 22:02:40 -05:00
