7e3e63f342
Fixed race condition in MainLogger shutdown
...
this resulted in a deadlock in https://github.com/pmmp/PocketMine-MP/runs/1831812620?check_suite_focus=true because the notify() arrived while writeLogStream() was executing.
This ensures that either:
- the notification will occur before the sleep, and therefore no sleeping will occur (this->shutdown = true before the wait)
- the notification will arrive during the sleep.
2021-02-04 16:40:10 +00:00
8ef1e54e20
MainLogger: fixing CPU waste on logger thread
...
this doesn't need to keep spinning every 25ms; it can just wake up when there's actually log messages to write into the buffer.
2021-02-04 15:07:40 +00:00
eaf3a86981
MainLogger: fixed UB in writeLogStream()
...
notify() has to be used inside a synchronized block.
2021-02-04 15:03:14 +00:00
317a48d9b0
ItemStackRequest: expose filterStrings
2021-02-03 23:40:34 +00:00
bc14660e55
Added missing ItemStackRequest protocol changes
2021-02-03 23:37:41 +00:00
b1bb9fbd1c
Reinstall PHP deps on cache hit
...
the 20.04 actions image doesn't have libzip5 and who knows what else is missing ...
2021-02-03 17:42:11 +00:00
96181f8cf5
Version PHP build caches by image version
...
we can't safely use `ubuntu-latest` because the build caches will break if they were built for 18.04 and used on 20.04, or vice versa. Instead, we pin the images (and caches) to a specific version.
2021-02-03 17:24:50 +00:00
4771e3dc28
3.17.5 is next
2021-02-02 14:04:51 +00:00
2e9117d102
Release 3.17.4
2021-02-02 14:04:50 +00:00
06493da7d9
Imports cleanup
2021-02-02 13:58:07 +00:00
bd303b1062
RegionLoader: fixed flaky region header validation since 3.17.3
2021-02-02 13:43:52 +00:00
fe731b9018
Added failing test case for region header validation
...
fucking PHP... what genius thought it was a good idea to cache file stats without even an attempt at keeping the cache up to date on modifications?
2021-02-02 13:43:12 +00:00
1a24afc6d1
InventoryTransaction: Fixed indexes persisting from balance calculation in crafting input/outputs
...
fixes #4019
the order of the actual items may not be the same across runs, but index 0 will at least be sure to exist.
2021-02-02 00:13:58 +00:00
bef906b0f0
phpstan 0.12.71
2021-02-02 00:05:53 +00:00
37e8dd6444
Fix PHP 8 optional before required parameters deprecation warnings ( #4016 )
2021-01-31 12:08:47 +00:00
02ee0f23c0
Removed old support requests configuration
2021-01-27 22:53:37 +00:00
cda472333c
Add workflow for dessant/support-requests
...
we're using the legacy github app right now.
2021-01-27 22:47:33 +00:00
47cf58be8a
phpstan 0.12.70
2021-01-27 20:11:37 +00:00
ccf9691927
Bump phpunit/phpunit from 9.5.0 to 9.5.1 ( #4010 )
2021-01-27 19:28:36 +00:00
16fa958416
phpstan: better hack for any-callable parameters
...
variadics are a bad fit for this because what we really need is to accept callable with any number of arguments. LSP requires that the provided number of arguments must be >= than the required number of arguments.
2021-01-27 19:25:28 +00:00
bac57c159f
Player: fix bridging, towering and various other fast building bugs
...
clickPos is relative to the base block position, so if you keep aiming at the same spot on the block and jump, it thinks you're still spamming.
closes #2730
2021-01-27 00:11:14 +00:00
38b2d83799
MemoryManager: fixed protected properties being dumped multiple times
...
we don't need to scan the parent classes for anything other than private properties, because protected and public properties will appear on the main reflection as if they were declared directly as such.
2021-01-26 20:32:23 +00:00
c134b1cd8a
[ci skip] README: add some badges
2021-01-26 17:34:05 +00:00
62deafda48
CommandReader: removed readline support
...
readline has been borked for a long time and it's not thread safe.
2021-01-25 17:53:25 +00:00
31b6df4376
3.17.4 is next
2021-01-25 17:15:43 +00:00
b296ae1b87
Release 3.17.3
2021-01-25 17:15:31 +00:00
f9e42b716a
Scrub PHPStan baselines
...
these are now always generated with level 8.
2021-01-24 20:31:22 +00:00
34c1d455a7
phpstan: enable checkMissingCallableSignature
2021-01-24 20:27:53 +00:00
af8936dba5
phpstan 0.12.69
2021-01-24 20:14:42 +00:00
e8ffab1787
RegionLoader: avoid hitting the disk twice during chunk reads
...
this provides some performance improvement (although it's difficult to measure because of cache).
this does mean that we read some garbage data during chunk reads, but it's less costly than hitting the disk twice.
2021-01-20 21:05:44 +00:00
ecc1e1f698
RegionLoader: improve performance of region header validation
...
I was unaware that fseek actually makes a syscall which is rather costly, which became painfully obvious during large world conversions on PM4.
On average this problem appeared to be adding about 5ms to the load time for a newly loaded region, which is insanely expensive.
2021-01-20 20:04:21 +00:00
ea5931e274
Updated build/php submodule to pmmp/php-build-scripts@60194e8b14
2021-01-16 19:34:06 +00:00
988cf7f535
Fixed PHP 8.0 deprecation error
2021-01-16 19:31:07 +00:00
e156fb47e8
Disable xdebug on Actions
2021-01-15 21:09:45 +00:00
efc5f34877
wrong place ... when shared defaults :(
2021-01-15 17:53:39 +00:00
dd0d8842d5
actions: disable fail-fast
2021-01-15 17:35:27 +00:00
7bdc564ccc
Update first-party dependencies to PHP 8.0 compatible versions
...
all deps of PM3 are ready (at least as far as PHPStan can show).
2021-01-15 16:59:51 +00:00
69fff23f1a
LevelProviderManager: removed bogus @var
...
I'm not sure why this wasn't detected until 0.12.67...
2021-01-15 16:53:49 +00:00
ae43698e88
phpstan 0.12.67
...
for some reason dependabot shit itself while trying to scan for updates and thought this wasn't updatable ...
2021-01-15 16:53:49 +00:00
0987e03c03
Bump phpstan/phpstan-strict-rules from 0.12.8 to 0.12.9 ( #4003 )
2021-01-13 10:55:54 +00:00
97c124edf9
thanks git, this just sneaked in without any questions ................
2021-01-12 21:43:34 +00:00
56501178b7
Updated composer dependencies
2021-01-12 21:41:25 +00:00
da663deea1
Bump phpstan/phpstan from 0.12.65 to 0.12.66 ( #4001 )
2021-01-12 10:41:59 +00:00
972c911485
phpstan 0.12.65
2021-01-09 18:04:42 +00:00
0d8858f948
composer.json: sort packages automatically
2021-01-09 17:38:22 +00:00
da71540fce
first shot building multi PHP versions on actions
2021-01-05 22:03:51 +00:00
ec9b39862b
bootstrap: commit suicide if composer dependencies are not in sync
2020-12-29 17:47:32 +00:00
efca8077d5
3.17.3 is next
2020-12-28 23:03:37 +00:00
5066d5225b
Release 3.17.2
2020-12-28 23:03:32 +00:00
aefaf73685
Living: extract an applyConsumptionResults() method from consumeObject()
...
inspired by #3592 , which has gone stale
2020-12-28 22:27:29 +00:00
