c19ab97610
AddActorPacket: move BC hack to higher level
...
we shouldn't hack the protocol impl for BC.
2020-02-27 17:37:45 +00:00
dbaf851be7
Merge branch 'stable' into next-minor
2020-02-27 16:51:06 +00:00
7aa8bd18d3
Revert "Item: restrict bounds of count to 0-255"
...
This reverts commit 10317527e4
2020-02-25 20:42:03 +00:00
53067c26d7
BaseInventory: stop mutating item for no reason in canAddItem()
2020-02-25 20:30:37 +00:00
04581e2700
DataPacket: account for splitscreen header when decoding
2020-02-24 21:20:25 +00:00
93597dcd50
SkinData: fixed loss of data from packet decode
2020-02-24 20:48:03 +00:00
778814a35e
changelog: fix typo
2020-02-24 20:18:47 +00:00
3cd1da196a
UpdateTradePacket: fix order of fields, closes #3327
2020-02-24 20:16:07 +00:00
365d4a1592
better fix for 1.14.30 movement bug
2020-02-23 19:31:32 +00:00
2d7f37ac47
avoid direct mutation of Item->count field, use Item->pop() instead
...
I think this change was already applied on the master branch, but I don't remember for sure.
2020-02-23 17:37:25 +00:00
50fcdd6e7e
Item: fixed documentation of pop() return type (it's not fluent)
2020-02-23 17:32:50 +00:00
10317527e4
Item: restrict bounds of count to 0-255
2020-02-23 17:23:53 +00:00
46ac4cbca1
3.11.7 is next
2020-02-21 19:18:48 +00:00
cb9e79b398
Release 3.11.6
2020-02-21 19:18:48 +00:00
2f1fad2745
Bucket: implement MaybeConsumable, fixes #3306
...
this is a nauseating fix, but it's only needed for stable.
2020-02-21 17:49:55 +00:00
44182dccbd
Human: an additional hack for MoveActor(Absolute|Delta)Packet on 1.14.30+
...
before anyone asks, we still can't use this for regular player movement, because it would cause the player to receive their own movement. This was OK with MoveActor, but isn't OK with MovePlayer.
2020-02-21 12:35:17 +00:00
2f3d2d4a0b
Bump phpstan/phpstan from 0.12.10 to 0.12.11 ( #3311 )
2020-02-19 18:57:53 +00:00
8ac7f7f11f
Level: fix type of randomTickBlocks and friends
2020-02-17 15:13:40 +00:00
dbe7caab7b
updated build/preprocessor submodule
2020-02-14 08:21:46 +00:00
b581fab31a
updated build/php submodule
2020-02-14 08:19:23 +00:00
7b7dfc36d1
Living: fixed broken @var tag
2020-02-14 08:17:51 +00:00
d63d6b73f6
Player: workaround 1.14.30 movement bug
...
I can understand why this bug happened, but it doesn't mean I like it.
Fix it pls mojang, this sucks.
2020-02-13 19:40:31 +00:00
a860ccd259
Bump phpstan/phpstan from 0.12.9 to 0.12.10
...
Bumps [phpstan/phpstan](https://github.com/phpstan/phpstan ) from 0.12.9 to 0.12.10.
- [Release notes](https://github.com/phpstan/phpstan/releases )
- [Commits](https://github.com/phpstan/phpstan/compare/0.12.9...0.12.10 )
Signed-off-by: dependabot-preview[bot] <support@dependabot.com >
2020-02-13 11:24:13 +00:00
2bb497b716
Chunk: flag hasChanged when changing generated/populated/light-populated flags
2020-02-11 08:26:12 +00:00
613bd40601
PopulationTask: move setPopulated() call to make it more obvious what is going on
2020-02-10 18:22:19 +00:00
398b636759
PopulationTask: fixed chunks being generated empty in flat worlds
...
the flat generator just clones a pregenerated chunk instead of modifying the provided chunks, which means that the references that population task has would be the outdated ones.
2020-02-10 18:21:08 +00:00
19bd283807
Process: drop a blank line
2020-02-10 12:23:11 +00:00
20d1a048dd
fixup imports
2020-02-10 12:21:56 +00:00
15b76a24b7
scrub useless phpdoc
2020-02-10 12:21:07 +00:00
2d51971b84
Revert "ClosureTask: drop requirement for void return type"
...
This reverts commit 9e993aa83f
2020-02-10 11:40:47 +00:00
f08e411cad
Merge branch 'stable' into next-minor
2020-02-10 11:40:08 +00:00
1257378198
clean up function imports
2020-02-08 09:31:15 +00:00
758a68aa2c
ItemFactory: add Item[] as type for list field (for auto complete)
2020-02-07 20:11:31 +00:00
bfce478e72
BlockFactory: keep the generic types for PHPStan, which actually understands it
2020-02-07 20:10:40 +00:00
681dd469a2
PluginManager: add class-string phpstan param to registerEvent()
2020-02-07 20:05:41 +00:00
3edbea8545
PluginManager: fix spacing of phpdoc comment for registerEvent()
2020-02-07 19:37:22 +00:00
ada8cbb545
phpstan: drop some ignoreErrors that don't occur on 0.12.9
2020-02-06 21:01:05 +00:00
0ac5e03ce9
Require PHPStan 0.12.9 minimum
2020-02-06 20:59:43 +00:00
9b02b8e51e
Item: do not compare serialized NBT in equals()
...
this isn't cached anymore, and would be a performance drag.
It would be nice to have some kind of fast path for this, but comparing NBT binary isn't it.
2020-02-06 20:23:58 +00:00
6c7dada232
finally, integrate phpstan-strict-rules
2020-02-06 19:44:10 +00:00
25bc95cd1e
removing more unnecessary casts
2020-02-06 19:33:34 +00:00
213bf8366a
TranslationContainer: fix parameter type of setParameters()
2020-02-06 19:33:34 +00:00
4e693e91e6
ChestInventory: document that getHolder() may return Position
...
there is a variance issue with EnderChestInventory that was detected by phpstan-strict-rules which can't be addressed without a BC break. This fix will at least allow static analysers to be aware that code using this function might catch fire when it sees an EnderChestInventory without realizing it.
2020-02-06 19:33:34 +00:00
a1622fa345
UtilsTest: silence a phpstan-strict-rules warning
2020-02-06 18:53:05 +00:00
0ec869932f
Item: clean up internal NBT storage, discard useless legacy network cache
...
this will now bail if the NBT string given is invalid upon setCompoundTag(), rather than shitting the bed when it's accessed.
2020-02-06 17:59:05 +00:00
79acaa3253
Utils: remove useless typecasts
2020-02-06 16:06:58 +00:00
da3742b39e
Remove useless typecasts
2020-02-06 16:00:57 +00:00
d26fcf7dee
Removed useless casts() from min/max calls
2020-02-06 15:58:27 +00:00
812424a619
GroundCover: drop useless variable in calculating startY
2020-02-06 14:26:03 +00:00
1bdc61dd5f
Ore: do not destroy outer scope vars in for loops
2020-02-06 14:24:57 +00:00
