Dylan K. Taylor
758b5ee500
InventoryManager: fixed armor slots hack
...
the correct condition for this should be an unsynced armor slot changed during a transaction, but conveying this information to syncSlot() is a bit of a hassle, so this will do for now.
2023-03-20 21:27:56 +00:00
Dylan K. Taylor
ca6d51498f
Buffer slot and content syncing until the end of the tick
...
we may receive multiple requests in one tick (e.g. crafting in a batch)
2023-03-20 19:16:00 +00:00
Dylan K. Taylor
e8085e22a0
Fixed crash when opening main inventory
...
the InventoryManagerEntry was getting overwritten, since we don't expect to open the same inventory with two different window IDs.
2023-03-20 18:40:18 +00:00
Dylan K. Taylor
a83fc85f1e
InventoryManagerEntry: fixed missing default
2023-03-20 17:32:44 +00:00
Dylan K. Taylor
3d70a169e1
Reduce chaos in InventoryManager
...
the information in these arrays is usually needed all at the same time, so it doesn't make sense to force multiple array lookups for it.
in addition, this (obviously) cleans up the code quite a lot.
2023-03-20 17:31:54 +00:00
Dylan K. Taylor
6ccb8f7373
git
2023-03-20 16:57:38 +00:00
Dylan K. Taylor
59bae9b077
Give InventoryManager internals clearer names
...
and stop mixing 'window' and 'inventory' terminology...
2023-03-20 16:53:57 +00:00
Dylan K. Taylor
c91168db66
...
2023-03-20 01:35:15 +00:00
Dylan K. Taylor
4e55433ed8
Fixed request rejecting
2023-03-20 01:35:03 +00:00
Dylan K. Taylor
eece6c4433
InGamePacketHandler: remove dead code
2023-03-20 01:28:18 +00:00
Dylan K. Taylor
67b7b60d18
..............
2023-03-20 01:19:07 +00:00
Dylan K. Taylor
804feedb67
Added some dumb limits
2023-03-20 00:54:33 +00:00
Dylan K. Taylor
d57aca1367
CS
2023-03-20 00:53:00 +00:00
Dylan K. Taylor
7b0816e42f
Properly handle transaction building errors instead of kicking the player
2023-03-20 00:52:26 +00:00
Dylan K. Taylor
4864444440
Added CraftingManager::getCraftingRecipeFromIndex()
2023-03-19 22:14:23 +00:00
Dylan K. Taylor
34ced382db
Eliminate final remaining usage of TypeConverter::netItemStackToCore()
...
instead, we can verify that the held items match by comparing the received ItemStack with the one cached in InventoryManager, which is more cost effective and closes off internal item deserializers to external attacks.
2023-03-14 22:56:11 +00:00
Dylan K. Taylor
a573a279fa
Merge branch 'minor-next' into item-stack-request
2023-03-14 22:25:49 +00:00
Dylan K. Taylor
14f141fab2
NetworkSession: Stop counting DataPacketReceiveEvent in handler timings
...
we want it to be included in receive timings, but not handler timings. Handler timings should reflect the time spent in the actual session PacketHandler, not in the event.
2023-03-14 19:00:15 +00:00
Dylan K. Taylor
daff955bc4
Merge remote-tracking branch 'origin/stable' into minor-next
2023-03-14 18:42:14 +00:00
Dylan K. Taylor
0022d82779
Merge commit 'd376399b7f332384532a82eaf69b9b02dad5bd0c' into minor-next
2023-03-14 18:39:03 +00:00
dependabot[bot]
7cad9be0d2
Bump build/php from b2207cf to 71b9f9d ( #5634 )
...
Bumps [build/php](https://github.com/pmmp/php-build-scripts ) from `b2207cf` to `71b9f9d`.
- [Release notes](https://github.com/pmmp/php-build-scripts/releases )
- [Commits](b2207cf70d...71b9f9d2d7
2023-03-14 18:32:10 +00:00
Dylan K. Taylor
2f862a552a
actions: Replace deprecated ::set-output commands
2023-03-14 18:31:25 +00:00
Dylan K. Taylor
590f6dad08
4.17.1 is next
2023-03-14 18:14:40 +00:00
Dylan K. Taylor
9564c81582
Release 4.17.0
2023-03-14 18:14:40 +00:00
Dylan K. Taylor
3de7a8c27f
Updated for 1.19.70
2023-03-14 18:08:10 +00:00
Dylan K. Taylor
d376399b7f
Update composer dependencies
...
bedrock-item-upgrade-schema and bedrock-block-upgrade-schema are now minor-version-locked, to prevent introducing new upgrade schemas not intended for the currently in-use version
previously I'd intended to do this using max schema IDs, but this has proven to be error-prone, so it makes more sense to lock them in using package version constraints instead.
2023-03-14 17:29:25 +00:00
Dylan K. Taylor
e2071e59c8
actions: update PHP versions
2023-03-13 17:44:10 +00:00
Dylan K. Taylor
8e280ebb8b
RuntimeBlockMapping: avoid unnecessary PacketSerializer usage
2023-03-11 22:16:24 +00:00
Dylan K. Taylor
fa7c38276c
Fixing gigantic clusterfuck with protocol contexts and broadcasting
...
fixes #5623
2023-03-11 21:54:14 +00:00
Dylan K. Taylor
b13e97de3d
Timings: fixed receivePacket timer showing 2x the actual number of received packets
2023-03-11 19:13:10 +00:00
dependabot[bot]
328b87fc18
Bump phpstan/phpstan from 1.10.4 to 1.10.6 ( #5617 )
...
Bumps [phpstan/phpstan](https://github.com/phpstan/phpstan ) from 1.10.4 to 1.10.6.
- [Release notes](https://github.com/phpstan/phpstan/releases )
- [Changelog](https://github.com/phpstan/phpstan/blob/1.10.x/CHANGELOG.md )
- [Commits](https://github.com/phpstan/phpstan/compare/1.10.4...1.10.6 )
---
updated-dependencies:
- dependency-name: phpstan/phpstan
dependency-type: direct:development
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2023-03-10 11:49:34 +00:00
Dylan T
acaa1a9ce1
contributing: update table to reflect branch name changes
...
these branches were renamed to make them more auto-complete-friendly.
2023-03-07 17:28:31 +00:00
Dylan K. Taylor
3aec0fa3df
4.16.1 is next
2023-03-07 16:19:51 +00:00
Dylan K. Taylor
fa131dab12
Release 4.16.0
2023-03-07 16:19:50 +00:00
Dylan K. Taylor
bb4a82b1e7
Merge branch 'next-minor' into stable
2023-03-07 16:15:57 +00:00
Dylan K. Taylor
93d844a281
build/make-release: improve support for non-stable release channels
2023-03-07 16:12:27 +00:00
Dylan K. Taylor
616844696e
4.15.4 is next
2023-03-07 15:33:03 +00:00
Dylan K. Taylor
71e3e36522
Release 4.15.3
2023-03-07 15:33:03 +00:00
Dylan K. Taylor
a1b42d419f
Merge branch 'stable' into next-minor
2023-03-07 15:24:24 +00:00
Dylan K. Taylor
ef942a627f
actions: drop concurrency group
...
this is causing builds to get randomly cancelled when multiple branches are pushed at once.
2023-03-07 15:23:12 +00:00
Dylan K. Taylor
fd8c276bd2
Merge branch 'stable' of github.com:pmmp/PocketMine-MP into stable
2023-03-07 15:15:21 +00:00
Dylan K. Taylor
9783380d1a
Merge branch 'stable' into next-minor
2023-03-07 15:13:39 +00:00
Dylan K. Taylor
a784d93bfd
Update composer dependencies
2023-03-07 15:13:16 +00:00
dependabot[bot]
a05e8b366f
Bump phpstan/phpstan from 1.10.3 to 1.10.4 ( #5610 )
...
Bumps [phpstan/phpstan](https://github.com/phpstan/phpstan ) from 1.10.3 to 1.10.4.
- [Release notes](https://github.com/phpstan/phpstan/releases )
- [Changelog](https://github.com/phpstan/phpstan/blob/1.10.x/CHANGELOG.md )
- [Commits](https://github.com/phpstan/phpstan/compare/1.10.3...1.10.4 )
---
updated-dependencies:
- dependency-name: phpstan/phpstan
dependency-type: direct:development
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2023-03-07 14:40:08 +00:00
Dylan K. Taylor
87a2e0460c
Ping Discord news subscribers on new releases
2023-03-04 17:09:32 +00:00
Dylan K. Taylor
4073c3fb39
Update composer dependencies
2023-03-04 16:56:08 +00:00
Dylan K. Taylor
e227e6d8bf
Merge branch 'stable' into next-minor
2023-03-04 16:55:56 +00:00
Dylan K. Taylor
3aa40829ae
Update composer dependencies
2023-03-04 16:55:31 +00:00
Dylan K. Taylor
035d4b7263
MemoryManager: stringify floats, fixes #5598
2023-03-04 16:47:58 +00:00
Dylan K. Taylor
3db1492c18
Fix CS again
2023-03-04 16:43:29 +00:00
