Dylan K. Taylor
54c2778e56
phpstan: update split configs for master branch
2019-12-03 12:08:56 +00:00
Dylan K. Taylor
5f9ce78814
WorldProviderManager: removed incorrect param doc
...
this was used to trick phpstorm, but PHPStan doesn't like it, and it isn't consistently used anyway.
2019-12-03 12:08:04 +00:00
Dylan K. Taylor
fede6b8234
protocol: fixed static analysis warnings in MetadataProperty::equals() implementations
2019-12-03 12:06:57 +00:00
Dylan K. Taylor
e110ea5aea
LoginPacket: fixed param doc for validate()
2019-12-03 11:59:28 +00:00
Dylan K. Taylor
d3d7709ead
Merge branch 'next-minor'
2019-12-03 11:55:45 +00:00
Dylan K. Taylor
9a67192f74
Merge branch 'stable' into next-minor
2019-12-03 10:45:51 +00:00
Dylan K. Taylor
dbbe1f2d5c
Revert "Entity: remove redundant check from spawnTo()"
...
This reverts commit 3028832cd35c53937bb6502f74d3ad53646b12a7.
When I created this commit, I made the flawed assumption that spawnTo()
would not be used by plugins. In addition, I was not aware that there
are some usages of spawnTo() in the core which do not check for chunk
usage, such as in Player->showPlayer().
This caused a collection of problems including memory leaks and crashes
due to disconnecting players not removing their references from viewed
entities.
The reverted commit may be the cause of #3178 .
2019-12-03 10:41:13 +00:00
Dylan K. Taylor
02c1dabc3d
update pocketmine/nbt dependency
2019-12-02 19:24:00 +00:00
Dylan K. Taylor
ce27c03774
PlayerChatEvent: fixed crash when non-CommandSender permissibles subscribe to broadcast permission
...
doing such a thing doesn't make any sense, but the system allows it, so it has to be accounted for.
2019-12-01 21:44:13 +00:00
Dylan K. Taylor
c4a8781b5c
Fixed doc type inconsistencies surrounding chat broadcast handling (several problems that are all related)
2019-12-01 21:40:11 +00:00
Dylan K. Taylor
dbab8b5733
Level: fixed type doc of tickRateTime field
2019-12-01 21:21:42 +00:00
Dylan K. Taylor
2b08bbc7b1
Server: fixed type doc comment of nextTick field
2019-12-01 21:18:20 +00:00
Dylan K. Taylor
17037f5e9c
Chunk: clean up nonsensical code in initChunk()
...
I have no idea why the extra check was there, or why the null assignment was used, because it doesn't make any sense.
2019-12-01 21:14:23 +00:00
Dylan K. Taylor
fee3c17148
CraftingManager: fixed type doc of craftingDataCache field
2019-12-01 21:06:34 +00:00
Dylan K. Taylor
25e6cb74b3
Squid: fixed type doc comment of swimDirection field
2019-12-01 21:06:03 +00:00
Dylan K. Taylor
8d2e59222e
Entity: fixed not calculating surrounding blocks on entity creation
...
it's unclear if this was actually causing any bugs, but if it was it would likely manifest in the form of, for example, not burning in lava.
2019-12-01 21:05:36 +00:00
Dylan K. Taylor
cd778661c2
Entity: fixed type doc comment for blocksAround field
2019-12-01 21:03:57 +00:00
Dylan K. Taylor
c2afc05e7c
Entity: fix type doc comment for static knownEntities field
2019-12-01 21:03:29 +00:00
Dylan K. Taylor
9be95bf263
Block: return [] instead of null in getMetadata() (return type is non-nullable)
2019-12-01 21:02:49 +00:00
Dylan K. Taylor
4b65e1cbe1
Command: fix type doc comment for commandMap field
2019-12-01 21:01:57 +00:00
Dylan K. Taylor
5caae37768
Server: fixed return type doc comment for getCommandAliases()
2019-12-01 21:00:49 +00:00
Dylan K. Taylor
92e1811b06
DataPacket: fixed bad null assignment to buffer in clean()
...
this is never expected to be null, so implicitly relies on PHP magic behaviour to convert it to string when appended.
2019-12-01 20:36:56 +00:00
Dylan K. Taylor
293c2710d0
PlayerCreationEvent: fixed doc comments for baseClass and playerClass fields
2019-12-01 20:19:59 +00:00
Dylan K. Taylor
8a7017fd6b
Enchantment: fixed doc comment for static enchantments field
2019-12-01 20:16:45 +00:00
Dylan K. Taylor
15f8886958
phpstan: separate non-PM bugs from the main neon config
...
everything left in here is now a PM problem that needs to be looked into.
2019-12-01 20:12:41 +00:00
Dylan K. Taylor
3226a9dc6a
phpstan: ignore more optional-leveldb errors
2019-12-01 19:52:49 +00:00
Dylan K. Taylor
1a1e3ff63b
BaseInventory: fixed incorrect & redundant default value for slots field
2019-12-01 19:45:16 +00:00
Dylan K. Taylor
ea413d0882
phpstan: analyze on level 2, close #3193
2019-12-01 19:32:03 +00:00
Dylan K. Taylor
0890b5fc99
AsyncPool: assert() that the unstacked task is actually an AsyncTask
...
it's possible that it might not be if the workers were accessed directly, but that shouldn't be possible.
This also silences a PHPStan warning on level 2.
2019-12-01 19:28:05 +00:00
Dylan K. Taylor
163ed225f2
NetworkBinaryStream: fixed crash when non-compound root tag is provided for itemstack
2019-12-01 18:41:02 +00:00
Dylan K. Taylor
a4a6d3e094
PlayerCreationEvent: fixed illegal doc comment types
2019-12-01 18:08:25 +00:00
Dylan K. Taylor
ecbf3e9722
GamemodeCommand: fix CommandSender assignment causing troubles for type inference on static analyzers
...
this would never crash, but in strongly typed code it would be a compile failure.
2019-12-01 09:33:12 +00:00
Dylan K. Taylor
47a959dace
block: fix some possible crashes when plugins overwrite tile classes in bad ways
...
phpstan was complaining on level 2, and it's not wrong to ...
2019-12-01 09:29:22 +00:00
Dylan K. Taylor
3968f85c82
sync composer dependencies
2019-12-01 08:54:48 +00:00
Dylan K. Taylor
6d109bfc6f
CraftingDataPacket: fixed not retaining cleanRecipes during decode
2019-11-30 21:15:37 +00:00
Dylan K. Taylor
42d8357821
AvailableCommandsPacket: fixed missing decoded overloads with 0 arguments
...
these should be listed even if they have 0 arguments
2019-11-30 11:58:29 +00:00
Dylan K. Taylor
0bff5d9bff
sync composer deps
2019-11-29 20:20:13 +00:00
Dylan K. Taylor
994781494f
Merge branch 'next-minor'
2019-11-29 12:06:27 +00:00
Dylan K. Taylor
4cfceeeb8e
bootstrap: fix merge error introduced by cb76f8a5dfba79857ecfd71d2953b759a03671e7
...
this error is harmless since it points to a deprecated function, but it showed up as conflicted in master merge.
2019-11-29 12:03:07 +00:00
Dylan K. Taylor
8ee3d4486a
update build/php submodule to pmmp/php-build-scripts@7e985c932a
2019-11-29 11:56:36 +00:00
Dylan K. Taylor
3e4e0d51df
Merge branch 'stable' into next-minor
2019-11-29 11:55:12 +00:00
Dylan K. Taylor
f2ac63d235
update build/php submodule to pmmp/php-build-scripts@8308571448
2019-11-29 11:54:42 +00:00
SOFe
cb76f8a5df
Merge branch 'stable' into next-minor
2019-11-21 23:21:16 +08:00
Dylan T
3e4366b30d
readme: add XLM since Keybase made it so easy
...
... and also gave lots of keybase users free XLM. Well played, Keybase, you managed to make me adopt Stellar.
2019-11-20 10:51:07 +00:00
Dylan K. Taylor
314ce1d012
build/make-release: push after 5 seconds instead of 10
2019-11-11 16:41:50 +00:00
Dylan K. Taylor
8d2e3894ef
DataPacket: fixed var_dump() not showing private & protected subclass properties
2019-11-11 15:41:08 +00:00
Encritary
7276eda0e5
Moved SetTitlePacket usage to NetworkSession ( #3186 )
2019-11-09 19:56:06 +00:00
Dylan K. Taylor
92700b2e18
phpstan.neon: remove error patterns that don't occur on 4.0
2019-11-09 18:10:53 +00:00
Dylan K. Taylor
c16337a80f
Merge branch 'stable' with changes
2019-11-09 18:01:04 +00:00
Dylan K. Taylor
025cb73bf5
update travis pthreads
2019-11-09 17:34:04 +00:00
