489a1470dc
Merge commit 'c22576a2668af4fb90d06f11d8b188a40d004832'
2020-01-18 18:16:04 +00:00
987e69bf1b
Merge commit 'bac788fd00f02ca17591c8c34deae420defefc36'
2020-01-18 18:15:26 +00:00
a79021a83a
Merge commit 'f6d96c58276bffe20d2444eeb5f4a638b0d78c02'
2020-01-18 18:15:00 +00:00
48a9e2a7ae
Merge commit '2d2c9379cd482938026d65a6d6df8bcac0af30e9'
2020-01-18 18:14:15 +00:00
cd5b32c5b2
Merge commit '3400771770f820bd0936234d7081b1408afb18a8'
2020-01-18 18:12:40 +00:00
f97bdf64d9
Merge commit 'e12ecaf62960dfc71871520e52787589447346ee'
2020-01-18 18:11:53 +00:00
be821ea15e
Merge commit '1303cbfe02bb6b5d36700f01f6b478a9be760470'
2020-01-18 18:10:32 +00:00
7762b73647
Merge commit 'd9bbab54f4608954a8ac0fffa88c2f32c07669f1'
2020-01-18 18:07:45 +00:00
c22576a266
CrashDump: add void native return types to private methods
2020-01-17 13:55:38 +00:00
bac788fd00
Timezone: add missing return type for detectSystemTimezone()
2020-01-15 20:18:35 +00:00
00869e81ba
NetworkBinaryStream: fix server crash on wrong skindata size, close #3276
2020-01-15 19:48:25 +00:00
f6d96c5827
DataPacket: clean() returns $this, not void
2020-01-14 17:30:48 +00:00
b1458db47b
Revert "CraftingDataPacket: fixed trying to return void result of parent function"
...
This reverts commit e12ecaf629
2020-01-14 17:16:17 +00:00
2d2c9379cd
DataPacket: apply @return void annotations to make phpstan happy
...
this eliminates 250+ errors on level 6.
2020-01-14 15:39:07 +00:00
3400771770
DataPacket: add missing return type info for pid()
2020-01-14 15:38:24 +00:00
e12ecaf629
CraftingDataPacket: fixed trying to return void result of parent function
2020-01-14 15:37:06 +00:00
1303cbfe02
UUID: add some missing return type annotations
2020-01-14 15:35:46 +00:00
ad4a211cba
Color: add missing return type annotation for fromABGR()
2020-01-14 15:35:14 +00:00
d1e56c4611
Location: add missing return types for getYaw() and getPitch()
2020-01-14 15:34:40 +00:00
d9bbab54f4
Entity: fixing position and velocity sync on start/stop movement, closes #3133
...
the delta for velocity sync is WAYYYYYY too big, but that's a task for another commit.
2020-01-14 13:08:38 +00:00
07cf4eb7a9
Revert "Create .sonarcloud.properties"
...
This reverts commit 50a7663369
2020-01-13 21:46:38 -06:00
50a7663369
Create .sonarcloud.properties
2020-01-13 21:31:36 -06:00
a4b810977a
Merge commit '651ef500a3be530f5bf1f72990c711706eab3ca7'
2020-01-13 19:29:38 +00:00
f2f4715d97
Merge commit '30f2e7527818e3275ceb0ff26093c4f26a84c51c'
2020-01-13 19:17:54 +00:00
0e1cea043a
added some phpstan-specific generic type annotations
2020-01-13 15:05:02 +00:00
acaa34785f
Merge commit '2cfc25b4f8f084c155a871934a10cc9010b05f7d'
2020-01-13 11:02:01 +00:00
724ce2a674
Merge commit '5bded9cff86e7814af34b9799953685bdc88240e'
2020-01-13 11:00:45 +00:00
651ef500a3
Make pocketmine\PATH and pocketmine\RESOURCE_PATH always available
...
these are non-dependent on environment, so they can be determined with no external input.
This fixes 2 PHPStan issues, fixes some code that couldn't run outside of PM, and makes it easier to write code that depends on PM.
2020-01-13 10:55:54 +00:00
30f2e75278
phpstan 0.12.5
2020-01-12 16:57:43 +00:00
2cfc25b4f8
phpstan: enable checkGenericClassInNonGenericObjectType
2020-01-11 23:04:16 +00:00
5bded9cff8
AttributeMap: add phpstan generic parameters for ArrayAccess
2020-01-11 23:03:21 +00:00
eba246eab3
SignText: provide typeinfo for checkLineIndex
2020-01-11 22:39:42 +00:00
9c06c1a06f
Merge branch 'stable'
2020-01-11 22:36:57 +00:00
56a459ccee
updated composer dependencies
2020-01-11 22:13:07 +00:00
5816ff85ba
don't depend on phpstan 0.12.4 phpdoc inheriting
...
this causes build failure because the parameter names are different to
the base class.
2020-01-11 22:08:16 +00:00
8f7d8347ee
update pocketmine/spl dependency
2020-01-11 22:05:37 +00:00
3614d9a78d
phpstan: enable MissingMethodParameterTypehintRule
2020-01-11 21:54:42 +00:00
818d0e19ab
RCONInstance: remove always-false branch (readPacket() never returns null)
2020-01-11 21:54:03 +00:00
17720041a3
phpdoc: populate missing parameter typeinfo
2020-01-11 21:53:24 +00:00
9c8095b0b4
Merge branch 'stable'
2020-01-11 21:51:17 +00:00
c329ff7d4f
SubChunk: remove nonsensical reference from internal function
2020-01-11 21:49:33 +00:00
96b91af66a
Merge branch 'stable'
2020-01-11 21:41:38 +00:00
8794292788
remove &$var reference notations in phpdoc
...
this isn't required by the spec and PHPStan chokes on it. I was previously having it ignore these errors, but it turns out that PHPStan is not making use of extended typeinfo provided if it can't parse the tag, which is problematic on level 6 and also a problem for array-of-type. Therefore, we are going to have to take the hit.
2020-01-11 21:20:55 +00:00
43601e57bf
Merge branch 'stable'
2020-01-09 21:08:16 +00:00
0a39e580e9
MainLogger: log exception chains in logException(), closes #2447
...
this method is simpler than #2447 and easier to apply to stable.
2020-01-09 21:01:12 +00:00
c4580dd56d
MainLogger: extract a printErrorMessage() function from logException()
2020-01-09 20:51:13 +00:00
fab81d28bc
MainLogger: always log exceptions with CRITICAL level
...
if we reached this point, it's almost always due to a general exception handler which doesn't know what else to do with the error.
2020-01-09 20:44:21 +00:00
05a450df87
Merge branch 'stable'
2020-01-09 20:16:17 +00:00
039478223e
phpstan: enable MissingFunctionReturnTypehintRule
2020-01-09 20:14:15 +00:00
64b5db4bf2
bootstrap: add some @return annotations for phpstan
2020-01-09 20:13:53 +00:00
