Dylan K. Taylor
3e1ac66abf
Merge branch 'stable'
2021-02-02 13:46:29 +00:00
Dylan K. Taylor
bd303b1062
RegionLoader: fixed flaky region header validation since 3.17.3
2021-02-02 13:43:52 +00:00
Dylan K. Taylor
fe731b9018
Added failing test case for region header validation
...
fucking PHP... what genius thought it was a good idea to cache file stats without even an attempt at keeping the cache up to date on modifications?
2021-02-02 13:43:12 +00:00
Dylan K. Taylor
1a24afc6d1
InventoryTransaction: Fixed indexes persisting from balance calculation in crafting input/outputs
...
fixes #4019
the order of the actual items may not be the same across runs, but index 0 will at least be sure to exist.
2021-02-02 00:13:58 +00:00
Dylan K. Taylor
bef906b0f0
phpstan 0.12.71
2021-02-02 00:05:53 +00:00
yuko fuyutsuki
37e8dd6444
Fix PHP 8 optional before required parameters deprecation warnings ( #4016 )
2021-01-31 12:08:47 +00:00
Dylan T
02ee0f23c0
Removed old support requests configuration
2021-01-27 22:53:37 +00:00
Dylan T
cda472333c
Add workflow for dessant/support-requests
...
we're using the legacy github app right now.
2021-01-27 22:47:33 +00:00
Dylan K. Taylor
02a4f0a170
Mark metadata as nullable in resource pack manifest data
...
if the metadata isn't provided, it won't be initialized during decoding.
2021-01-27 22:05:43 +00:00
Dylan K. Taylor
5a1131d72d
Populator: require dependencies explicitly, don't make bad assumptions about fields
...
this also leaks ChunkManagers on the worker threads because the generator context is long-lived.
2021-01-27 21:08:46 +00:00
Dylan K. Taylor
47cf58be8a
phpstan 0.12.70
2021-01-27 20:11:37 +00:00
Dylan K. Taylor
bbae02264d
Merge branch 'stable'
2021-01-27 20:04:13 +00:00
dependabot-preview[bot]
ccf9691927
Bump phpunit/phpunit from 9.5.0 to 9.5.1 ( #4010 )
2021-01-27 19:28:36 +00:00
Dylan K. Taylor
16fa958416
phpstan: better hack for any-callable parameters
...
variadics are a bad fit for this because what we really need is to accept callable with any number of arguments. LSP requires that the provided number of arguments must be >= than the required number of arguments.
2021-01-27 19:25:28 +00:00
Dylan K. Taylor
bac57c159f
Player: fix bridging, towering and various other fast building bugs
...
clickPos is relative to the base block position, so if you keep aiming at the same spot on the block and jump, it thinks you're still spamming.
closes #2730
2021-01-27 00:11:14 +00:00
Dylan K. Taylor
38b2d83799
MemoryManager: fixed protected properties being dumped multiple times
...
we don't need to scan the parent classes for anything other than private properties, because protected and public properties will appear on the main reflection as if they were declared directly as such.
2021-01-26 20:32:23 +00:00
Dylan K. Taylor
5384e2ba9d
Revert "MemoryDump: fixed duplicated properties, reduce useless noise"
...
This reverts commit efd67a132ed432b47a74c8b98211597557c419d5.
2021-01-26 20:26:35 +00:00
Dylan T
c134b1cd8a
[ci skip] README: add some badges
2021-01-26 17:34:05 +00:00
Dylan K. Taylor
269a389a97
BlockTransaction: added phpstan return type info for getBlocks()
2021-01-25 18:04:42 +00:00
Dylan K. Taylor
62deafda48
CommandReader: removed readline support
...
readline has been borked for a long time and it's not thread safe.
2021-01-25 17:53:25 +00:00
Dylan K. Taylor
31b6df4376
3.17.4 is next
2021-01-25 17:15:43 +00:00
Dylan K. Taylor
b296ae1b87
Release 3.17.3
2021-01-25 17:15:31 +00:00
Dylan K. Taylor
f9e42b716a
Scrub PHPStan baselines
...
these are now always generated with level 8.
2021-01-24 20:31:22 +00:00
Dylan K. Taylor
34c1d455a7
phpstan: enable checkMissingCallableSignature
2021-01-24 20:27:53 +00:00
Dylan K. Taylor
af8936dba5
phpstan 0.12.69
2021-01-24 20:14:42 +00:00
Dylan K. Taylor
74902d9926
[ci skip] changelog: mention InventoryPickupItemEvent->getItemEntity() rename
2021-01-21 13:58:08 +00:00
Dylan K. Taylor
2064b411f2
fix build
2021-01-20 22:53:51 +00:00
Dylan K. Taylor
69a829db91
Merge remote-tracking branch 'origin/stable'
2021-01-20 22:16:44 +00:00
SalmonDE
3fb4b30742
InventoryPickupItemEvent: rename item to itemEntity ( #4007 )
2021-01-20 21:09:59 +00:00
Dylan K. Taylor
e8ffab1787
RegionLoader: avoid hitting the disk twice during chunk reads
...
this provides some performance improvement (although it's difficult to measure because of cache).
this does mean that we read some garbage data during chunk reads, but it's less costly than hitting the disk twice.
2021-01-20 21:05:44 +00:00
Dylan K. Taylor
ecc1e1f698
RegionLoader: improve performance of region header validation
...
I was unaware that fseek actually makes a syscall which is rather costly, which became painfully obvious during large world conversions on PM4.
On average this problem appeared to be adding about 5ms to the load time for a newly loaded region, which is insanely expensive.
2021-01-20 20:04:21 +00:00
Dylan K. Taylor
487b5dd11d
Merge branch 'stable'
2021-01-16 19:44:15 +00:00
Dylan K. Taylor
ea5931e274
Updated build/php submodule to pmmp/php-build-scripts@60194e8b14
2021-01-16 19:34:06 +00:00
Dylan K. Taylor
988cf7f535
Fixed PHP 8.0 deprecation error
2021-01-16 19:31:07 +00:00
Dylan T
e156fb47e8
Disable xdebug on Actions
2021-01-15 21:09:45 +00:00
Dylan T
efc5f34877
wrong place ... when shared defaults :(
2021-01-15 17:53:39 +00:00
Dylan K. Taylor
dd0d8842d5
actions: disable fail-fast
2021-01-15 17:35:27 +00:00
Dylan K. Taylor
7bdc564ccc
Update first-party dependencies to PHP 8.0 compatible versions
...
all deps of PM3 are ready (at least as far as PHPStan can show).
2021-01-15 16:59:51 +00:00
Dylan K. Taylor
69fff23f1a
LevelProviderManager: removed bogus @var
...
I'm not sure why this wasn't detected until 0.12.67...
2021-01-15 16:53:49 +00:00
Dylan K. Taylor
ae43698e88
phpstan 0.12.67
...
for some reason dependabot shit itself while trying to scan for updates and thought this wasn't updatable ...
2021-01-15 16:53:49 +00:00
Dylan K. Taylor
a9f8afa077
Banner: remove Deque usages
...
originally I introduced this to make it easier to implement the various APIs addPattern removePattern etc, but those were later removed in favour of simple getPatterns() and setPatterns(), allowing plugin developers to use ext-ds APIs to manipulate patterns.
However, ds poses a number of headaches because of mutability combined with by-ref semantics, which make it a pain to use these on the APIs because we can't guarantee that they won't be modified.
As much as arrays suck, they have two significant advantages over ext-ds: 1) they have copy-on-write semantics, and 2) they support PHP 8.0 without any extra work from me.
2021-01-15 00:17:56 +00:00
dependabot-preview[bot]
0987e03c03
Bump phpstan/phpstan-strict-rules from 0.12.8 to 0.12.9 ( #4003 )
2021-01-13 10:55:54 +00:00
Dylan K. Taylor
4c0d3d68af
Bump PHP requirement to 7.4.0
2021-01-12 21:53:41 +00:00
Dylan K. Taylor
bbe9c01b46
Merge branch 'stable'
...
# Conflicts:
# composer.lock
# resources/vanilla
# src/pocketmine/metadata/MetadataStore.php
# src/pocketmine/scheduler/AsyncTask.php
# tests/phpstan/configs/actual-problems.neon
2021-01-12 21:48:24 +00:00
Dylan K. Taylor
97c124edf9
thanks git, this just sneaked in without any questions ................
2021-01-12 21:43:34 +00:00
Dylan K. Taylor
56501178b7
Updated composer dependencies
2021-01-12 21:41:25 +00:00
Dylan K. Taylor
120b224e41
Updated composer dependencies
2021-01-12 21:34:04 +00:00
Dylan K. Taylor
a90f8601d4
[ci skip] changelog: fixed typo
2021-01-12 21:29:23 +00:00
Dylan K. Taylor
c70c0b55df
Separate held item index change listener logic from PlayerInventory
2021-01-12 16:44:25 +00:00
dependabot-preview[bot]
da663deea1
Bump phpstan/phpstan from 0.12.65 to 0.12.66 ( #4001 )
2021-01-12 10:41:59 +00:00
