Dylan K. Taylor
269231c228
Ban foreach(arrayWithStringKeys as k => v)
...
this is not as good as phpstan/phpstan-src#769 (e.g. array_key_first()/array_key_last() aren't covered by this, nor is array_rand()) but it does eliminate the most infuriating cases where this usually crops up.
2021-11-15 22:52:05 +00:00
Dylan K. Taylor
4c07078586
Merge branch 'stable'
2021-11-08 19:01:08 +00:00
Dylan K. Taylor
eb3530b6e6
Use pmmp/setup-php-action to compile PHP
2021-11-07 23:13:56 +00:00
Dylan K. Taylor
b84f7c18ec
Install ext/crypto from PECL
2021-11-07 19:18:09 +00:00
Dylan K. Taylor
4c3a5fdd73
Clean PHPStan baselines from 1.0.2
2021-11-04 19:28:52 +00:00
Dylan K. Taylor
84f8b3eb2d
Move CrashDump to pocketmine\crash namespace
2021-11-04 19:23:45 +00:00
Dylan K. Taylor
15fca84f3b
remove some PHPStan error patterns
2021-11-04 19:22:49 +00:00
Dylan K. Taylor
c60144210f
Regenerate PHPStan bugs baseline
2021-11-04 19:18:29 +00:00
Dylan K. Taylor
729f831b8f
PHPStan 1.0.2
2021-11-03 20:26:32 +00:00
Dylan K. Taylor
54442f7e4b
Merge branch 'stable'
2021-11-01 21:18:35 +00:00
Dylan K. Taylor
5257755dc5
shut
2021-11-01 21:15:58 +00:00
Dylan K. Taylor
8c16ecaa5b
Merge branch 'stable'
2021-11-01 21:08:32 +00:00
Dylan K. Taylor
3214da8642
pthreads 4.0.0
2021-11-01 21:01:59 +00:00
Dylan K. Taylor
f827a555d5
Merge branch 'stable'
2021-11-01 18:13:24 +00:00
Dylan K. Taylor
794142fe49
Merge l7/l8/l9 baselines into actual-problems
...
it doesn't serve any practical purpose to keep these separated, particularly since it's getting so difficult to figure out which errors are coming from which levels (since we always use 9, it doesn't really make any difference).
2021-11-01 17:27:31 +00:00
Dylan K. Taylor
ff27c5f7db
PHPStan 1.0.0
2021-11-01 17:24:20 +00:00
Dylan K. Taylor
1873457840
PopulationTask: stop using dynamic properties
2021-10-26 20:21:58 +01:00
Dylan K. Taylor
1d99cd329a
CS again
2021-10-26 00:50:43 +01:00
Dylan K. Taylor
bd8cba1a7f
Added unit tests for Utils::testValidInstance()
2021-10-26 00:49:41 +01:00
Dylan K. Taylor
baba25953f
Chunk: make all parameters of __construct() mandatory and non-nullable
...
having the constructor fill in defaults for these invariably causes bugs.
2021-10-25 20:22:50 +01:00
Dylan K. Taylor
e50072dc27
Clean PHPStan baselines
2021-10-23 01:55:10 +01:00
Dylan T
a788954551
Fixed dependency handling across plugin loaders ( #3971 )
2021-10-20 20:22:00 +01:00
Dylan K. Taylor
8db5732b44
Drop respect/validation
...
it's not worth this turning into compatibility baggage just so that we can parse plugin_list.yml, especially when we have new ways to handle data parsing coming in the pipeline.
For something as small as plugin_list.yml, it's easier (and in this case better too) to just validate it manually (respect/validation was anyway too strict considering it's YAML we're dealing with).
2021-10-15 17:15:46 +01:00
Dylan K. Taylor
48f809d3fa
Removed another dead PHPStan error pattern
...
this was actually a PHPStan bug fixed in 0.12.99.
2021-10-15 17:01:09 +01:00
Dylan K. Taylor
06e7338ff9
Move exception printing utilities from MainLogger to Utils
...
where they can be useful to other stuff apart from just the logger
2021-10-14 15:54:20 +01:00
Dylan K. Taylor
b5699679ef
Merge commit 'e38866c4ba90f8efd5630dbe674fd7ca15f586ff'
2021-10-12 23:23:27 +01:00
IceCruelStuff
49c1e4c06e
Implement fletching table ( #4501 )
2021-10-12 21:21:05 +01:00
Dylan K. Taylor
62f11360ee
Added unit tests for getAddableItemQuantity()
2021-10-11 21:52:27 +01:00
Dylan K. Taylor
974d08efd6
Bump PHP minimum requirement to 8.0
...
PHPStan failed on 7.4 after updating to 0.12.99, and I figured it was less hassle to just do this than fix the build. In any case, we stopped shipping 7.4 months ago, and warned at 3.22 release that 7.4 support would soon be dropped.
2021-10-09 20:09:42 +01:00
Dylan K. Taylor
e38866c4ba
phpstan 0.12.99
2021-10-09 19:33:43 +01:00
Dylan K. Taylor
2a3a57c519
Enable parsing/emitting .properties without creating a Config object
...
this is useful when the contents are just going to get passed straight into a model, making Config object redundant anyway.
2021-10-07 20:53:15 +01:00
Dylan K. Taylor
dc2e8e7e8f
ServerConfigGroup: do not assume that values are always bool|string
2021-10-07 20:02:21 +01:00
Dylan K. Taylor
4b00465e24
Clean PHPStan baselines
2021-10-06 02:14:30 +01:00
Dylan K. Taylor
356a49d225
NetworkSession: account for possibility of syncGameMode() being called before the player is ready to receive it
...
close #4323
2021-10-04 22:13:42 +01:00
Dylan K. Taylor
f9e6fd44bc
Merge branch 'stable'
...
it looks like I goofed up the last merge and the changelog didn't get
merged into master.
2021-10-02 20:18:06 +01:00
Dylan K. Taylor
2566123e49
Remove unnecessary constant from PHPStan bootstrap
2021-10-02 16:34:38 +01:00
Dylan K. Taylor
c6b2c63a9b
Remove a couple more dead errors from PHPStan baseline
2021-10-02 00:52:47 +01:00
Dylan K. Taylor
32f8b8163e
Clean out PHPStan l7 baseline
2021-10-01 22:19:36 +01:00
Dylan K. Taylor
5b818827db
Chunk: stop exposing SplFixedArray<SubChunk> to the API
...
this fixes a large number of PHPStan errors, and also brings us a step closer to negative-build-height readiness.
2021-10-01 22:17:28 +01:00
Dylan K. Taylor
a11cf8c296
Update PHP versions used by GitHub Actions
2021-09-28 20:52:40 +01:00
Dylan K. Taylor
352162a6e6
Fixed PHP 7.4 build
2021-09-22 00:50:00 +01:00
Dylan K. Taylor
b3601c9390
Regenerate PHPStan baselines
2021-09-22 00:45:07 +01:00
Dylan K. Taylor
33a7c05425
Updated PHPStan baselines
2021-09-11 23:12:43 +01:00
Dylan K. Taylor
3b7580688c
Stop auto-translating string descriptions/usages for commands
...
Require usage of Translatable for translations.
2021-09-11 16:46:40 +01:00
Dylan K. Taylor
34f01a3ce3
World: Track entities separately from chunks
...
this allows entities to exist outside of generated chunks, with one caveat: they won't be saved in such cases.
Obviously, for player entities, this doesn't matter.
fixes #3947
2021-09-09 01:17:41 +01:00
Dylan K. Taylor
627c70c4df
actions: use chunkutils2 0.3.1
2021-09-07 22:55:50 +01:00
Dylan K. Taylor
dd4abe7f7a
Updated test
2021-09-07 12:27:24 +01:00
Dylan K. Taylor
df3b112877
Implemented slime blocks
2021-09-05 20:46:59 +01:00
Dylan K. Taylor
aa5a9f6d12
Enchantment: use Translatable instead of hardcoded translation keys
2021-09-03 20:52:05 +01:00
Dylan K. Taylor
668df85e3f
Merge branch 'stable'
2021-08-20 23:08:17 +01:00
