mirrors/PocketMine-MP
1
0
Fork 0
mirror of https://github.com/pmmp/PocketMine-MP.git synced 2025-04-20 16:00:20 +00:00
Code Issues Projects Releases Wiki Activity

Stop auto-translating string descriptions/usages for commands

Browse Source 
Require usage of Translatable for translations.
This commit is contained in:
Dylan K. Taylor 2021-09-11 16:46:40 +01:00
parent b65e3c69b1
commit 3b7580688c
No known key found for this signature in database
GPG Key ID: 8927471A91CAFD3D
43 changed files with 104 additions and 131 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
src/command/Command.php
View File

@ -58,10 +58,10 @@ abstract class Command{
/** @var CommandMap|null */
private $commandMap = null;
/** @var string */
/** @var Translatable|string */
protected $description = "";
/** @var string */
/** @var Translatable|string */
protected $usageMessage;
/** @var string|null */
@ -76,7 +76,7 @@ abstract class Command{
/**
* @param string[] $aliases
*/
public function __construct(string $name, string $description = "", ?string $usageMessage = null, array $aliases = []){
public function __construct(string $name, Translatable|string $description = "", Translatable|string|null $usageMessage = null, array $aliases = []){
$this->name = $name;
$this->setLabel($name);
$this->setDescription($description);
@ -200,11 +200,11 @@ abstract class Command{
return $this->permissionMessage;
}
public function getDescription() : string{
public function getDescription() : Translatable|string{
return $this->description;
}
public function getUsage() : string{
public function getUsage() : Translatable|string{
return $this->usageMessage;
}
@ -218,7 +218,7 @@ abstract class Command{
}
}
public function setDescription(string $description) : void{
public function setDescription(Translatable|string $description) : void{
$this->description = $description;
}
@ -226,7 +226,7 @@ abstract class Command{
$this->permissionMessage = $permissionMessage;
}
public function setUsage(string $usage) : void{
public function setUsage(Translatable|string $usage) : void{
$this->usageMessage = $usage;
}

2
src/command/SimpleCommandMap.php
View File

@ -224,7 +224,7 @@ class SimpleCommandMap implements CommandMap{
try{
$target->execute($sender, $sentCommandLabel, $args);
}catch(InvalidCommandSyntaxException $e){
$sender->sendMessage($sender->getLanguage()->translate(KnownTranslationFactory::commands_generic_usage($sender->getLanguage()->translateString($target->getUsage()))));
$sender->sendMessage($sender->getLanguage()->translate(KnownTranslationFactory::commands_generic_usage($target->getUsage())));
}finally{
$target->timings->stopTiming();
}

5
src/command/defaults/BanCommand.php
View File

@ -27,7 +27,6 @@ use pocketmine\command\Command;
use pocketmine\command\CommandSender;
use pocketmine\command\utils\InvalidCommandSyntaxException;
use pocketmine\lang\KnownTranslationFactory;
use pocketmine\lang\KnownTranslationKeys;
use pocketmine\permission\DefaultPermissionNames;
use pocketmine\player\Player;
use function array_shift;
@ -39,8 +38,8 @@ class BanCommand extends VanillaCommand{
public function __construct(string $name){
parent::__construct(
$name,
KnownTranslationKeys::POCKETMINE_COMMAND_BAN_PLAYER_DESCRIPTION,
KnownTranslationKeys::COMMANDS_BAN_USAGE
KnownTranslationFactory::pocketmine_command_ban_player_description(),
KnownTranslationFactory::commands_ban_usage()
);
$this->setPermission(DefaultPermissionNames::COMMAND_BAN_PLAYER);
}

5
src/command/defaults/BanIpCommand.php
View File

@ -27,7 +27,6 @@ use pocketmine\command\Command;
use pocketmine\command\CommandSender;
use pocketmine\command\utils\InvalidCommandSyntaxException;
use pocketmine\lang\KnownTranslationFactory;
use pocketmine\lang\KnownTranslationKeys;
use pocketmine\permission\DefaultPermissionNames;
use pocketmine\player\Player;
use function array_shift;
@ -40,8 +39,8 @@ class BanIpCommand extends VanillaCommand{
public function __construct(string $name){
parent::__construct(
$name,
KnownTranslationKeys::POCKETMINE_COMMAND_BAN_IP_DESCRIPTION,
KnownTranslationKeys::COMMANDS_BANIP_USAGE
KnownTranslationFactory::pocketmine_command_ban_ip_description(),
KnownTranslationFactory::commands_banip_usage()
);
$this->setPermission(DefaultPermissionNames::COMMAND_BAN_IP);
}

5
src/command/defaults/BanListCommand.php
View File

@ -26,7 +26,6 @@ namespace pocketmine\command\defaults;
use pocketmine\command\CommandSender;
use pocketmine\command\utils\InvalidCommandSyntaxException;
use pocketmine\lang\KnownTranslationFactory;
use pocketmine\lang\KnownTranslationKeys;
use pocketmine\permission\BanEntry;
use pocketmine\permission\DefaultPermissionNames;
use function array_map;
@ -41,8 +40,8 @@ class BanListCommand extends VanillaCommand{
public function __construct(string $name){
parent::__construct(
$name,
KnownTranslationKeys::POCKETMINE_COMMAND_BANLIST_DESCRIPTION,
KnownTranslationKeys::COMMANDS_BANLIST_USAGE
KnownTranslationFactory::pocketmine_command_banlist_description(),
KnownTranslationFactory::commands_banlist_usage()
);
$this->setPermission(DefaultPermissionNames::COMMAND_BAN_LIST);
}

5
src/command/defaults/ClearCommand.php
View File

@ -30,7 +30,6 @@ use pocketmine\item\LegacyStringToItemParser;
use pocketmine\item\LegacyStringToItemParserException;
use pocketmine\item\StringToItemParser;
use pocketmine\lang\KnownTranslationFactory;
use pocketmine\lang\KnownTranslationKeys;
use pocketmine\permission\DefaultPermissionNames;
use pocketmine\player\Player;
use pocketmine\utils\TextFormat;
@ -43,8 +42,8 @@ class ClearCommand extends VanillaCommand{
public function __construct(string $name){
parent::__construct(
$name,
KnownTranslationKeys::POCKETMINE_COMMAND_CLEAR_DESCRIPTION,
KnownTranslationKeys::POCKETMINE_COMMAND_CLEAR_USAGE
KnownTranslationFactory::pocketmine_command_clear_description(),
KnownTranslationFactory::pocketmine_command_clear_usage()
);
$this->setPermission(implode(";", [DefaultPermissionNames::COMMAND_CLEAR_SELF, DefaultPermissionNames::COMMAND_CLEAR_OTHER]));
}

5
src/command/defaults/DefaultGamemodeCommand.php
View File

@ -27,7 +27,6 @@ use pocketmine\command\CommandSender;
use pocketmine\command\utils\InvalidCommandSyntaxException;
use pocketmine\data\java\GameModeIdMap;
use pocketmine\lang\KnownTranslationFactory;
use pocketmine\lang\KnownTranslationKeys;
use pocketmine\permission\DefaultPermissionNames;
use pocketmine\player\GameMode;
use function count;
@ -37,8 +36,8 @@ class DefaultGamemodeCommand extends VanillaCommand{
public function __construct(string $name){
parent::__construct(
$name,
KnownTranslationKeys::POCKETMINE_COMMAND_DEFAULTGAMEMODE_DESCRIPTION,
KnownTranslationKeys::COMMANDS_DEFAULTGAMEMODE_USAGE
KnownTranslationFactory::pocketmine_command_defaultgamemode_description(),
KnownTranslationFactory::commands_defaultgamemode_usage()
);
$this->setPermission(DefaultPermissionNames::COMMAND_DEFAULTGAMEMODE);
}

5
src/command/defaults/DeopCommand.php
View File

@ -27,7 +27,6 @@ use pocketmine\command\Command;
use pocketmine\command\CommandSender;
use pocketmine\command\utils\InvalidCommandSyntaxException;
use pocketmine\lang\KnownTranslationFactory;
use pocketmine\lang\KnownTranslationKeys;
use pocketmine\permission\DefaultPermissionNames;
use pocketmine\player\Player;
use pocketmine\utils\TextFormat;
@ -39,8 +38,8 @@ class DeopCommand extends VanillaCommand{
public function __construct(string $name){
parent::__construct(
$name,
KnownTranslationKeys::POCKETMINE_COMMAND_DEOP_DESCRIPTION,
KnownTranslationKeys::COMMANDS_DEOP_USAGE
KnownTranslationFactory::pocketmine_command_deop_description(),
KnownTranslationFactory::commands_deop_usage()
);
$this->setPermission(DefaultPermissionNames::COMMAND_OP_TAKE);
}

5
src/command/defaults/DifficultyCommand.php
View File

@ -27,7 +27,6 @@ use pocketmine\command\Command;
use pocketmine\command\CommandSender;
use pocketmine\command\utils\InvalidCommandSyntaxException;
use pocketmine\lang\KnownTranslationFactory;
use pocketmine\lang\KnownTranslationKeys;
use pocketmine\permission\DefaultPermissionNames;
use pocketmine\world\World;
use function count;
@ -37,8 +36,8 @@ class DifficultyCommand extends VanillaCommand{
public function __construct(string $name){
parent::__construct(
$name,
KnownTranslationKeys::POCKETMINE_COMMAND_DIFFICULTY_DESCRIPTION,
KnownTranslationKeys::COMMANDS_DIFFICULTY_USAGE
KnownTranslationFactory::pocketmine_command_difficulty_description(),
KnownTranslationFactory::commands_difficulty_usage()
);
$this->setPermission(DefaultPermissionNames::COMMAND_DIFFICULTY);
}

5
src/command/defaults/EffectCommand.php
View File

@ -28,7 +28,6 @@ use pocketmine\command\utils\InvalidCommandSyntaxException;
use pocketmine\entity\effect\EffectInstance;
use pocketmine\entity\effect\VanillaEffects;
use pocketmine\lang\KnownTranslationFactory;
use pocketmine\lang\KnownTranslationKeys;
use pocketmine\permission\DefaultPermissionNames;
use pocketmine\utils\Limits;
use pocketmine\utils\TextFormat;
@ -40,8 +39,8 @@ class EffectCommand extends VanillaCommand{
public function __construct(string $name){
parent::__construct(
$name,
KnownTranslationKeys::POCKETMINE_COMMAND_EFFECT_DESCRIPTION,
KnownTranslationKeys::COMMANDS_EFFECT_USAGE
KnownTranslationFactory::pocketmine_command_effect_description(),
KnownTranslationFactory::commands_effect_usage()
);
$this->setPermission(DefaultPermissionNames::COMMAND_EFFECT);
}

5
src/command/defaults/EnchantCommand.php
View File

@ -28,7 +28,6 @@ use pocketmine\command\utils\InvalidCommandSyntaxException;
use pocketmine\item\enchantment\EnchantmentInstance;
use pocketmine\item\enchantment\VanillaEnchantments;
use pocketmine\lang\KnownTranslationFactory;
use pocketmine\lang\KnownTranslationKeys;
use pocketmine\permission\DefaultPermissionNames;
use pocketmine\utils\TextFormat;
use function count;
@ -38,8 +37,8 @@ class EnchantCommand extends VanillaCommand{
public function __construct(string $name){
parent::__construct(
$name,
KnownTranslationKeys::POCKETMINE_COMMAND_ENCHANT_DESCRIPTION,
KnownTranslationKeys::COMMANDS_ENCHANT_USAGE
KnownTranslationFactory::pocketmine_command_enchant_description(),
KnownTranslationFactory::commands_enchant_usage()
);
$this->setPermission(DefaultPermissionNames::COMMAND_ENCHANT);
}

5
src/command/defaults/GamemodeCommand.php
View File

@ -27,7 +27,6 @@ use pocketmine\command\Command;
use pocketmine\command\CommandSender;
use pocketmine\command\utils\InvalidCommandSyntaxException;
use pocketmine\lang\KnownTranslationFactory;
use pocketmine\lang\KnownTranslationKeys;
use pocketmine\permission\DefaultPermissionNames;
use pocketmine\player\GameMode;
use pocketmine\player\Player;
@ -39,8 +38,8 @@ class GamemodeCommand extends VanillaCommand{
public function __construct(string $name){
parent::__construct(
$name,
KnownTranslationKeys::POCKETMINE_COMMAND_GAMEMODE_DESCRIPTION,
KnownTranslationKeys::COMMANDS_GAMEMODE_USAGE
KnownTranslationFactory::pocketmine_command_gamemode_description(),
KnownTranslationFactory::commands_gamemode_usage()
);
$this->setPermission(DefaultPermissionNames::COMMAND_GAMEMODE);
}

5
src/command/defaults/GarbageCollectorCommand.php
View File

@ -25,7 +25,6 @@ namespace pocketmine\command\defaults;
use pocketmine\command\CommandSender;
use pocketmine\lang\KnownTranslationFactory;
use pocketmine\lang\KnownTranslationKeys;
use pocketmine\permission\DefaultPermissionNames;
use pocketmine\utils\TextFormat;
use function count;
@ -38,8 +37,8 @@ class GarbageCollectorCommand extends VanillaCommand{
public function __construct(string $name){
parent::__construct(
$name,
KnownTranslationKeys::POCKETMINE_COMMAND_GC_DESCRIPTION,
KnownTranslationKeys::POCKETMINE_COMMAND_GC_USAGE
KnownTranslationFactory::pocketmine_command_gc_description(),
KnownTranslationFactory::pocketmine_command_gc_usage()
);
$this->setPermission(DefaultPermissionNames::COMMAND_GC);
}

5
src/command/defaults/GiveCommand.php
View File

@ -30,7 +30,6 @@ use pocketmine\item\LegacyStringToItemParser;
use pocketmine\item\LegacyStringToItemParserException;
use pocketmine\item\StringToItemParser;
use pocketmine\lang\KnownTranslationFactory;
use pocketmine\lang\KnownTranslationKeys;
use pocketmine\nbt\JsonNbtParser;
use pocketmine\nbt\NbtDataException;
use pocketmine\permission\DefaultPermissionNames;
@ -44,8 +43,8 @@ class GiveCommand extends VanillaCommand{
public function __construct(string $name){
parent::__construct(
$name,
KnownTranslationKeys::POCKETMINE_COMMAND_GIVE_DESCRIPTION,
KnownTranslationKeys::POCKETMINE_COMMAND_GIVE_USAGE
KnownTranslationFactory::pocketmine_command_give_description(),
KnownTranslationFactory::pocketmine_command_give_usage()
);
$this->setPermission(DefaultPermissionNames::COMMAND_GIVE);
}

19
src/command/defaults/HelpCommand.php
View File

@ -26,7 +26,7 @@ namespace pocketmine\command\defaults;
use pocketmine\command\Command;
use pocketmine\command\CommandSender;
use pocketmine\lang\KnownTranslationFactory;
use pocketmine\lang\KnownTranslationKeys;
use pocketmine\lang\Translatable;
use pocketmine\permission\DefaultPermissionNames;
use pocketmine\utils\TextFormat;
use function array_chunk;
@ -46,8 +46,8 @@ class HelpCommand extends VanillaCommand{
public function __construct(string $name){
parent::__construct(
$name,
KnownTranslationKeys::POCKETMINE_COMMAND_HELP_DESCRIPTION,
KnownTranslationKeys::COMMANDS_HELP_USAGE,
KnownTranslationFactory::pocketmine_command_help_description(),
KnownTranslationFactory::commands_help_usage(),
["?"]
);
$this->setPermission(DefaultPermissionNames::COMMAND_HELP);
@ -92,7 +92,9 @@ class HelpCommand extends VanillaCommand{
$lang = $sender->getLanguage();
if(isset($commands[$pageNumber - 1])){
foreach($commands[$pageNumber - 1] as $command){
$sender->sendMessage(TextFormat::DARK_GREEN . "/" . $command->getName() . ": " . TextFormat::WHITE . $lang->translateString($command->getDescription()));
$description = $command->getDescription();
$descriptionString = $description instanceof Translatable ? $lang->translate($description) : $description;
$sender->sendMessage(TextFormat::DARK_GREEN . "/" . $command->getName() . ": " . TextFormat::WHITE . $descriptionString);
}
}
@ -100,9 +102,14 @@ class HelpCommand extends VanillaCommand{
}else{
if(($cmd = $sender->getServer()->getCommandMap()->getCommand(strtolower($commandName))) instanceof Command){
if($cmd->testPermissionSilent($sender)){
$lang = $sender->getLanguage();
$description = $cmd->getDescription();
$descriptionString = $description instanceof Translatable ? $lang->translate($description) : $description;
$message = TextFormat::YELLOW . "--------- " . TextFormat::WHITE . " Help: /" . $cmd->getName() . TextFormat::YELLOW . " ---------\n";
$message .= TextFormat::GOLD . "Description: " . TextFormat::WHITE . $sender->getLanguage()->translateString($cmd->getDescription()) . "\n";
$message .= TextFormat::GOLD . "Usage: " . TextFormat::WHITE . implode("\n" . TextFormat::WHITE, explode("\n", $sender->getLanguage()->translateString($cmd->getUsage()))) . "\n";
$message .= TextFormat::GOLD . "Description: " . TextFormat::WHITE . $descriptionString . "\n";
$usage = $cmd->getUsage();
$usageString = $usage instanceof Translatable ? $lang->translate($usage) : $usage;
$message .= TextFormat::GOLD . "Usage: " . TextFormat::WHITE . implode("\n" . TextFormat::WHITE, explode("\n", $usageString)) . "\n";
$sender->sendMessage($message);
return true;

5
src/command/defaults/KickCommand.php
View File

@ -27,7 +27,6 @@ use pocketmine\command\Command;
use pocketmine\command\CommandSender;
use pocketmine\command\utils\InvalidCommandSyntaxException;
use pocketmine\lang\KnownTranslationFactory;
use pocketmine\lang\KnownTranslationKeys;
use pocketmine\permission\DefaultPermissionNames;
use pocketmine\player\Player;
use pocketmine\utils\TextFormat;
@ -41,8 +40,8 @@ class KickCommand extends VanillaCommand{
public function __construct(string $name){
parent::__construct(
$name,
KnownTranslationKeys::POCKETMINE_COMMAND_KICK_DESCRIPTION,
KnownTranslationKeys::COMMANDS_KICK_USAGE
KnownTranslationFactory::pocketmine_command_kick_description(),
KnownTranslationFactory::commands_kick_usage()
);
$this->setPermission(DefaultPermissionNames::COMMAND_KICK);
}

5
src/command/defaults/KillCommand.php
View File

@ -28,7 +28,6 @@ use pocketmine\command\CommandSender;
use pocketmine\command\utils\InvalidCommandSyntaxException;
use pocketmine\event\entity\EntityDamageEvent;
use pocketmine\lang\KnownTranslationFactory;
use pocketmine\lang\KnownTranslationKeys;
use pocketmine\permission\DefaultPermissionNames;
use pocketmine\player\Player;
use pocketmine\utils\TextFormat;
@ -40,8 +39,8 @@ class KillCommand extends VanillaCommand{
public function __construct(string $name){
parent::__construct(
$name,
KnownTranslationKeys::POCKETMINE_COMMAND_KILL_DESCRIPTION,
KnownTranslationKeys::POCKETMINE_COMMAND_KILL_USAGE,
KnownTranslationFactory::pocketmine_command_kill_description(),
KnownTranslationFactory::pocketmine_command_kill_usage(),
["suicide"]
);
$this->setPermission(implode(";", [DefaultPermissionNames::COMMAND_KILL_SELF, DefaultPermissionNames::COMMAND_KILL_OTHER]));

5
src/command/defaults/ListCommand.php
View File

@ -25,7 +25,6 @@ namespace pocketmine\command\defaults;
use pocketmine\command\CommandSender;
use pocketmine\lang\KnownTranslationFactory;
use pocketmine\lang\KnownTranslationKeys;
use pocketmine\permission\DefaultPermissionNames;
use pocketmine\player\Player;
use function array_filter;
@ -40,8 +39,8 @@ class ListCommand extends VanillaCommand{
public function __construct(string $name){
parent::__construct(
$name,
KnownTranslationKeys::POCKETMINE_COMMAND_LIST_DESCRIPTION,
KnownTranslationKeys::COMMANDS_PLAYERS_USAGE
KnownTranslationFactory::pocketmine_command_list_description(),
KnownTranslationFactory::commands_players_usage()
);
$this->setPermission(DefaultPermissionNames::COMMAND_LIST);
}

5
src/command/defaults/MeCommand.php
View File

@ -26,7 +26,6 @@ namespace pocketmine\command\defaults;
use pocketmine\command\CommandSender;
use pocketmine\command\utils\InvalidCommandSyntaxException;
use pocketmine\lang\KnownTranslationFactory;
use pocketmine\lang\KnownTranslationKeys;
use pocketmine\permission\DefaultPermissionNames;
use pocketmine\player\Player;
use pocketmine\utils\TextFormat;
@ -38,8 +37,8 @@ class MeCommand extends VanillaCommand{
public function __construct(string $name){
parent::__construct(
$name,
KnownTranslationKeys::POCKETMINE_COMMAND_ME_DESCRIPTION,
KnownTranslationKeys::COMMANDS_ME_USAGE
KnownTranslationFactory::pocketmine_command_me_description(),
KnownTranslationFactory::commands_me_usage()
);
$this->setPermission(DefaultPermissionNames::COMMAND_ME);
}

5
src/command/defaults/OpCommand.php
View File

@ -27,7 +27,6 @@ use pocketmine\command\Command;
use pocketmine\command\CommandSender;
use pocketmine\command\utils\InvalidCommandSyntaxException;
use pocketmine\lang\KnownTranslationFactory;
use pocketmine\lang\KnownTranslationKeys;
use pocketmine\permission\DefaultPermissionNames;
use pocketmine\player\Player;
use pocketmine\utils\TextFormat;
@ -39,8 +38,8 @@ class OpCommand extends VanillaCommand{
public function __construct(string $name){
parent::__construct(
$name,
KnownTranslationKeys::POCKETMINE_COMMAND_OP_DESCRIPTION,
KnownTranslationKeys::COMMANDS_OP_USAGE
KnownTranslationFactory::pocketmine_command_op_description(),
KnownTranslationFactory::commands_op_usage()
);
$this->setPermission(DefaultPermissionNames::COMMAND_OP_GIVE);
}

5
src/command/defaults/PardonCommand.php
View File

@ -27,7 +27,6 @@ use pocketmine\command\Command;
use pocketmine\command\CommandSender;
use pocketmine\command\utils\InvalidCommandSyntaxException;
use pocketmine\lang\KnownTranslationFactory;
use pocketmine\lang\KnownTranslationKeys;
use pocketmine\permission\DefaultPermissionNames;
use function count;
@ -36,8 +35,8 @@ class PardonCommand extends VanillaCommand{
public function __construct(string $name){
parent::__construct(
$name,
KnownTranslationKeys::POCKETMINE_COMMAND_UNBAN_PLAYER_DESCRIPTION,
KnownTranslationKeys::COMMANDS_UNBAN_USAGE,
KnownTranslationFactory::pocketmine_command_unban_player_description(),
KnownTranslationFactory::commands_unban_usage(),
["unban"]
);
$this->setPermission(DefaultPermissionNames::COMMAND_UNBAN_PLAYER);

5
src/command/defaults/PardonIpCommand.php
View File

@ -27,7 +27,6 @@ use pocketmine\command\Command;
use pocketmine\command\CommandSender;
use pocketmine\command\utils\InvalidCommandSyntaxException;
use pocketmine\lang\KnownTranslationFactory;
use pocketmine\lang\KnownTranslationKeys;
use pocketmine\permission\DefaultPermissionNames;
use function count;
use function preg_match;
@ -37,8 +36,8 @@ class PardonIpCommand extends VanillaCommand{
public function __construct(string $name){
parent::__construct(
$name,
KnownTranslationKeys::POCKETMINE_COMMAND_UNBAN_IP_DESCRIPTION,
KnownTranslationKeys::COMMANDS_UNBANIP_USAGE,
KnownTranslationFactory::pocketmine_command_unban_ip_description(),
KnownTranslationFactory::commands_unbanip_usage(),
["unban-ip"]
);
$this->setPermission(DefaultPermissionNames::COMMAND_UNBAN_IP);

5
src/command/defaults/ParticleCommand.php
View File

@ -30,7 +30,6 @@ use pocketmine\command\utils\InvalidCommandSyntaxException;
use pocketmine\item\ItemFactory;
use pocketmine\item\VanillaItems;
use pocketmine\lang\KnownTranslationFactory;
use pocketmine\lang\KnownTranslationKeys;
use pocketmine\math\Vector3;
use pocketmine\permission\DefaultPermissionNames;
use pocketmine\player\Player;
@ -79,8 +78,8 @@ class ParticleCommand extends VanillaCommand{
public function __construct(string $name){
parent::__construct(
$name,
KnownTranslationKeys::POCKETMINE_COMMAND_PARTICLE_DESCRIPTION,
KnownTranslationKeys::POCKETMINE_COMMAND_PARTICLE_USAGE
KnownTranslationFactory::pocketmine_command_particle_description(),
KnownTranslationFactory::pocketmine_command_particle_usage()
);
$this->setPermission(DefaultPermissionNames::COMMAND_PARTICLE);
}

5
src/command/defaults/PluginsCommand.php
View File

@ -25,7 +25,6 @@ namespace pocketmine\command\defaults;
use pocketmine\command\CommandSender;
use pocketmine\lang\KnownTranslationFactory;
use pocketmine\lang\KnownTranslationKeys;
use pocketmine\permission\DefaultPermissionNames;
use pocketmine\plugin\Plugin;
use pocketmine\utils\TextFormat;
@ -40,8 +39,8 @@ class PluginsCommand extends VanillaCommand{
public function __construct(string $name){
parent::__construct(
$name,
KnownTranslationKeys::POCKETMINE_COMMAND_PLUGINS_DESCRIPTION,
KnownTranslationKeys::POCKETMINE_COMMAND_PLUGINS_USAGE,
KnownTranslationFactory::pocketmine_command_plugins_description(),
KnownTranslationFactory::pocketmine_command_plugins_usage(),
["pl"]
);
$this->setPermission(DefaultPermissionNames::COMMAND_PLUGINS);

5
src/command/defaults/SaveCommand.php
View File

@ -26,7 +26,6 @@ namespace pocketmine\command\defaults;
use pocketmine\command\Command;
use pocketmine\command\CommandSender;
use pocketmine\lang\KnownTranslationFactory;
use pocketmine\lang\KnownTranslationKeys;
use pocketmine\permission\DefaultPermissionNames;
use function microtime;
use function round;
@ -36,8 +35,8 @@ class SaveCommand extends VanillaCommand{
public function __construct(string $name){
parent::__construct(
$name,
KnownTranslationKeys::POCKETMINE_COMMAND_SAVE_DESCRIPTION,
KnownTranslationKeys::COMMANDS_SAVE_USAGE
KnownTranslationFactory::pocketmine_command_save_description(),
KnownTranslationFactory::commands_save_usage()
);
$this->setPermission(DefaultPermissionNames::COMMAND_SAVE_PERFORM);
}

5
src/command/defaults/SaveOffCommand.php
View File

@ -26,7 +26,6 @@ namespace pocketmine\command\defaults;
use pocketmine\command\Command;
use pocketmine\command\CommandSender;
use pocketmine\lang\KnownTranslationFactory;
use pocketmine\lang\KnownTranslationKeys;
use pocketmine\permission\DefaultPermissionNames;
class SaveOffCommand extends VanillaCommand{
@ -34,8 +33,8 @@ class SaveOffCommand extends VanillaCommand{
public function __construct(string $name){
parent::__construct(
$name,
KnownTranslationKeys::POCKETMINE_COMMAND_SAVEOFF_DESCRIPTION,
KnownTranslationKeys::COMMANDS_SAVE_OFF_USAGE
KnownTranslationFactory::pocketmine_command_saveoff_description(),
KnownTranslationFactory::commands_save_off_usage()
);
$this->setPermission(DefaultPermissionNames::COMMAND_SAVE_DISABLE);
}

5
src/command/defaults/SaveOnCommand.php
View File

@ -26,7 +26,6 @@ namespace pocketmine\command\defaults;
use pocketmine\command\Command;
use pocketmine\command\CommandSender;
use pocketmine\lang\KnownTranslationFactory;
use pocketmine\lang\KnownTranslationKeys;
use pocketmine\permission\DefaultPermissionNames;
class SaveOnCommand extends VanillaCommand{
@ -34,8 +33,8 @@ class SaveOnCommand extends VanillaCommand{
public function __construct(string $name){
parent::__construct(
$name,
KnownTranslationKeys::POCKETMINE_COMMAND_SAVEON_DESCRIPTION,
KnownTranslationKeys::COMMANDS_SAVE_ON_USAGE
KnownTranslationFactory::pocketmine_command_saveon_description(),
KnownTranslationFactory::commands_save_on_usage()
);
$this->setPermission(DefaultPermissionNames::COMMAND_SAVE_ENABLE);
}

5
src/command/defaults/SayCommand.php
View File

@ -27,7 +27,6 @@ use pocketmine\command\CommandSender;
use pocketmine\command\utils\InvalidCommandSyntaxException;
use pocketmine\console\ConsoleCommandSender;
use pocketmine\lang\KnownTranslationFactory;
use pocketmine\lang\KnownTranslationKeys;
use pocketmine\permission\DefaultPermissionNames;
use pocketmine\player\Player;
use pocketmine\utils\TextFormat;
@ -39,8 +38,8 @@ class SayCommand extends VanillaCommand{
public function __construct(string $name){
parent::__construct(
$name,
KnownTranslationKeys::POCKETMINE_COMMAND_SAY_DESCRIPTION,
KnownTranslationKeys::COMMANDS_SAY_USAGE
KnownTranslationFactory::pocketmine_command_say_description(),
KnownTranslationFactory::commands_say_usage()
);
$this->setPermission(DefaultPermissionNames::COMMAND_SAY);
}

5
src/command/defaults/SeedCommand.php
View File

@ -25,7 +25,6 @@ namespace pocketmine\command\defaults;
use pocketmine\command\CommandSender;
use pocketmine\lang\KnownTranslationFactory;
use pocketmine\lang\KnownTranslationKeys;
use pocketmine\permission\DefaultPermissionNames;
use pocketmine\player\Player;
@ -34,8 +33,8 @@ class SeedCommand extends VanillaCommand{
public function __construct(string $name){
parent::__construct(
$name,
KnownTranslationKeys::POCKETMINE_COMMAND_SEED_DESCRIPTION,
KnownTranslationKeys::COMMANDS_SEED_USAGE
KnownTranslationFactory::pocketmine_command_seed_description(),
KnownTranslationFactory::commands_seed_usage()
);
$this->setPermission(DefaultPermissionNames::COMMAND_SEED);
}

5
src/command/defaults/SetWorldSpawnCommand.php
View File

@ -27,7 +27,6 @@ use pocketmine\command\Command;
use pocketmine\command\CommandSender;
use pocketmine\command\utils\InvalidCommandSyntaxException;
use pocketmine\lang\KnownTranslationFactory;
use pocketmine\lang\KnownTranslationKeys;
use pocketmine\math\Vector3;
use pocketmine\permission\DefaultPermissionNames;
use pocketmine\player\Player;
@ -40,8 +39,8 @@ class SetWorldSpawnCommand extends VanillaCommand{
public function __construct(string $name){
parent::__construct(
$name,
KnownTranslationKeys::POCKETMINE_COMMAND_SETWORLDSPAWN_DESCRIPTION,
KnownTranslationKeys::COMMANDS_SETWORLDSPAWN_USAGE
KnownTranslationFactory::pocketmine_command_setworldspawn_description(),
KnownTranslationFactory::commands_setworldspawn_usage()
);
$this->setPermission(DefaultPermissionNames::COMMAND_SETWORLDSPAWN);
}

5
src/command/defaults/SpawnpointCommand.php
View File

@ -27,7 +27,6 @@ use pocketmine\command\Command;
use pocketmine\command\CommandSender;
use pocketmine\command\utils\InvalidCommandSyntaxException;
use pocketmine\lang\KnownTranslationFactory;
use pocketmine\lang\KnownTranslationKeys;
use pocketmine\permission\DefaultPermissionNames;
use pocketmine\player\Player;
use pocketmine\utils\TextFormat;
@ -41,8 +40,8 @@ class SpawnpointCommand extends VanillaCommand{
public function __construct(string $name){
parent::__construct(
$name,
KnownTranslationKeys::POCKETMINE_COMMAND_SPAWNPOINT_DESCRIPTION,
KnownTranslationKeys::COMMANDS_SPAWNPOINT_USAGE
KnownTranslationFactory::pocketmine_command_spawnpoint_description(),
KnownTranslationFactory::commands_spawnpoint_usage()
);
$this->setPermission(DefaultPermissionNames::COMMAND_SPAWNPOINT);
}

6
src/command/defaults/StatusCommand.php
View File

@ -24,7 +24,7 @@ declare(strict_types=1);
namespace pocketmine\command\defaults;
use pocketmine\command\CommandSender;
use pocketmine\lang\KnownTranslationKeys;
use pocketmine\lang\KnownTranslationFactory;
use pocketmine\permission\DefaultPermissionNames;
use pocketmine\utils\Process;
use pocketmine\utils\TextFormat;
@ -39,8 +39,8 @@ class StatusCommand extends VanillaCommand{
public function __construct(string $name){
parent::__construct(
$name,
KnownTranslationKeys::POCKETMINE_COMMAND_STATUS_DESCRIPTION,
KnownTranslationKeys::POCKETMINE_COMMAND_STATUS_USAGE
KnownTranslationFactory::pocketmine_command_status_description(),
KnownTranslationFactory::pocketmine_command_status_usage()
);
$this->setPermission(DefaultPermissionNames::COMMAND_STATUS);
}

5
src/command/defaults/StopCommand.php
View File

@ -26,7 +26,6 @@ namespace pocketmine\command\defaults;
use pocketmine\command\Command;
use pocketmine\command\CommandSender;
use pocketmine\lang\KnownTranslationFactory;
use pocketmine\lang\KnownTranslationKeys;
use pocketmine\permission\DefaultPermissionNames;
class StopCommand extends VanillaCommand{
@ -34,8 +33,8 @@ class StopCommand extends VanillaCommand{
public function __construct(string $name){
parent::__construct(
$name,
KnownTranslationKeys::POCKETMINE_COMMAND_STOP_DESCRIPTION,
KnownTranslationKeys::COMMANDS_STOP_USAGE
KnownTranslationFactory::pocketmine_command_stop_description(),
KnownTranslationFactory::commands_stop_usage()
);
$this->setPermission(DefaultPermissionNames::COMMAND_STOP);
}

5
src/command/defaults/TeleportCommand.php
View File

@ -28,7 +28,6 @@ use pocketmine\command\CommandSender;
use pocketmine\command\utils\InvalidCommandSyntaxException;
use pocketmine\entity\Location;
use pocketmine\lang\KnownTranslationFactory;
use pocketmine\lang\KnownTranslationKeys;
use pocketmine\permission\DefaultPermissionNames;
use pocketmine\player\Player;
use pocketmine\utils\AssumptionFailedError;
@ -42,8 +41,8 @@ class TeleportCommand extends VanillaCommand{
public function __construct(string $name){
parent::__construct(
$name,
KnownTranslationKeys::POCKETMINE_COMMAND_TP_DESCRIPTION,
KnownTranslationKeys::COMMANDS_TP_USAGE,
KnownTranslationFactory::pocketmine_command_tp_description(),
KnownTranslationFactory::commands_tp_usage(),
["teleport"]
);
$this->setPermission(DefaultPermissionNames::COMMAND_TELEPORT);

5
src/command/defaults/TellCommand.php
View File

@ -27,7 +27,6 @@ use pocketmine\command\Command;
use pocketmine\command\CommandSender;
use pocketmine\command\utils\InvalidCommandSyntaxException;
use pocketmine\lang\KnownTranslationFactory;
use pocketmine\lang\KnownTranslationKeys;
use pocketmine\permission\DefaultPermissionNames;
use pocketmine\player\Player;
use pocketmine\utils\TextFormat;
@ -40,8 +39,8 @@ class TellCommand extends VanillaCommand{
public function __construct(string $name){
parent::__construct(
$name,
KnownTranslationKeys::POCKETMINE_COMMAND_TELL_DESCRIPTION,
KnownTranslationKeys::COMMANDS_MESSAGE_USAGE,
KnownTranslationFactory::pocketmine_command_tell_description(),
KnownTranslationFactory::commands_message_usage(),
["w", "msg"]
);
$this->setPermission(DefaultPermissionNames::COMMAND_TELL);

5
src/command/defaults/TimeCommand.php
View File

@ -27,7 +27,6 @@ use pocketmine\command\Command;
use pocketmine\command\CommandSender;
use pocketmine\command\utils\InvalidCommandSyntaxException;
use pocketmine\lang\KnownTranslationFactory;
use pocketmine\lang\KnownTranslationKeys;
use pocketmine\permission\DefaultPermissionNames;
use pocketmine\player\Player;
use pocketmine\world\World;
@ -39,8 +38,8 @@ class TimeCommand extends VanillaCommand{
public function __construct(string $name){
parent::__construct(
$name,
KnownTranslationKeys::POCKETMINE_COMMAND_TIME_DESCRIPTION,
KnownTranslationKeys::POCKETMINE_COMMAND_TIME_USAGE
KnownTranslationFactory::pocketmine_command_time_description(),
KnownTranslationFactory::pocketmine_command_time_usage()
);
$this->setPermission(implode(";", [
DefaultPermissionNames::COMMAND_TIME_ADD,

5
src/command/defaults/TimingsCommand.php
View File

@ -27,7 +27,6 @@ use pocketmine\command\Command;
use pocketmine\command\CommandSender;
use pocketmine\command\utils\InvalidCommandSyntaxException;
use pocketmine\lang\KnownTranslationFactory;
use pocketmine\lang\KnownTranslationKeys;
use pocketmine\permission\DefaultPermissionNames;
use pocketmine\player\Player;
use pocketmine\scheduler\BulkCurlTask;
@ -60,8 +59,8 @@ class TimingsCommand extends VanillaCommand{
public function __construct(string $name){
parent::__construct(
$name,
KnownTranslationKeys::POCKETMINE_COMMAND_TIMINGS_DESCRIPTION,
KnownTranslationKeys::POCKETMINE_COMMAND_TIMINGS_USAGE
KnownTranslationFactory::pocketmine_command_timings_description(),
KnownTranslationFactory::pocketmine_command_timings_usage()
);
$this->setPermission(DefaultPermissionNames::COMMAND_TIMINGS);
}

5
src/command/defaults/TitleCommand.php
View File

@ -26,7 +26,6 @@ namespace pocketmine\command\defaults;
use pocketmine\command\CommandSender;
use pocketmine\command\utils\InvalidCommandSyntaxException;
use pocketmine\lang\KnownTranslationFactory;
use pocketmine\lang\KnownTranslationKeys;
use pocketmine\permission\DefaultPermissionNames;
use pocketmine\utils\TextFormat;
use function array_slice;
@ -38,8 +37,8 @@ class TitleCommand extends VanillaCommand{
public function __construct(string $name){
parent::__construct(
$name,
KnownTranslationKeys::POCKETMINE_COMMAND_TITLE_DESCRIPTION,
KnownTranslationKeys::COMMANDS_TITLE_USAGE
KnownTranslationFactory::pocketmine_command_title_description(),
KnownTranslationFactory::commands_title_usage()
);
$this->setPermission(DefaultPermissionNames::COMMAND_TITLE);
}

6
src/command/defaults/TransferServerCommand.php
View File

@ -25,7 +25,7 @@ namespace pocketmine\command\defaults;
use pocketmine\command\CommandSender;
use pocketmine\command\utils\InvalidCommandSyntaxException;
use pocketmine\lang\KnownTranslationKeys;
use pocketmine\lang\KnownTranslationFactory;
use pocketmine\permission\DefaultPermissionNames;
use pocketmine\player\Player;
use function count;
@ -35,8 +35,8 @@ class TransferServerCommand extends VanillaCommand{
public function __construct(string $name){
parent::__construct(
$name,
KnownTranslationKeys::POCKETMINE_COMMAND_TRANSFERSERVER_DESCRIPTION,
KnownTranslationKeys::POCKETMINE_COMMAND_TRANSFERSERVER_USAGE
KnownTranslationFactory::pocketmine_command_transferserver_description(),
KnownTranslationFactory::pocketmine_command_transferserver_usage()
);
$this->setPermission(DefaultPermissionNames::COMMAND_TRANSFERSERVER);
}

5
src/command/defaults/VersionCommand.php
View File

@ -25,7 +25,6 @@ namespace pocketmine\command\defaults;
use pocketmine\command\CommandSender;
use pocketmine\lang\KnownTranslationFactory;
use pocketmine\lang\KnownTranslationKeys;
use pocketmine\network\mcpe\protocol\ProtocolInfo;
use pocketmine\permission\DefaultPermissionNames;
use pocketmine\plugin\Plugin;
@ -46,8 +45,8 @@ class VersionCommand extends VanillaCommand{
public function __construct(string $name){
parent::__construct(
$name,
KnownTranslationKeys::POCKETMINE_COMMAND_VERSION_DESCRIPTION,
KnownTranslationKeys::POCKETMINE_COMMAND_VERSION_USAGE,
KnownTranslationFactory::pocketmine_command_version_description(),
KnownTranslationFactory::pocketmine_command_version_usage(),
["ver", "about"]
);
$this->setPermission(DefaultPermissionNames::COMMAND_VERSION);

5
src/command/defaults/WhitelistCommand.php
View File

@ -27,7 +27,6 @@ use pocketmine\command\Command;
use pocketmine\command\CommandSender;
use pocketmine\command\utils\InvalidCommandSyntaxException;
use pocketmine\lang\KnownTranslationFactory;
use pocketmine\lang\KnownTranslationKeys;
use pocketmine\permission\DefaultPermissionNames;
use pocketmine\player\Player;
use function count;
@ -41,8 +40,8 @@ class WhitelistCommand extends VanillaCommand{
public function __construct(string $name){
parent::__construct(
$name,
KnownTranslationKeys::POCKETMINE_COMMAND_WHITELIST_DESCRIPTION,
KnownTranslationKeys::COMMANDS_WHITELIST_USAGE
KnownTranslationFactory::pocketmine_command_whitelist_description(),
KnownTranslationFactory::commands_whitelist_usage()
);
$this->setPermission(implode(";", [
DefaultPermissionNames::COMMAND_WHITELIST_RELOAD,

4
src/network/mcpe/NetworkSession.php
View File

@ -35,6 +35,7 @@ use pocketmine\event\server\DataPacketSendEvent;
use pocketmine\form\Form;
use pocketmine\lang\KnownTranslationFactory;
use pocketmine\lang\KnownTranslationKeys;
use pocketmine\lang\Translatable;
use pocketmine\math\Vector3;
use pocketmine\nbt\tag\CompoundTag;
use pocketmine\nbt\tag\StringTag;
@ -832,9 +833,10 @@ class NetworkSession{
$aliasObj = new CommandEnum(ucfirst($command->getName()) . "Aliases", array_values($aliases));
}
$description = $command->getDescription();
$data = new CommandData(
$lname, //TODO: commands containing uppercase letters in the name crash 1.9.0 client
$this->player->getLanguage()->translateString($command->getDescription()),
$description instanceof Translatable ? $this->player->getLanguage()->translate($description) : $description,
0,
0,
$aliasObj,

4
tests/phpstan/configs/check-explicit-mixed-baseline.neon
View File

@ -81,7 +81,7 @@ parameters:
path: ../../../src/permission/PermissionParser.php
-
message: "#^Parameter \\#1 \\$description of method pocketmine\\\\command\\\\Command\\:\\:setDescription\\(\\) expects string, mixed given\\.$#"
message: "#^Parameter \\#1 \\$description of method pocketmine\\\\command\\\\Command\\:\\:setDescription\\(\\) expects pocketmine\\\\lang\\\\Translatable\\|string, mixed given\\.$#"
count: 1
path: ../../../src/plugin/PluginBase.php
@ -91,7 +91,7 @@ parameters:
path: ../../../src/plugin/PluginBase.php
-
message: "#^Parameter \\#1 \\$usage of method pocketmine\\\\command\\\\Command\\:\\:setUsage\\(\\) expects string, mixed given\\.$#"
message: "#^Parameter \\#1 \\$usage of method pocketmine\\\\command\\\\Command\\:\\:setUsage\\(\\) expects pocketmine\\\\lang\\\\Translatable\\|string, mixed given\\.$#"
count: 1
path: ../../../src/plugin/PluginBase.php