10838 Commits

Author SHA1 Message Date
Dylan K. Taylor
15f8886958 phpstan: separate non-PM bugs from the main neon config
everything left in here is now a PM problem that needs to be looked into.
2019-12-01 20:12:41 +00:00
Dylan K. Taylor
3226a9dc6a phpstan: ignore more optional-leveldb errors 2019-12-01 19:52:49 +00:00
Dylan K. Taylor
1a1e3ff63b BaseInventory: fixed incorrect & redundant default value for slots field 2019-12-01 19:45:16 +00:00
Dylan K. Taylor
ea413d0882 phpstan: analyze on level 2, close #3193 2019-12-01 19:32:03 +00:00
Dylan K. Taylor
0890b5fc99 AsyncPool: assert() that the unstacked task is actually an AsyncTask
it's possible that it might not be if the workers were accessed directly, but that shouldn't be possible.
This also silences a PHPStan warning on level 2.
2019-12-01 19:28:05 +00:00
Dylan K. Taylor
163ed225f2 NetworkBinaryStream: fixed crash when non-compound root tag is provided for itemstack 2019-12-01 18:41:02 +00:00
Dylan K. Taylor
a4a6d3e094 PlayerCreationEvent: fixed illegal doc comment types 2019-12-01 18:08:25 +00:00
Dylan K. Taylor
ecbf3e9722 GamemodeCommand: fix CommandSender assignment causing troubles for type inference on static analyzers
this would never crash, but in strongly typed code it would be a compile failure.
2019-12-01 09:33:12 +00:00
Dylan K. Taylor
47a959dace block: fix some possible crashes when plugins overwrite tile classes in bad ways
phpstan was complaining on level 2, and it's not wrong to ...
2019-12-01 09:29:22 +00:00
Dylan K. Taylor
3968f85c82 sync composer dependencies 2019-12-01 08:54:48 +00:00
Dylan K. Taylor
d8188b807a CraftingDataPacket: read & write potion recipes 2019-11-30 21:18:54 +00:00
Dylan K. Taylor
8e68655fc7 Merge branch 'stable' into drew-1.13 2019-11-30 21:15:50 +00:00
Dylan K. Taylor
6d109bfc6f CraftingDataPacket: fixed not retaining cleanRecipes during decode 2019-11-30 21:15:37 +00:00
Dylan K. Taylor
b7a5a53c9d MoveActorDeltaPacket: flags is now a short 2019-11-30 12:56:16 +00:00
Dylan K. Taylor
76bd0f452c AvailableCommandsPacket: add special handling for enums which aren't referenced by any command directly
the CommandName enum is a magic enum used by the  argtype.

TODO: It's possible that not sending the CommandName enum might be causing client sided crashes. Investigate.
2019-11-30 12:41:44 +00:00
Dylan K. Taylor
363556e9b6 AvailableCommandsPacket: encode & decode for enum value constraints
This is a peculiarly overengineered system that is used for restricting access to enum members under certain conditions, e.g. to disallow changing specific gamerules in survival.
2019-11-30 12:31:31 +00:00
Dylan K. Taylor
6f08853b29 Merge branch 'stable' into drew-1.13 2019-11-30 12:04:46 +00:00
Dylan K. Taylor
42d8357821 AvailableCommandsPacket: fixed missing decoded overloads with 0 arguments
these should be listed even if they have 0 arguments
2019-11-30 11:58:29 +00:00
Dylan K. Taylor
0bff5d9bff sync composer deps 2019-11-29 20:20:13 +00:00
Dylan K. Taylor
994781494f Merge branch 'next-minor' 2019-11-29 12:06:27 +00:00
Dylan K. Taylor
4cfceeeb8e bootstrap: fix merge error introduced by cb76f8a5dfba79857ecfd71d2953b759a03671e7
this error is harmless since it points to a deprecated function, but it showed up as conflicted in master merge.
2019-11-29 12:03:07 +00:00
Dylan K. Taylor
8ee3d4486a update build/php submodule to pmmp/php-build-scripts@7e985c932a 2019-11-29 11:56:36 +00:00
Dylan K. Taylor
3e4e0d51df Merge branch 'stable' into next-minor 2019-11-29 11:55:12 +00:00
Dylan K. Taylor
f2ac63d235 update build/php submodule to pmmp/php-build-scripts@8308571448 2019-11-29 11:54:42 +00:00
Stephen
5d17405b92 Better checks on resource patch 2019-11-28 19:48:34 -05:00
Stephen
3dd53ad998 Remove offset for crafting grid 2019-11-28 19:42:34 -05:00
Stephen
a303c4b294 Add some isset checks to prevent server from crashing on an invalid resourcepatch 2019-11-21 17:58:33 -05:00
Stephen
fa56290bb4 Reflect StartGamePacket changes in Player 2019-11-21 15:05:09 -05:00
Stephen
01d6cbe9c3 Added : void typehint to SkinAdapterSingleton & provide documentation 2019-11-21 15:01:34 -05:00
Stephen
f682c16740 Changed eduMode to eduEditionOffer and added an unsignedVarInt in availablecommandspacket 2019-11-21 14:55:29 -05:00
Stephen
74c09dc202 Remove inline assignment 2019-11-21 14:49:01 -05:00
Stephen
0917b67573 Generate param docs for constructor 2019-11-21 14:46:10 -05:00
Stephen
5cb0eafcb2 Should be checking the string, not an object 2019-11-21 14:24:47 -05:00
Stephen
221e6db47d Remove persona capes off of classic skins, add checks for empty cape data when converting 2019-11-21 14:21:08 -05:00
Stephen
8d06018d81 make toSkinData return statement multi lined 2019-11-21 13:54:22 -05:00
Stephen
600e16d9f6 Fixed floatingtextparticle yet again 2019-11-21 13:54:00 -05:00
Stephen
4340349db7 Generate getters for SkinData, applied suggested change, and fixed an underfined variable in PlayerListPacket 2019-11-21 13:52:27 -05:00
SOFe
cb76f8a5df
Merge branch 'stable' into next-minor 2019-11-21 23:21:16 +08:00
Stephen
6105198313 Update AvailableCommandsPacket constants 2019-11-20 22:47:48 -05:00
Stephen
c96ba13c23 Extract geometry name from resource patch 2019-11-20 22:42:56 -05:00
Stephen
c8d0cb315b Move persona skin hack to legacyskinadapter 2019-11-20 21:52:49 -05:00
Stephen
be9c413a9e Added network components for skins, to collect instead of throw out data 2019-11-20 21:43:41 -05:00
Dylan T
3e4366b30d
readme: add XLM since Keybase made it so easy
... and also gave lots of keybase users free XLM. Well played, Keybase, you managed to make me adopt Stellar.
2019-11-20 10:51:07 +00:00
Stephen
7f3460190b
Merge pull request #5 from dktapps/drew-1.13
more 1.13
2019-11-12 14:19:31 -05:00
Dylan K. Taylor
10d44292e1 fix classic capes 2019-11-12 12:27:50 -05:00
Dylan K. Taylor
70f81334ae MultiplayerSettingsPacket 2019-11-12 11:58:40 -05:00
Dylan K. Taylor
ead572fab9 fix skin sharing stupidity 2019-11-12 07:08:48 -05:00
Dylan K. Taylor
ef8e286277 Merge branch 'stable' of https://github.com/drew-mcbe/pocketmine-mp into drew-1.13 2019-11-12 06:57:57 -05:00
Dylan T
ba5a5981a0
Update Player.php 2019-11-12 08:19:05 +00:00
Dylan K. Taylor
c428596009 AddPlayerPacket: missing field 2019-11-11 16:36:55 -05:00