12 Commits

Author	SHA1	Message	Date
Dylan K. Taylor	0a7d81a2b0	FastChunkSerializer: retain emptyBlock on subchunks ... I think we should probably get rid of this considering the potential for inconsistencies within a chunk, but not retaining this is a bug nonetheless, even though it doesn't have any effect in PM itself since we always use BlockLegacyIds << 4 as the empty block ID. so, this is only really aiding (ab)use cases which weren't intended anyway ...	2020-11-27 13:41:35 +00:00
Dylan K. Taylor	4e94025b3b	SubChunk: rename defaultBlock -> emptyBlockId ... this better describes the purpose, which is to identify air. though, it might make more sense to make air just always have zero as air's runtime ID, since this parameter is apparently making plugin devs think that this is suitable to fill a chunk with a specific block ...	2020-11-27 13:33:25 +00:00
Dylan K. Taylor	315962c12c	Added __clone() for Chunk and SubChunk ... we need this because the flatworld generator uses clone to produce new chunks, so we don't want the chunks getting fucked up.	2020-11-01 16:14:25 +00:00
Dylan K. Taylor	e09d78238f	Removed EmptySubChunk and SubChunkInterface	2020-10-31 23:10:31 +00:00
Dylan K. Taylor	0fd3d91038	LightArray: hide constants ZERO and FIFTEEN from the API ... this makes it easier to implement this in C++ with the same API. Since the C++ version doesn't use strings, these constants aren't needed anyway.	2020-09-08 15:13:58 +01:00
Dylan K. Taylor	aac7da6c96	eliminate remaining empty() usages	2020-02-07 21:51:50 +00:00
Dylan K. Taylor	ff63f6d055	fill in more iterable types (master)	2020-02-01 20:19:57 +00:00
Dylan K. Taylor	67bcc1c0fb	phpdoc armageddon for master, pass 1	2020-01-22 11:55:03 +00:00
Dylan K. Taylor	3ee6887792	populate remaining missing return types, using native returns where possible ... this is done separately to stable so that stable changes can be integrated easily using an empty merge.	2020-01-19 10:26:35 +00:00
Dylan K. Taylor	02ff8d671b	Mostly phase out EmptySubChunk ... copy-on-write and zero-layer SubChunk objects are much easier to manage and have less cognitive overhead. obviously, the goal is to get rid of EmptySubChunk completely, but right now it does still serve a purpose (filling in dummy values for reading out-of-bounds on chunks), and that's a problem that takes a little more work to fix.	2019-10-22 23:00:49 +01:00
Dylan K. Taylor	514f395280	SubChunk: reduce visibility of blockLight and skyLight fields	2019-08-10 19:47:41 +01:00
Dylan K. Taylor	5499ac620c	Removed pocketmine subdirectory, map PSR-4 style	2019-07-30 19:14:57 +01:00