099562d582
Utils: assume explicitly that ob_get_contents() will not return false in getReferenceCount() based on context
2020-04-15 12:10:21 +01:00
ae76e8f08f
Utils: fix some implicit casts to boolean on result of preg_match_all()
2020-04-15 12:09:10 +01:00
42a08e7e4a
Utils: don't assume that callable is only array|string implicitly
...
this should really support closures too, but since it's not used anywhere, I feel OK with this change.
2020-04-15 12:08:33 +01:00
b193d9f919
Process: shut up PHPStan about possible float returns on getMemoryUsage and friends
...
this can never actually happen because the given data sources will never have such large numbers, but PHPStan doesn't know this.
2020-04-15 12:07:24 +01:00
24d64eedab
Process: make some assumptions about I/O explicit for type safety
2020-04-15 12:05:13 +01:00
0c9d16f1ef
Internet: explicitly assume return of curl_exec() is string after error checking
...
this is documented as string|bool, but it's actually string|false if CURLOPT_RETURNTRANSFER is set, and bool if not.
2020-04-15 12:02:38 +01:00
d246933e3e
TextFormat: account for failure to encode JSON in toJSON()
2020-04-15 11:29:50 +01:00
41d7b8c0e4
TextFormat: properly handle pcre errors in some cases
...
these would previously just hit type errors.
2020-04-15 11:29:04 +01:00
2622c34542
Terminal: explicitly assume that fopen(stdin) will not fail
2020-04-15 11:12:03 +01:00
5c9419b55c
Timezone: use false checks instead of file existing for static analysis
2020-04-15 10:59:36 +01:00
83c40f4502
Timezone: properly account for failure to read timezone file
2020-04-15 10:23:07 +01:00
372202b3dc
Utils: use type-safe checks to ensure file validity
...
this gives the same results while keeping phpstan happy.
2020-04-15 10:19:51 +01:00
917c744266
Properly handle error conditions in Utils::decodeJWT()
2020-04-15 10:18:02 +01:00
2281fe4e67
Account for reflection filename being false (in the case of classes/functions defined by builtins)
2020-04-15 10:15:38 +01:00
cf538d83bf
Timezone: shut phpstan up about impossible ini_get() errors
2020-04-15 09:48:20 +01:00
7e9c38a9d9
Timezone::parseOffset() returns string|false, not string|bool
2020-04-15 09:47:52 +01:00
ccad97727f
UUID: properly account for garbage inputs which aren't valid hexadecimal
...
this would previously throw a TypeError and crash.
2020-04-15 09:44:14 +01:00
e3ebf8bb61
Internet::getIP() returns string|false, not string|bool
2020-04-15 09:39:38 +01:00
cb6b59a52a
Internet: curl_init() may return false on error (unclear on reasons)
2020-04-15 09:38:39 +01:00
53dbbd5f97
Internet: account for socket_create() maybe failing in getInternalIP()
2020-04-15 09:37:17 +01:00
51908ec45a
Player: allow provision of a custom cooldown duration for items
...
this would be more useful to plugins, so that it's not necessary to extend any item classes for this trivial purpose.
2020-04-15 09:32:48 +01:00
a2543ff80d
Position: add getLevelNonNull()
...
this allows assuming that a position has a valid world in places where it's never expected to not be valid. Since this is the vast majority of usages, it eliminates a lot of possible null-pointer warnings given by static analysers.
TODO: Consider whether we can make Position->getLevel/World use this behaviour out of the box in the next major version.
2020-04-14 11:08:37 +01:00
6e08b622b3
Merge branch 'stable' into next-minor
2020-04-14 01:43:23 +01:00
5c12a95151
phpstan: force static reflection for COM class
...
com_dotnet has crap reflection exports and the class name case doesn't match.
2020-04-14 01:43:02 +01:00
604900d4c5
Merge branch 'stable' into next-minor
2020-04-14 01:38:01 +01:00
5f07c5df1c
Bump irstea/phpunit-shim from 8.5.2 to 8.5.3 ( #3384 )
2020-04-12 03:40:14 +00:00
6422ed7722
Added RakLibInterface::setPacketLimit() ( #3398 )
2020-04-11 23:27:17 +01:00
5f33ef35e3
build: allow providing a git hash
2020-04-09 21:13:54 +01:00
ec949840b2
Do not crash on failure to decompress region chunks
...
this could happen when a chunk was partially overwritten with one of the same sector size.
2020-04-01 21:30:25 +01:00
e45e84b236
Updated composer dependencies
2020-03-31 18:43:30 +01:00
dfe68c9788
Bump phpstan/phpstan from 0.12.17 to 0.12.18 ( #3372 )
...
Bumps [phpstan/phpstan](https://github.com/phpstan/phpstan ) from 0.12.17 to 0.12.18.
- [Release notes](https://github.com/phpstan/phpstan/releases )
- [Commits](https://github.com/phpstan/phpstan/compare/0.12.17...0.12.18 )
Signed-off-by: dependabot-preview[bot] <support@dependabot.com >
Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
2020-03-23 15:21:00 +00:00
35b8f0bf25
Bump phpstan/phpstan from 0.12.15 to 0.12.17 ( #3363 )
2020-03-18 13:06:14 +00:00
d4dc1c8a0c
AttributeMap: be aware of possible NULL offset in ArrayAccess
...
reported by phpstan 0.12.17
2020-03-18 12:59:01 +00:00
517f9a3c3a
Player: fix weapons not taking damage from attacks (bug introduced by #3348 )
2020-03-18 12:51:05 +00:00
636c35dcf1
replace daverandom/callback-validator with pocketmine/callback-validator, closes #3359
2020-03-17 12:24:50 +00:00
d22f0da1de
Bump phpstan/phpstan from 0.12.14 to 0.12.15 ( #3362 )
2020-03-17 12:20:55 +00:00
310de5a2b2
RCON: set SO_REUSEADDR to fix RCON start failure after restart ( #3357 )
2020-03-16 12:00:45 +00:00
06a9c98ded
MemoryManager: fix strict-rules error on phpstan level 7
2020-03-15 15:49:04 +00:00
5c7b05c2ba
CrashDump: do not assign possibly-false return value of fopen() directly to non-union field
...
this would become a problem with typed properties, and also phpstan level 7 doesn't like it.
2020-03-15 15:48:09 +00:00
9c86763322
CrashDump: do not assume that error_get_last() always returns array
...
this returns NULL if there was no error before the shutdown handler was triggered (usually caused by a plugin calling exit() prematurely).
2020-03-15 15:47:07 +00:00
35490ca41c
CrashDump: do not assume that file() always returns array
...
phpstan level 7 prep
2020-03-15 15:46:03 +00:00
47c7872c88
Merge branch 'stable' into next-minor
2020-03-14 13:42:39 +00:00
f84abcd1fe
sync composer.lock with 0dd68e587f
2020-03-14 13:36:35 +00:00
b5dd147ec7
PlayerQuitEvent: fix types of quitMessage
2020-03-14 13:24:40 +00:00
f8ce01e2fd
ItemFactory: extract fromStringSingle() from fromString()
...
on PM4, the multiple functionality is removed, but on PM3 this is a problem for phpstan.
2020-03-13 17:54:25 +00:00
3907a2b6ba
Process: split getMemoryUsage() into 2 functions
...
this isn't released yet so it's OK to change.
phpstan level 7 doesn't like these kinds of ambiguous return types because there's no way for it to tell which type is returned without a return type specifying extension, and it's easier to just change the API than to make PHPStan understand it.
2020-03-13 17:32:17 +00:00
0dd68e587f
require phpstan ^0.12.14 (for incremental analysis)
2020-03-13 16:30:35 +00:00
1171cd2493
Merge branch 'stable' into next-minor
2020-03-13 15:16:42 +00:00
330e93e5e3
Player: do not handle inbound ActorEvents that are not for self
2020-03-13 15:15:20 +00:00
e2579e0a2a
Merge branch 'stable' into next-minor
2020-03-12 11:47:33 +00:00
