mirrors/PocketMine-MP
1
0
Fork 0
mirror of https://github.com/pmmp/PocketMine-MP.git synced 2025-07-13 13:25:16 +00:00
Code Issues Projects Releases Wiki Activity

InventoryManager: avoid calling TypeConverter::getInstance() in a loop

Browse Source
This commit is contained in:
Dylan K. Taylor 2023-03-20 23:24:52 +00:00
parent ee72e80fbb
commit ecc830a689
No known key found for this signature in database
GPG Key ID: 8927471A91CAFD3D
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
src/network/mcpe/InventoryManager.php
View File

@ -479,8 +479,9 @@ class InventoryManager{
$entry->predictions = []; $entry->predictions = [];
$entry->pendingSyncs = []; $entry->pendingSyncs = [];
$contents = []; $contents = [];
$typeConverter = TypeConverter::getInstance();
foreach($inventory->getContents(true) as $slot => $item){ foreach($inventory->getContents(true) as $slot => $item){
$itemStack = TypeConverter::getInstance()->coreItemStackToNet($item); $itemStack = $typeConverter->coreItemStackToNet($item);
$info = $this->trackItemStack($entry, $slot, $itemStack, null); $info = $this->trackItemStack($entry, $slot, $itemStack, null);
$contents[] = new ItemStackWrapper($info->getStackId(), $itemStack); $contents[] = new ItemStackWrapper($info->getStackId(), $itemStack);
} }