From ecc830a689df326ab88497de438657c8673c8b07 Mon Sep 17 00:00:00 2001 From: "Dylan K. Taylor" Date: Mon, 20 Mar 2023 23:24:52 +0000 Subject: [PATCH] InventoryManager: avoid calling TypeConverter::getInstance() in a loop --- src/network/mcpe/InventoryManager.php | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/network/mcpe/InventoryManager.php b/src/network/mcpe/InventoryManager.php index 5aa22b002..0222d6d40 100644 --- a/src/network/mcpe/InventoryManager.php +++ b/src/network/mcpe/InventoryManager.php @@ -479,8 +479,9 @@ class InventoryManager{ $entry->predictions = []; $entry->pendingSyncs = []; $contents = []; + $typeConverter = TypeConverter::getInstance(); foreach($inventory->getContents(true) as $slot => $item){ - $itemStack = TypeConverter::getInstance()->coreItemStackToNet($item); + $itemStack = $typeConverter->coreItemStackToNet($item); $info = $this->trackItemStack($entry, $slot, $itemStack, null); $contents[] = new ItemStackWrapper($info->getStackId(), $itemStack); }