mirrors/PocketMine-MP
1
0
Fork 0
mirror of https://github.com/pmmp/PocketMine-MP.git synced 2025-05-13 01:09:44 +00:00
Code Issues Projects Releases Wiki Activity

PrepareEncryptionTask: do not store onCompletion as a field

Browse Source 
pthreads will screw around with it and make it do things it's not supposed to, which is the exact reason why we have thread-local storage to begin with.
This commit is contained in:
Dylan K. Taylor 2020-05-06 13:32:18 +01:00
parent ff53ddd3ad
commit e392a6a807
1 changed files with 0 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/network/mcpe/encryption/PrepareEncryptionTask.php
View File

@ -45,11 +45,6 @@ class PrepareEncryptionTask extends AsyncTask{
private $handshakeJwt = null; private $handshakeJwt = null;
/** @var PublicKeyInterface */ /** @var PublicKeyInterface */
private $clientPub; private $clientPub;
/**
* @var \Closure
* @phpstan-var \Closure(string $encryptionKey, string $handshakeJwt) : void
*/
private $onCompletion;
/** /**
* @phpstan-param \Closure(string $encryptionKey, string $handshakeJwt) : void $onCompletion * @phpstan-param \Closure(string $encryptionKey, string $handshakeJwt) : void $onCompletion
@ -62,7 +57,6 @@ class PrepareEncryptionTask extends AsyncTask{
$this->serverPrivateKey = self::$SERVER_PRIVATE_KEY; $this->serverPrivateKey = self::$SERVER_PRIVATE_KEY;
$this->clientPub = $clientPub; $this->clientPub = $clientPub;
$this->storeLocal(self::TLS_KEY_ON_COMPLETION, $onCompletion); $this->storeLocal(self::TLS_KEY_ON_COMPLETION, $onCompletion);
$this->onCompletion = $onCompletion;
} }
public function onRun() : void{ public function onRun() : void{