From e392a6a8073bca339cf1e4d9017fc35178a7529e Mon Sep 17 00:00:00 2001
From: "Dylan K. Taylor" <odigiman@gmail.com>
Date: Wed, 6 May 2020 13:32:18 +0100
Subject: [PATCH] PrepareEncryptionTask: do not store onCompletion as a field
 pthreads will screw around with it and make it do things it's not supposed
 to, which is the exact reason why we have thread-local storage to begin with.

---
 src/network/mcpe/encryption/PrepareEncryptionTask.php | 6 ------
 1 file changed, 6 deletions(-)

diff --git a/src/network/mcpe/encryption/PrepareEncryptionTask.php b/src/network/mcpe/encryption/PrepareEncryptionTask.php
index 13992f37c..aae896853 100644
--- a/src/network/mcpe/encryption/PrepareEncryptionTask.php
+++ b/src/network/mcpe/encryption/PrepareEncryptionTask.php
@@ -45,11 +45,6 @@ class PrepareEncryptionTask extends AsyncTask{
 	private $handshakeJwt = null;
 	/** @var PublicKeyInterface */
 	private $clientPub;
-	/**
-	 * @var \Closure
-	 * @phpstan-var \Closure(string $encryptionKey, string $handshakeJwt) : void
-	 */
-	private $onCompletion;
 
 	/**
 	 * @phpstan-param \Closure(string $encryptionKey, string $handshakeJwt) : void $onCompletion
@@ -62,7 +57,6 @@ class PrepareEncryptionTask extends AsyncTask{
 		$this->serverPrivateKey = self::$SERVER_PRIVATE_KEY;
 		$this->clientPub = $clientPub;
 		$this->storeLocal(self::TLS_KEY_ON_COMPLETION, $onCompletion);
-		$this->onCompletion = $onCompletion;
 	}
 
 	public function onRun() : void{