mirrors/PocketMine-MP
1
0
Fork 0
mirror of https://github.com/pmmp/PocketMine-MP.git synced 2025-09-08 19:02:59 +00:00
Code Issues Projects Releases Wiki Activity

Move player creation out of NetworkSession

Browse Source
This commit is contained in:
Dylan K. Taylor
2020-12-13 21:20:37 +00:00
parent 6f09d472e2
commit c0438f1ddb
2 changed files with 20 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
src/network/mcpe/NetworkSession.php
View File

@ -31,7 +31,6 @@ use pocketmine\entity\effect\EffectInstance;
use pocketmine\entity\Entity;
use pocketmine\entity\Human;
use pocketmine\entity\Living;
use pocketmine\event\player\PlayerCreationEvent;
use pocketmine\event\server\DataPacketReceiveEvent;
use pocketmine\event\server\DataPacketSendEvent;
use pocketmine\form\Form;
@ -230,16 +229,7 @@ class NetworkSession{
}
protected function createPlayer() : void{
$ev = new PlayerCreationEvent($this);
$ev->call();
$class = $ev->getPlayerClass();
//TODO: make this async
//TODO: this really has no business being in NetworkSession at all - what about allowing it to be provided by PlayerCreationEvent?
$namedtag = $this->server->getOfflinePlayerData($this->info->getUsername());
/** @see Player::__construct() */
$this->player = new $class($this->server, $this, $this->info, $this->authenticated, $namedtag);
$this->player = $this->server->createPlayer($this, $this->info, $this->authenticated);
$this->invManager = new InventoryManager($this->player, $this);