mirror of
https://github.com/pmmp/PocketMine-MP.git
synced 2025-04-21 00:07:30 +00:00
Ensure overloaded members can't conflict with static ones and vice versa
This commit is contained in:
parent
f4f31b654b
commit
b1e4e44f77
@ -66,7 +66,7 @@ trait RegistryTrait{
|
||||
}
|
||||
self::verifyName($name);
|
||||
$upperName = mb_strtoupper($name);
|
||||
if(isset(self::$members[$upperName])){
|
||||
if(isset(self::$members[$upperName]) || isset(self::$overloadedMembers[$upperName])){
|
||||
throw new \InvalidArgumentException("\"$upperName\" is already reserved");
|
||||
}
|
||||
self::$members[$upperName] = $member;
|
||||
@ -80,8 +80,8 @@ trait RegistryTrait{
|
||||
private static function registerOverloaded(string $baseName, string $enumClass, string $returnClass) : void{
|
||||
self::verifyName($baseName);
|
||||
$upperName = mb_strtoupper($baseName);
|
||||
if(isset(self::$overloadedMembers[$upperName])){
|
||||
throw new \InvalidArgumentException("Overloaded member name \"$upperName\" is already reserved");
|
||||
if(isset(self::$members[$upperName]) || isset(self::$overloadedMembers[$upperName])){
|
||||
throw new \InvalidArgumentException("\"$upperName\" is already reserved");
|
||||
}
|
||||
$enumToMemberMap = [];
|
||||
foreach($enumClass::cases() as $case){
|
||||
|
Loading…
x
Reference in New Issue
Block a user