mirrors/PocketMine-MP
1
0
Fork 0
mirror of https://github.com/pmmp/PocketMine-MP.git synced 2025-06-27 21:59:52 +00:00
Code Issues Projects Releases Wiki Activity

Torch: Fix placement issues when clicking the bottom of a block, closes #2453 (#2474)

Browse Source
This commit is contained in:
Andrew 2018-10-12 12:26:44 +01:00 committed by Dylan K. Taylor
parent 9901e61d65
commit a944641509
1 changed files with 19 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

26
src/pocketmine/block/Torch.php
View File

@ -73,16 +73,28 @@ class Torch extends Flowable{
}
public function place(Item $item, Block $blockReplace, Block $blockClicked, int $face, Vector3 $clickVector, Player $player = null) : bool{
$below = $this->getSide(Facing::DOWN);
if(!$blockClicked->isTransparent() and $face !== Facing::DOWN){
$this->facing = $face;
return parent::place($item, $blockReplace, $blockClicked, $face, $clickVector, $player);
}elseif(!$below->isTransparent() or $below->getId() === self::FENCE or $below->getId() === self::COBBLESTONE_WALL){
if($blockClicked->canBeReplaced() and !$blockClicked->getSide(Facing::DOWN)->isTransparent()){
$this->facing = Facing::UP;
return parent::place($item, $blockReplace, $blockClicked, $face, $clickVector, $player);
}elseif($face !== Facing::DOWN and (!$blockClicked->isTransparent() or ($face === Facing::UP and ($blockClicked->getId() === self::FENCE or $blockClicked->getId() === self::COBBLESTONE_WALL)))){
$this->facing = $face;
return parent::place($item, $blockReplace, $blockClicked, $face, $clickVector, $player);
}else{
static $faces = [
Facing::SOUTH,
Facing::WEST,
Facing::NORTH,
Facing::EAST,
Facing::DOWN,
];
foreach($faces as $side){
$block = $this->getSide($side);
if(!$block->isTransparent()){
$this->facing = Facing::opposite($side);
return parent::place($item, $blockReplace, $blockClicked, $face, $clickVector, $player);
}
}
}
return false;
}
}