mirrors/PocketMine-MP
1
0
Fork 0
mirror of https://github.com/pmmp/PocketMine-MP.git synced 2025-07-06 01:51:51 +00:00
Code Issues Projects Releases Wiki Activity

Player: Do direction checks for interaction in 3D instead of 2D

Browse Source 
This fixes #983, but I haven't yet tested if this will prevent cheating in an actual hacker scenario. Needs more tests.

Additionally, this should remove the need for the negative threshold - if the diff is less than 0, the player is almost definitely cheating.
This commit is contained in:
Dylan K. Taylor 2017-12-22 20:06:59 +00:00
parent 0688a86f57
commit a8bf2191b9
1 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
src/pocketmine/Player.php
View File

@ -1753,10 +1753,10 @@ class Player extends Human implements CommandSender, ChunkLoader, IPlayer{
return false; return false;
} }
$dV = $this->getDirectionPlane(); $dV = $this->getDirectionVector();
$dot = $dV->dot(new Vector2($eyePos->x, $eyePos->z)); $eyeDot = $dV->dot($eyePos);
$dot1 = $dV->dot(new Vector2($pos->x, $pos->z)); $targetDot = $dV->dot($pos);
return ($dot1 - $dot) >= -$maxDiff; return ($targetDot - $eyeDot) >= -$maxDiff;
} }
protected function initHumanData(){ protected function initHumanData(){