mirrors/PocketMine-MP
1
0
Fork 0
mirror of https://github.com/pmmp/PocketMine-MP.git synced 2025-04-20 16:00:20 +00:00
Code Issues Projects Releases Wiki Activity

LevelSoundEventPacket: fixed bad null assignment in ::create()

Browse Source
This commit is contained in:
Dylan K. Taylor 2021-07-14 15:21:33 +01:00
parent c474aa42e5
commit 9f11be25cb
No known key found for this signature in database
GPG Key ID: 8927471A91CAFD3D
2 changed files with 1 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/network/mcpe/protocol/LevelSoundEventPacket.php
View File

@ -364,7 +364,7 @@ class LevelSoundEventPacket extends DataPacket implements ClientboundPacket, Ser
$result = new self;
$result->sound = $sound;
$result->extraData = $extraData;
$result->position = $pos;
$result->position = $pos ?? new Vector3(0, 0, 0);
$result->disableRelativeVolume = $pos === null;
$result->entityType = $entityType;
$result->isBabyMob = $isBabyMob;

5
tests/phpstan/configs/l8-baseline.neon
View File

@ -190,11 +190,6 @@ parameters:
count: 1
path: ../../../src/network/mcpe/NetworkSession.php
-
message: "#^Property pocketmine\\\\network\\\\mcpe\\\\protocol\\\\LevelSoundEventPacket\\:\\:\\$position \\(pocketmine\\\\math\\\\Vector3\\) does not accept pocketmine\\\\math\\\\Vector3\\|null\\.$#"
count: 1
path: ../../../src/network/mcpe/protocol/LevelSoundEventPacket.php
-
message: "#^Parameter \\#1 \\$eid of method pocketmine\\\\network\\\\mcpe\\\\protocol\\\\serializer\\\\PacketSerializer\\:\\:putEntityUniqueId\\(\\) expects int, int\\|null given\\.$#"
count: 1