From 9f11be25cb7d8ac32018fdcb7042b6cc6fdf45bb Mon Sep 17 00:00:00 2001
From: "Dylan K. Taylor" <dktapps@pmmp.io>
Date: Wed, 14 Jul 2021 15:21:33 +0100
Subject: [PATCH] LevelSoundEventPacket: fixed bad null assignment in
 ::create()

---
 src/network/mcpe/protocol/LevelSoundEventPacket.php | 2 +-
 tests/phpstan/configs/l8-baseline.neon              | 5 -----
 2 files changed, 1 insertion(+), 6 deletions(-)

diff --git a/src/network/mcpe/protocol/LevelSoundEventPacket.php b/src/network/mcpe/protocol/LevelSoundEventPacket.php
index 45052d6e0..58476cae8 100644
--- a/src/network/mcpe/protocol/LevelSoundEventPacket.php
+++ b/src/network/mcpe/protocol/LevelSoundEventPacket.php
@@ -364,7 +364,7 @@ class LevelSoundEventPacket extends DataPacket implements ClientboundPacket, Ser
 		$result = new self;
 		$result->sound = $sound;
 		$result->extraData = $extraData;
-		$result->position = $pos;
+		$result->position = $pos ?? new Vector3(0, 0, 0);
 		$result->disableRelativeVolume = $pos === null;
 		$result->entityType = $entityType;
 		$result->isBabyMob = $isBabyMob;
diff --git a/tests/phpstan/configs/l8-baseline.neon b/tests/phpstan/configs/l8-baseline.neon
index 9af2e2e80..98057695c 100644
--- a/tests/phpstan/configs/l8-baseline.neon
+++ b/tests/phpstan/configs/l8-baseline.neon
@@ -190,11 +190,6 @@ parameters:
 			count: 1
 			path: ../../../src/network/mcpe/NetworkSession.php
 
-		-
-			message: "#^Property pocketmine\\\\network\\\\mcpe\\\\protocol\\\\LevelSoundEventPacket\\:\\:\\$position \\(pocketmine\\\\math\\\\Vector3\\) does not accept pocketmine\\\\math\\\\Vector3\\|null\\.$#"
-			count: 1
-			path: ../../../src/network/mcpe/protocol/LevelSoundEventPacket.php
-
 		-
 			message: "#^Parameter \\#1 \\$eid of method pocketmine\\\\network\\\\mcpe\\\\protocol\\\\serializer\\\\PacketSerializer\\:\\:putEntityUniqueId\\(\\) expects int, int\\|null given\\.$#"
 			count: 1