mirrors/PocketMine-MP
1
0
Fork 0
mirror of https://github.com/pmmp/PocketMine-MP.git synced 2025-05-15 18:29:46 +00:00
Code Issues Projects Releases Wiki Activity

Fixed incorrect unknown item filtering logic

Browse Source 
this caused recipes with wildcard inputs to not show up at all.
This commit is contained in:
Dylan K. Taylor 2022-06-06 18:50:40 +01:00
parent 08fbf92d8d
commit 93124c79ea
No known key found for this signature in database
GPG Key ID: 8927471A91CAFD3D
1 changed files with 5 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
src/crafting/CraftingManagerFromDataHelper.php
View File

@ -41,11 +41,12 @@ final class CraftingManagerFromDataHelper{
private static function containsUnknownItems(array $items) : bool{
$factory = ItemFactory::getInstance();
foreach($items as $item){
if(
if($item instanceof Durable || $item->hasAnyDamageValue()){
//TODO: this check is imperfect and might cause problems if meta 0 isn't used for some reason
(($item instanceof Durable || $item->hasAnyDamageValue()) && !$factory->isRegistered($item->getId())) ||
!$factory->isRegistered($item->getId(), $item->getMeta())
){
if(!$factory->isRegistered($item->getId())){
return true;
}
}elseif(!$factory->isRegistered($item->getId(), $item->getMeta())){
return true;
}
}