From 93124c79eae6f6f7960da6d5a35cbf0401885383 Mon Sep 17 00:00:00 2001 From: "Dylan K. Taylor" Date: Mon, 6 Jun 2022 18:50:40 +0100 Subject: [PATCH] Fixed incorrect unknown item filtering logic this caused recipes with wildcard inputs to not show up at all. --- src/crafting/CraftingManagerFromDataHelper.php | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/src/crafting/CraftingManagerFromDataHelper.php b/src/crafting/CraftingManagerFromDataHelper.php index 8de00ff62..30b327f1e 100644 --- a/src/crafting/CraftingManagerFromDataHelper.php +++ b/src/crafting/CraftingManagerFromDataHelper.php @@ -41,11 +41,12 @@ final class CraftingManagerFromDataHelper{ private static function containsUnknownItems(array $items) : bool{ $factory = ItemFactory::getInstance(); foreach($items as $item){ - if( + if($item instanceof Durable || $item->hasAnyDamageValue()){ //TODO: this check is imperfect and might cause problems if meta 0 isn't used for some reason - (($item instanceof Durable || $item->hasAnyDamageValue()) && !$factory->isRegistered($item->getId())) || - !$factory->isRegistered($item->getId(), $item->getMeta()) - ){ + if(!$factory->isRegistered($item->getId())){ + return true; + } + }elseif(!$factory->isRegistered($item->getId(), $item->getMeta())){ return true; } }