mirrors/PocketMine-MP
1
0
Fork 0
mirror of https://github.com/pmmp/PocketMine-MP.git synced 2025-07-25 04:13:44 +00:00
Code Issues Projects Releases Wiki Activity

Entity: Avoid using close() during initEntity()

Browse Source 
this simply conceals bugs and will cause astonishing behaviour.
This commit is contained in:
Dylan K. Taylor 2018-06-09 17:06:15 +01:00
parent 85136b7b4a
commit 8e5aca70b4
2 changed files with 2 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
src/pocketmine/entity/object/FallingBlock.php
View File

@ -64,8 +64,7 @@ class FallingBlock extends Entity{
} }
if($blockId === 0){ if($blockId === 0){
$this->close(); throw new \UnexpectedValueException("Invalid " . get_class($this) . " entity: block ID is 0 or missing");
return;
} }
$damage = $this->namedtag->getByte("Data", 0); $damage = $this->namedtag->getByte("Data", 0);

3
src/pocketmine/entity/object/ItemEntity.php
View File

@ -66,8 +66,7 @@ class ItemEntity extends Entity{
$itemTag = $this->namedtag->getCompoundTag("Item"); $itemTag = $this->namedtag->getCompoundTag("Item");
if($itemTag === null){ if($itemTag === null){
$this->close(); throw new \UnexpectedValueException("Invalid " . get_class($this) . " entity: expected \"Item\" NBT tag not found");
return;
} }
$this->item = Item::nbtDeserialize($itemTag); $this->item = Item::nbtDeserialize($itemTag);