mirrors/PocketMine-MP
1
0
Fork 0
mirror of https://github.com/pmmp/PocketMine-MP.git synced 2025-09-06 17:59:48 +00:00
Code Issues Projects Releases Wiki Activity

Entity: Invalid blocksAround cache when something happens during onEntityInside()

Browse Source 
this fixes TNT spawning multiple entities when lit by flaming arrows.
The problem here is a bit more complex (entities aren't immediately notified when local block updates happen, so they cache stuff that becomes unusable). The simplest option would be to just lose the cache, but that would have some impacts on performance.
Barring a rethink of the block updating mechanism, this solution seems usable for now.
This commit is contained in:
Dylan K. Taylor
2020-09-25 16:35:59 +01:00
parent ae9e931849
commit 8e12693494
12 changed files with 29 additions and 13 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
src/block/Fire.php
View File

@ -68,7 +68,7 @@ class Fire extends Flowable{
return true;
}
public function onEntityInside(Entity $entity) : void{
public function onEntityInside(Entity $entity) : bool{
$ev = new EntityDamageByBlockEvent($this, $entity, EntityDamageEvent::CAUSE_FIRE, 1);
$entity->attack($ev);
@ -80,6 +80,7 @@ class Fire extends Flowable{
if(!$ev->isCancelled()){
$entity->setOnFire($ev->getDuration());
}
return true;
}
public function getDropsForCompatibleTool(Item $item) : array{