mirrors/PocketMine-MP
1
0
Fork 0
mirror of https://github.com/pmmp/PocketMine-MP.git synced 2025-10-19 04:15:04 +00:00
Code Issues Projects Releases Wiki Activity

performance: only calculate light for chunks inside ticking areas

Browse Source 
this produces a major performance improvement for large render distances, and reduces the impact of lighting calculation to zero on servers which have random blockupdates turned off.
This commit is contained in:
Dylan K. Taylor
2020-09-26 13:13:12 +01:00
parent b727972c76
commit 89cce4c749
4 changed files with 12 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
src/world/format/Chunk.php
View File

@@ -58,7 +58,7 @@ class Chunk{
/** @var int */
private $dirtyFlags = 0;
/** @var bool */
/** @var bool|null */
protected $lightPopulated = false;
/** @var bool */
protected $terrainGenerated = false;
@@ -387,11 +387,11 @@ class Chunk{
$this->dirtyFlags |= self::DIRTY_FLAG_BIOMES;
}
public function isLightPopulated() : bool{
public function isLightPopulated() : ?bool{
return $this->lightPopulated;
}
public function setLightPopulated(bool $value = true) : void{
public function setLightPopulated(?bool $value = true) : void{
$this->lightPopulated = $value;
}

2
src/world/format/io/FastChunkSerializer.php
View File

@@ -59,7 +59,7 @@ final class FastChunkSerializer{
* TODO: tiles and entities
*/
public static function serialize(Chunk $chunk, bool $includeLight = true) : string{
$includeLight = $includeLight && $chunk->isLightPopulated();
$includeLight = $includeLight && $chunk->isLightPopulated() === true;
$stream = new BinaryStream();
$stream->putInt($chunk->getX());