mirrors/PocketMine-MP
1
0
Fork 0
mirror of https://github.com/pmmp/PocketMine-MP.git synced 2025-06-07 12:18:46 +00:00
Code Issues Projects Releases Wiki Activity

Level: Remove redundant null checks for Item->getBlock()

Browse Source 
this is typehinted to return Block, so these checks are pointless.
This commit is contained in:
Dylan K. Taylor 2018-02-16 10:45:54 +00:00
parent 9395dbf9fa
commit 7fc3eeab00
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/pocketmine/level/Level.php
View File

@ -1748,7 +1748,7 @@ class Level implements ChunkManager, Metadatable{
foreach($tag as $v){ foreach($tag as $v){
if($v instanceof StringTag){ if($v instanceof StringTag){
$entry = ItemFactory::fromString($v->getValue()); $entry = ItemFactory::fromString($v->getValue());
if($entry->getId() > 0 and $entry->getBlock() !== null and $entry->getBlock()->getId() === $target->getId()){ if($entry->getId() > 0 and $entry->getBlock()->getId() === $target->getId()){
$canBreak = true; $canBreak = true;
break; break;
} }
@ -1916,7 +1916,7 @@ class Level implements ChunkManager, Metadatable{
foreach($tag as $v){ foreach($tag as $v){
if($v instanceof StringTag){ if($v instanceof StringTag){
$entry = ItemFactory::fromString($v->getValue()); $entry = ItemFactory::fromString($v->getValue());
if($entry->getId() > 0 and $entry->getBlock() !== null and $entry->getBlock()->getId() === $blockClicked->getId()){ if($entry->getId() > 0 and $entry->getBlock()->getId() === $blockClicked->getId()){
$canPlace = true; $canPlace = true;
break; break;
} }