From 7fc3eeab00c88e968575a12df74609dbabd00fe8 Mon Sep 17 00:00:00 2001 From: "Dylan K. Taylor" Date: Fri, 16 Feb 2018 10:45:54 +0000 Subject: [PATCH] Level: Remove redundant null checks for Item->getBlock() this is typehinted to return Block, so these checks are pointless. --- src/pocketmine/level/Level.php | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/pocketmine/level/Level.php b/src/pocketmine/level/Level.php index 31dc23b9b..84c2da690 100644 --- a/src/pocketmine/level/Level.php +++ b/src/pocketmine/level/Level.php @@ -1748,7 +1748,7 @@ class Level implements ChunkManager, Metadatable{ foreach($tag as $v){ if($v instanceof StringTag){ $entry = ItemFactory::fromString($v->getValue()); - if($entry->getId() > 0 and $entry->getBlock() !== null and $entry->getBlock()->getId() === $target->getId()){ + if($entry->getId() > 0 and $entry->getBlock()->getId() === $target->getId()){ $canBreak = true; break; } @@ -1916,7 +1916,7 @@ class Level implements ChunkManager, Metadatable{ foreach($tag as $v){ if($v instanceof StringTag){ $entry = ItemFactory::fromString($v->getValue()); - if($entry->getId() > 0 and $entry->getBlock() !== null and $entry->getBlock()->getId() === $blockClicked->getId()){ + if($entry->getId() > 0 and $entry->getBlock()->getId() === $blockClicked->getId()){ $canPlace = true; break; }