mirrors/PocketMine-MP
1
0
Fork 0
mirror of https://github.com/pmmp/PocketMine-MP.git synced 2025-06-11 05:55:33 +00:00
Code Issues Projects Releases Wiki Activity

Remove random dead TODOs

Browse Source
This commit is contained in:
Dylan K. Taylor 2023-04-13 12:47:08 +01:00
parent 874fdf5adb
commit 6703f46a08
No known key found for this signature in database
GPG Key ID: 8927471A91CAFD3D
2 changed files with 1 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
src/block/RuntimeBlockStateRegistry.php
View File

@ -99,7 +99,6 @@ class RuntimeBlockStateRegistry{
try{ try{
$v->decodeTypeAndStateData($stateData); $v->decodeTypeAndStateData($stateData);
if($v->computeTypeAndStateData() !== $stateData){ if($v->computeTypeAndStateData() !== $stateData){
//TODO: this should probably be a hard error
throw new \LogicException(get_class($block) . "::decodeStateData() accepts invalid state data (returned " . $v->computeTypeAndStateData() . " for input $stateData)"); throw new \LogicException(get_class($block) . "::decodeStateData() accepts invalid state data (returned " . $v->computeTypeAndStateData() . " for input $stateData)");
} }
}catch(InvalidSerializedRuntimeDataException){ //invalid property combination, leave it }catch(InvalidSerializedRuntimeDataException){ //invalid property combination, leave it

3
src/world/format/io/leveldb/LevelDB.php
View File

@ -627,7 +627,6 @@ class LevelDB extends BaseWorldProvider implements WritableWorldProvider{
$subChunks = $this->deserializeLegacyTerrainData($index, $chunkVersion); $subChunks = $this->deserializeLegacyTerrainData($index, $chunkVersion);
break; break;
default: default:
//TODO: set chunks read-only so the version on disk doesn't get overwritten
throw new CorruptedChunkException("don't know how to decode chunk format version $chunkVersion"); throw new CorruptedChunkException("don't know how to decode chunk format version $chunkVersion");
} }
@ -664,7 +663,7 @@ class LevelDB extends BaseWorldProvider implements WritableWorldProvider{
//TODO: tile ticks, biome states (?) //TODO: tile ticks, biome states (?)
$chunk = new Chunk( $chunk = new Chunk(
$subChunks, //TODO: maybe missing biomes should be an error? $subChunks,
$terrainPopulated $terrainPopulated
); );