diff --git a/src/block/RuntimeBlockStateRegistry.php b/src/block/RuntimeBlockStateRegistry.php index cdcd4b73a..080690c28 100644 --- a/src/block/RuntimeBlockStateRegistry.php +++ b/src/block/RuntimeBlockStateRegistry.php @@ -99,7 +99,6 @@ class RuntimeBlockStateRegistry{ try{ $v->decodeTypeAndStateData($stateData); if($v->computeTypeAndStateData() !== $stateData){ - //TODO: this should probably be a hard error throw new \LogicException(get_class($block) . "::decodeStateData() accepts invalid state data (returned " . $v->computeTypeAndStateData() . " for input $stateData)"); } }catch(InvalidSerializedRuntimeDataException){ //invalid property combination, leave it diff --git a/src/world/format/io/leveldb/LevelDB.php b/src/world/format/io/leveldb/LevelDB.php index ff57d14cd..8c0a43287 100644 --- a/src/world/format/io/leveldb/LevelDB.php +++ b/src/world/format/io/leveldb/LevelDB.php @@ -627,7 +627,6 @@ class LevelDB extends BaseWorldProvider implements WritableWorldProvider{ $subChunks = $this->deserializeLegacyTerrainData($index, $chunkVersion); break; default: - //TODO: set chunks read-only so the version on disk doesn't get overwritten throw new CorruptedChunkException("don't know how to decode chunk format version $chunkVersion"); } @@ -664,7 +663,7 @@ class LevelDB extends BaseWorldProvider implements WritableWorldProvider{ //TODO: tile ticks, biome states (?) $chunk = new Chunk( - $subChunks, //TODO: maybe missing biomes should be an error? + $subChunks, $terrainPopulated );