mirrors/PocketMine-MP
1
0
Fork 0
mirror of https://github.com/pmmp/PocketMine-MP.git synced 2025-06-07 04:17:07 +00:00
Code Issues Projects Releases Wiki Activity

Command: remove unnecessary getPermission() calls

Browse Source
This commit is contained in:
Dylan K. Taylor 2018-07-05 10:38:31 +01:00
parent 0df3585c81
commit 58f0ad3e3e
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/pocketmine/command/Command.php
View File

@ -127,7 +127,7 @@ abstract class Command{
if($this->permissionMessage === null){ if($this->permissionMessage === null){
$target->sendMessage($target->getServer()->getLanguage()->translateString(TextFormat::RED . "%commands.generic.permission")); $target->sendMessage($target->getServer()->getLanguage()->translateString(TextFormat::RED . "%commands.generic.permission"));
}elseif($this->permissionMessage !== ""){ }elseif($this->permissionMessage !== ""){
$target->sendMessage(str_replace("<permission>", $this->getPermission(), $this->permissionMessage)); $target->sendMessage(str_replace("<permission>", $this->permission, $this->permissionMessage));
} }
return false; return false;
@ -139,11 +139,11 @@ abstract class Command{
* @return bool * @return bool
*/ */
public function testPermissionSilent(CommandSender $target) : bool{ public function testPermissionSilent(CommandSender $target) : bool{
if(($perm = $this->getPermission()) === null or $perm === ""){ if($this->permission === null or $this->permission === ""){
return true; return true;
} }
foreach(explode(";", $perm) as $permission){ foreach(explode(";", $this->permission) as $permission){
if($target->hasPermission($permission)){ if($target->hasPermission($permission)){
return true; return true;
} }