From 58f0ad3e3e935042e9b3152876468317f06ad4b4 Mon Sep 17 00:00:00 2001 From: "Dylan K. Taylor" Date: Thu, 5 Jul 2018 10:38:31 +0100 Subject: [PATCH] Command: remove unnecessary getPermission() calls --- src/pocketmine/command/Command.php | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/pocketmine/command/Command.php b/src/pocketmine/command/Command.php index 759eed18f9..09231ffe48 100644 --- a/src/pocketmine/command/Command.php +++ b/src/pocketmine/command/Command.php @@ -127,7 +127,7 @@ abstract class Command{ if($this->permissionMessage === null){ $target->sendMessage($target->getServer()->getLanguage()->translateString(TextFormat::RED . "%commands.generic.permission")); }elseif($this->permissionMessage !== ""){ - $target->sendMessage(str_replace("", $this->getPermission(), $this->permissionMessage)); + $target->sendMessage(str_replace("", $this->permission, $this->permissionMessage)); } return false; @@ -139,11 +139,11 @@ abstract class Command{ * @return bool */ public function testPermissionSilent(CommandSender $target) : bool{ - if(($perm = $this->getPermission()) === null or $perm === ""){ + if($this->permission === null or $this->permission === ""){ return true; } - foreach(explode(";", $perm) as $permission){ + foreach(explode(";", $this->permission) as $permission){ if($target->hasPermission($permission)){ return true; }