mirrors/PocketMine-MP
1
0
Fork 0
mirror of https://github.com/pmmp/PocketMine-MP.git synced 2025-09-07 10:22:56 +00:00
Code Issues Projects Releases Wiki Activity

TextFormat: do not assume that an array given to toHTML() is actually a tokenized string

Browse Source 
this is a far stretch, since the documentation doesn't mention that the string needs to be tokenized. Anyone passing an array in here is most likely doing so by mistake.
This commit is contained in:
Dylan K. Taylor
2021-08-12 23:37:00 +01:00
parent a59ac522ee
commit 34309bc810
1 changed files with 2 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
src/utils/TextFormat.php
View File

@ -159,16 +159,11 @@ abstract class TextFormat{
/**
* Returns an HTML-formatted string with colors/markup
*
* @param string|string[] $string
*/
public static function toHTML($string) : string{
if(!is_array($string)){
$string = self::tokenize($string);
}
public static function toHTML(string $string) : string{
$newString = "";
$tokens = 0;
foreach($string as $token){
foreach(self::tokenize($string) as $token){
switch($token){
case TextFormat::BOLD:
$newString .= "<span style=font-weight:bold>";