mirrors/PocketMine-MP
1
0
Fork 0
mirror of https://github.com/pmmp/PocketMine-MP.git synced 2025-04-22 00:33:59 +00:00
Code Issues Projects Releases Wiki Activity

Terminal: do not assume that an array given to toANSI() is actually a tokenized string

Browse Source 
this is a far stretch, since the documentation doesn't mention that the string needs to be tokenized. Anyone passing an array in here is most likely doing so by mistake.
This commit is contained in:
Dylan K. Taylor 2021-08-12 23:35:45 +01:00
parent ab232ee759
commit a59ac522ee
No known key found for this signature in database
GPG Key ID: 8927471A91CAFD3D
1 changed files with 2 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
src/utils/Terminal.php
View File

@ -27,7 +27,6 @@ use function fclose;
use function fopen;
use function function_exists;
use function getenv;
use function is_array;
use function sapi_windows_vt100_support;
use function stream_isatty;
use const PHP_EOL;
@ -177,16 +176,10 @@ abstract class Terminal{
/**
* Returns a string with colorized ANSI Escape codes for the current terminal
* Note that this is platform-dependent and might produce different results depending on the terminal type and/or OS.
*
* @param string|string[] $string
*/
public static function toANSI($string) : string{
if(!is_array($string)){
$string = TextFormat::tokenize($string);
}
public static function toANSI(string $string) : string{
$newString = "";
foreach($string as $token){
foreach(TextFormat::tokenize($string) as $token){
$newString .= match($token){
TextFormat::BOLD => Terminal::$FORMAT_BOLD,
TextFormat::OBFUSCATED => Terminal::$FORMAT_OBFUSCATED,