mirrors/PocketMine-MP
1
0
Fork 0
mirror of https://github.com/pmmp/PocketMine-MP.git synced 2025-05-12 00:39:45 +00:00
Code Issues Projects Releases Wiki Activity

phpstan: ignore more errors reported by strict-rules

Browse Source
This commit is contained in:
Dylan K. Taylor 2020-02-07 22:14:51 +00:00
parent 66a1134ca1
commit 2d461251ed
2 changed files with 38 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
tests/phpstan/configs/phpstan-bugs.neon
View File

@ -21,6 +21,12 @@ parameters:
count: 1 count: 1
path: ../../../src/Server.php path: ../../../src/Server.php
-
#dynamic instanceof
message: "#^Instanceof between pocketmine\\\\block\\\\tile\\\\Tile and class\\-string\\<pocketmine\\\\block\\\\tile\\\\Tile\\> will always evaluate to true\\.$#"
count: 1
path: ../../../src/block/Block.php
- -
message: "#^Comparison operation \"\\>\\=\" between 0 and 2 is always false\\.$#" message: "#^Comparison operation \"\\>\\=\" between 0 and 2 is always false\\.$#"
count: 1 count: 1
@ -60,11 +66,22 @@ parameters:
count: 1 count: 1
path: ../../../src/network/mcpe/protocol/DataPacket.php path: ../../../src/network/mcpe/protocol/DataPacket.php
-
#object to array cast analysis bug
message: "#^Casting to string something that's already string\\.$#"
count: 1
path: ../../../src/network/mcpe/protocol/DataPacket.php
- -
message: "#^If condition is always false\\.$#" message: "#^If condition is always false\\.$#"
count: 1 count: 1
path: ../../../src/network/mcpe/protocol/types/entity/EntityMetadataCollection.php path: ../../../src/network/mcpe/protocol/types/entity/EntityMetadataCollection.php
-
message: "#^Instanceof between pocketmine\\\\network\\\\mcpe\\\\protocol\\\\types\\\\entity\\\\MetadataProperty and pocketmine\\\\network\\\\mcpe\\\\protocol\\\\types\\\\entity\\\\MetadataProperty will always evaluate to true\\.$#"
count: 1
path: ../../../src/network/mcpe/protocol/types/entity/EntityMetadataCollection.php
- -
#phpstan doesn't understand that SplFixedArray may contain null #phpstan doesn't understand that SplFixedArray may contain null
message: "#^Call to static method PHPUnit\\\\Framework\\\\Assert\\:\\:assertNotNull\\(\\) with int and string will always evaluate to true\\.$#" message: "#^Call to static method PHPUnit\\\\Framework\\\\Assert\\:\\:assertNotNull\\(\\) with int and string will always evaluate to true\\.$#"

21
tests/phpstan/configs/runtime-type-checks.neon
View File

@ -1,5 +1,20 @@
parameters: parameters:
ignoreErrors: ignoreErrors:
-
message: "#^Instanceof between pocketmine\\\\block\\\\utils\\\\BannerPattern and pocketmine\\\\block\\\\utils\\\\BannerPattern will always evaluate to true\\.$#"
count: 1
path: ../../../src/block/Banner.php
-
message: "#^Call to function assert\\(\\) with bool will always evaluate to true\\.$#"
count: 2
path: ../../../src/block/tile/TileFactory.php
-
message: "#^Call to function assert\\(\\) with bool will always evaluate to true\\.$#"
count: 2
path: ../../../src/entity/EntityFactory.php
- -
message: "#^Instanceof between pocketmine\\\\event\\\\RegisteredListener and pocketmine\\\\event\\\\RegisteredListener will always evaluate to true\\.$#" message: "#^Instanceof between pocketmine\\\\event\\\\RegisteredListener and pocketmine\\\\event\\\\RegisteredListener will always evaluate to true\\.$#"
count: 1 count: 1
@ -11,6 +26,12 @@ parameters:
count: 3 count: 3
path: ../../../src/item/Item.php path: ../../../src/item/Item.php
-
#setLore()
message: "#^Call to function is_string\\(\\) with string will always evaluate to true\\.$#"
count: 1
path: ../../../src/item/Item.php
- -
#commands plugin.yml not currently validated, can't be sure #commands plugin.yml not currently validated, can't be sure
message: "#^Call to function is_array\\(\\) with array\\<string, mixed\\> will always evaluate to true\\.$#" message: "#^Call to function is_array\\(\\) with array\\<string, mixed\\> will always evaluate to true\\.$#"