mirrors/PocketMine-MP
1
0
Fork 0
mirror of https://github.com/pmmp/PocketMine-MP.git synced 2025-07-01 07:39:57 +00:00
Code Issues Projects Releases Wiki Activity

RuntimeBlockMapping: avoid keeping two copies of the same blockstate data in memory

Browse Source
This commit is contained in:
Dylan K. Taylor 2022-07-10 17:41:01 +01:00
parent 14933a731b
commit 2ba51567d8
No known key found for this signature in database
GPG Key ID: 8927471A91CAFD3D
1 changed files with 5 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
src/network/mcpe/convert/RuntimeBlockMapping.php
View File

@ -66,8 +66,11 @@ final class RuntimeBlockMapping{
private BlockStateDictionary $blockStateDictionary, private BlockStateDictionary $blockStateDictionary,
private BlockStateSerializer $blockStateSerializer private BlockStateSerializer $blockStateSerializer
){ ){
$this->fallbackStateData = new BlockStateData(BlockTypeNames::INFO_UPDATE, [], BlockStateData::CURRENT_VERSION); $this->fallbackStateId = $this->blockStateDictionary->lookupStateIdFromData(
$this->fallbackStateId = $this->blockStateDictionary->lookupStateIdFromData($this->fallbackStateData) ?? throw new AssumptionFailedError(BlockTypeNames::INFO_UPDATE . " should always exist"); new BlockStateData(BlockTypeNames::INFO_UPDATE, [], BlockStateData::CURRENT_VERSION)
) ?? throw new AssumptionFailedError(BlockTypeNames::INFO_UPDATE . " should always exist");
//lookup the state data from the dictionary to avoid keeping two copies of the same data around
$this->fallbackStateData = $this->blockStateDictionary->getDataFromStateId($this->fallbackStateId) ?? throw new AssumptionFailedError("We just looked up this state data, so it must exist");
} }
public function toRuntimeId(int $internalStateId) : int{ public function toRuntimeId(int $internalStateId) : int{