Refactored button code, fix placement rotation

src/pocketmine/block/Button.php

@@ -0,0 +1,51 @@
+<?php
+
+/*
+ *
+ *  ____            _        _   __  __ _                  __  __ ____
+ * |  _ \ ___   ___| | _____| |_|  \/  (_)_ __   ___      |  \/  |  _ \
+ * | |_) / _ \ / __| |/ / _ \ __| |\/| | | '_ \ / _ \_____| |\/| | |_) |
+ * |  __/ (_) | (__|   <  __/ |_| |  | | | | | |  __/_____| |  | |  __/
+ * |_|   \___/ \___|_|\_\___|\__|_|  |_|_|_| |_|\___|     |_|  |_|_|
+ *
+ * This program is free software: you can redistribute it and/or modify
+ * it under the terms of the GNU Lesser General Public License as published by
+ * the Free Software Foundation, either version 3 of the License, or
+ * (at your option) any later version.
+ *
+ * @author PocketMine Team
+ * @link http://www.pocketmine.net/
+ *
+ *
+*/
+
+declare(strict_types=1);
+
+namespace pocketmine\block;
+
+use pocketmine\item\Item;
+use pocketmine\math\Vector3;
+use pocketmine\Player;
+
+abstract class Button extends Flowable{
+
+	public function __construct(int $meta = 0){
+		$this->meta = $meta;
+	}
+
+	public function getVariantBitmask() : int{
+		return 0;
+	}
+
+	public function place(Item $item, Block $blockReplace, Block $blockClicked, int $face, Vector3 $facePos, Player $player = null) : bool{
+		//TODO: check valid target block
+		$this->meta = $face;
+
+		return $this->level->setBlock($this, $this, true, true);
+	}
+
+	public function onActivate(Item $item, Player $player = null) : bool{
+		//TODO
+		return true;
+	}
+}

src/pocketmine/block/StoneButton.php

@@ -23,14 +23,12 @@ declare(strict_types=1);
 
 namespace pocketmine\block;
 
-class StoneButton extends Flowable{
+use pocketmine\item\Tool;
+
+class StoneButton extends Button{
 
 	protected $id = self::STONE_BUTTON;
 
-	public function __construct(int $meta = 0){
-		$this->meta = $meta;
-	}
-
 	public function getName() : string{
 		return "Stone Button";
 	}
@@ -39,7 +37,7 @@ class StoneButton extends Flowable{
 		return 0.5;
 	}
 
-	public function getVariantBitmask() : int{
+	public function getToolType() : int{
-		return 0;
+		return Tool::TYPE_PICKAXE;
 	}
 }

src/pocketmine/block/WoodenButton.php

@@ -23,11 +23,21 @@ declare(strict_types=1);
 
 namespace pocketmine\block;
 
-class WoodenButton extends StoneButton{
+use pocketmine\item\Tool;
+
+class WoodenButton extends Button{
 
 	protected $id = self::WOODEN_BUTTON;
 
 	public function getName() : string{
 		return "Wooden Button";
 	}
+
+	public function getHardness() : float{
+		return 0.5;
+	}
+
+	public function getToolType() : int{
+		return Tool::TYPE_AXE;
+	}
 }