mirrors/PocketMine-MP
1
0
Fork 0
mirror of https://github.com/pmmp/PocketMine-MP.git synced 2025-07-01 07:39:57 +00:00
Code Issues Projects Releases Wiki Activity

Improved tile spawning

Browse Source 
There's no need to recreate the spawn packet for every single player, or re-serialize the NBT.
This commit is contained in:
Dylan K. Taylor 2017-08-27 18:40:18 +01:00
parent f4f2323518
commit 0b2b9126a2
1 changed files with 13 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

24
src/pocketmine/tile/Spawnable.php
View File

@ -31,11 +31,7 @@ use pocketmine\Player;
abstract class Spawnable extends Tile{ abstract class Spawnable extends Tile{
public function spawnTo(Player $player){ public function createSpawnPacket() : BlockEntityDataPacket{
if($this->closed){
return false;
}
$nbt = new NBT(NBT::LITTLE_ENDIAN); $nbt = new NBT(NBT::LITTLE_ENDIAN);
$nbt->setData($this->getSpawnCompound()); $nbt->setData($this->getSpawnCompound());
$pk = new BlockEntityDataPacket(); $pk = new BlockEntityDataPacket();
@ -43,7 +39,16 @@ abstract class Spawnable extends Tile{
$pk->y = $this->y; $pk->y = $this->y;
$pk->z = $this->z; $pk->z = $this->z;
$pk->namedtag = $nbt->write(true); $pk->namedtag = $nbt->write(true);
$player->dataPacket($pk);
return $pk;
}
public function spawnTo(Player $player){
if($this->closed){
return false;
}
$player->dataPacket($this->createSpawnPacket());
return true; return true;
} }
@ -58,11 +63,8 @@ abstract class Spawnable extends Tile{
return; return;
} }
foreach($this->getLevel()->getChunkPlayers($this->chunk->getX(), $this->chunk->getZ()) as $player){ $pk = $this->createSpawnPacket();
if($player->spawned === true){ $this->level->addChunkPacket($this->chunk->getX(), $this->chunk->getZ(), $pk);
$this->spawnTo($player);
}
}
} }
protected function onChanged(){ protected function onChanged(){