matthew/enhanced-discord.py
1
0
Fork 0
Code Issues 4 Pull Requests 21 Projects Releases Wiki Activity

Turn KeepAliveHandler into an asyncio.Task #94

Open
Gnome-py wants to merge 1 commits from Gnome-py/KeepAliveHandler-task into 2.0
pull from: Gnome-py/KeepAliveHandler-task
merge into: matthew:2.0
Conversation 0 Commits 1 Files Changed 1 +26 -28
Gnome-py commented 2021-10-07 16:28:54 +00:00 (Migrated from github.com)
Copy Link

Summary

For unknown reasons, the KeepAliveHandler was a thread, which just sleeps and does run_coroutine_threadsafe, which seemed kinda dumb to me. This is also the reason for a thread per voice channel, as KeepAliveHandler was subclassed for VoiceKeepAliveHandler.

This PR turns the thread into an asyncio.Task, and just uses asyncio.wait_for and await for the calls.

Checklist

  • If code changes were made then they have been tested.
    • I have updated the documentation to reflect the changes.
  • This PR fixes an issue.
  • This PR adds something new (e.g. new method or parameters).
  • This PR is a breaking change (e.g. methods or parameters removed/renamed)
  • This PR is not a code change (e.g. documentation, README, ...)
<!-- Pull requests that do not fill this information in will likely be closed --> ## Summary <!-- What is this pull request for? Does it fix any issues? --> For unknown reasons, the `KeepAliveHandler` was a thread, which just sleeps and does `run_coroutine_threadsafe`, which seemed kinda dumb to me. This is also the reason for a thread per voice channel, as `KeepAliveHandler` was subclassed for `VoiceKeepAliveHandler`. This PR turns the thread into an `asyncio.Task`, and just uses `asyncio.wait_for` and `await` for the calls. ## Checklist <!-- Put an x inside [ ] to check it, like so: [x] --> - [x] If code changes were made then they have been tested. - [ ] I have updated the documentation to reflect the changes. - [ ] This PR fixes an issue. - [ ] This PR adds something new (e.g. new method or parameters). - [ ] This PR is a breaking change (e.g. methods or parameters removed/renamed) - [ ] This PR is **not** a code change (e.g. documentation, README, ...)
This pull request can be merged automatically.
You are not authorized to merge this pull request.
View command line instructions.

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u origin Gnome-py/KeepAliveHandler-task:Gnome-py/KeepAliveHandler-task
git checkout Gnome-py/KeepAliveHandler-task
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
bug
Something isn't working
documentation
Improvements or additions to documentation
duplicate
This issue or pull request already exists
enhancement
New feature or request
good first issue
Good for newcomers
help wanted
Extra attention is needed
invalid
This doesn't seem right
question
Further information is requested
wontfix
This will not be worked on
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
matthew
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: matthew/enhanced-discord.py#94
No description provided.
Delete Branch "Gnome-py/KeepAliveHandler-task"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?