matthew/enhanced-discord.py
1
0
Fork 0
Code Issues 4 Pull Requests 21 Projects Releases Wiki Activity

Update object.py #90

Open
JDJGInc wants to merge 1 commits from JDJGInc/patch-1 into 2.0
pull from: JDJGInc/patch-1
merge into: :2.0
Conversation 3 Commits 1 Files Changed 1
+15
JDJGInc commented 2021-10-04 02:43:27 +00:00 (Migrated from github.com)
Copy Link
Copy Source

Summary

Checklist

  • If code changes were made then they have been tested.
    • I have updated the documentation to reflect the changes.
  • This PR fixes an issue.
  • This PR adds something new (e.g. new method or parameters).
  • This PR is a breaking change (e.g. methods or parameters removed/renamed)
  • This PR is not a code change (e.g. documentation, README, ...)
    this futhers:
    https://github.com/iDevision/enhanced-discord.py/pull/86
    I kind of broke the one before
<!-- Pull requests that do not fill this information in will likely be closed --> ## Summary <!-- What is this pull request for? Does it fix any issues? --> ## Checklist <!-- Put an x inside [ ] to check it, like so: [x] --> - [ ] If code changes were made then they have been tested. - [ ] I have updated the documentation to reflect the changes. - [ ] This PR fixes an issue. - [ ] This PR adds something new (e.g. new method or parameters). - [ ] This PR is a breaking change (e.g. methods or parameters removed/renamed) - [ ] This PR is **not** a code change (e.g. documentation, README, ...) this futhers: https://github.com/iDevision/enhanced-discord.py/pull/86 I kind of broke the one before
JDJGInc commented 2021-10-04 02:44:11 +00:00 (Migrated from github.com)
Copy Link
Copy Source

image
I generated the docs too.
I am not sure what I Can improve, but I think it looks pretty good to me.

![image](https://user-images.githubusercontent.com/22802640/135785728-7b767fbc-0c2f-48f1-83f2-c1232c30ab17.png) I generated the docs too. I am not sure what I Can improve, but I think it looks pretty good to me.
JDJGInc commented 2021-10-22 17:22:00 +00:00 (Migrated from github.com)
Copy Link
Copy Source

to test this pull request, I would use an object converter then have it pass in the id you want to use, then test the attributes.

to test this pull request, I would use an object converter then have it pass in the id you want to use, then test the attributes.
JDJGInc commented 2021-10-22 17:24:53 +00:00 (Migrated from github.com)
Copy Link
Copy Source

once you have an object instance, you can try created_at (which works it's from danny's work)
worker_id is new, process_id, increment_id.
object.worker_id
object.process_id
object.increment_id.
then well
object.created_at
since you want to make sure It still works.(it should, I tested this too)

once you have an object instance, you can try created_at (which works it's from danny's work) worker_id is new, process_id, increment_id. object.worker_id object.process_id object.increment_id. then well object.created_at since you want to make sure It still works.(it should, I tested this too)
You are not authorized to merge this pull request.
This pull request can be merged automatically.
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u origin JDJGInc/patch-1:JDJGInc/patch-1
git checkout JDJGInc/patch-1
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
bug
Something isn't working
 documentation
Improvements or additions to documentation
 duplicate
This issue or pull request already exists
 enhancement
New feature or request
 good first issue
Good for newcomers
 help wanted
Extra attention is needed
 invalid
This doesn't seem right
 question
Further information is requested
 wontfix
This will not be worked on
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
matthew (Matthew)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: matthew/enhanced-discord.py#90