matthew/enhanced-discord.py
1
0
Fork 0
Code Issues 4 Pull Requests 21 Projects Releases Wiki Activity

slash_commands_guilds param re-named to guilds. #81

Open
Sengolda wants to merge 4 commits from unknown repository into 2.0
pull from: unknown repository
merge into: :2.0
Conversation 3 Commits 4 Files Changed 1
+174 -54
Sengolda commented 2021-09-30 11:45:31 +00:00 (Migrated from github.com)
Copy Link
Copy Source

Summary

this pr re-names the slash_commands_guilds param to guilds.

Checklist

  • If code changes were made then they have been tested.
    • I have updated the documentation to reflect the changes.
  • This PR fixes an issue.
  • This PR adds something new (e.g. new method or parameters).
  • This PR is a breaking change (e.g. methods or parameters removed/renamed)
  • This PR is not a code change (e.g. documentation, README, ...)
## Summary this pr re-names the `slash_commands_guilds` param to `guilds`. ## Checklist - [x] If code changes were made then they have been tested. - [x] I have updated the documentation to reflect the changes. - [ ] This PR fixes an issue. - [ ] This PR adds something new (e.g. new method or parameters). - [x] This PR is a breaking change (e.g. methods or parameters removed/renamed) - [ ] This PR is **not** a code change (e.g. documentation, README, ...)
ethanolchik commented 2021-09-30 15:43:39 +00:00 (Migrated from github.com)
Copy Link
Copy Source

slash_command_guilds in my opinion is better than guilds because guilds can get confused with guild-specific commands and guild-specific slash commands.

`slash_command_guilds` in my opinion is better than `guilds` because `guilds` can get confused with guild-specific commands and guild-specific slash commands.
👍 2
GanstaKingofSA commented 2021-09-30 23:15:00 +00:00 (Migrated from github.com)
Copy Link
Copy Source

If I put on a newcomer's perspective to this being a thing, it would be a bit confusing since guilds is very similar to guild which is a class already in D.py. I think the original name is better (albiet it could be better with slash_allowed_guilds or slash_guilds) since it differs into what this function is used for i.e. slash commands and what it does i.e. targets allowed guild ids.

If I put on a newcomer's perspective to this being a thing, it would be a bit confusing since `guilds` is very similar to `guild` which is a class already in D.py. I think the original name is better (albiet it could be better with `slash_allowed_guilds` or `slash_guilds`) since it differs into what this function is used for i.e. slash commands and what it does i.e. targets allowed guild ids.
Sengolda commented 2021-10-01 05:13:15 +00:00 (Migrated from github.com)
Copy Link
Copy Source

slash_command_guilds in my opinion is better than guilds because guilds can get confused with guild-specific commands and guild-specific slash commands.

Mhm, true, but what about guild_ids ?

> `slash_command_guilds` in my opinion is better than `guilds` because `guilds` can get confused with guild-specific commands and guild-specific slash commands. Mhm, true, but what about `guild_ids` ?
This pull request is broken due to missing fork information.
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u origin unknown repository:unknown repository
git checkout unknown repository
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
bug
Something isn't working
 documentation
Improvements or additions to documentation
 duplicate
This issue or pull request already exists
 enhancement
New feature or request
 good first issue
Good for newcomers
 help wanted
Extra attention is needed
 invalid
This doesn't seem right
 question
Further information is requested
 wontfix
This will not be worked on
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
matthew (Matthew)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: matthew/enhanced-discord.py#81